Here is commented and slightly reworked readFully(). It should do
(hopefully) the same thing as the old one but (hopefully again) with a
bit more fluff for the uninitiated like me.
Do you guys think that this method can be put into some sort of
'utility' package? It seems like something generally
This version should be more efficient and cleaner too.
Will do the old code with comments too.
Bojan
---
/home/groups/devel/jakarta/jakarta-tomcat/src/share/org/apache/tomcat/util/depend/DependClassLoader.java
Mon Sep 17 11:51:16 2001
+++
+jakarta-tomcat-changed/src/share/org/apache/tomca
[EMAIL PROTECTED] wrote:
>
> Hi Bojan,
>
> First, you're a commiter now, feel free to fix anything you see
> broken :-)
Didn't know it was official. Thanks!
> Regarding this particular fix - it will not have a big performance
> impact ( except for loading .class files, which happen once ).
> H
Hi Bojan,
First, you're a commiter now, feel free to fix anything you see
broken :-)
Regarding this particular fix - it will not have a big performance
impact ( except for loading .class files, which happen once ).
However I would rather keep the old code and add comments -
reading a stream byt
After digging some more into the code of it, I've realized that the
readFully() method is really hard to understand. So, unless there are
some substantial performance gains in the existing approach, maybe we
should go with something a bit simpler.
And just as a side note, you've probably noticed
Just reformatting the e-mail to look like an actual patch. Sorry for not
following the conventions earlier.
Bojan
---
/home/groups/devel/jakarta/jakarta-tomcat/src/share/org/apache/tomcat/util/depend/DependClassLoader.java
Tue Sep 11 17:42:11 2001
+++ src/share/org/apache/tomcat/util/depend
