[EMAIL PROTECTED] wrote:
>
> Hi Bojan,
>
> First, you're a commiter now, feel free to fix anything you see
> broken :-)
Didn't know it was official. Thanks!
> Regarding this particular fix - it will not have a big performance
> impact ( except for loading .class files, which happen once ).
> However I would rather keep the old code and add comments -
> reading a stream byte-by-byte is not a good idea in any case.
OK. The patch I submitted was just a sample of a simplification.
ByteArrayOutputStream can be used with byte arrays. I'll submit one
patch along those lines.
I'll also comment the existing code (as I see) it and submit another
patch.
The only reason I would opt for ByteArrayOutputStream is simplicity. It
is obvious that designers of that class had this kind of use in mind, so
why duplicate the effort.
> I'll take a look at ZipFile.
Thanks, that's great. I'm having a few discussions with one guy at Sun
about it and he's giving me a bit of a red tape on it... But I'll get my
message across (hopefully).
Bojan
