AJP/Java connector issues

2005-05-18 Thread Mladen Turk
Hi, Just noticed a strange behavior in the Java part of the JK dealing with large (over 8184 bytes) data transfers. Since with 8192 bytes AJP packet size, the maximum transferred size per each packet is 8184 bytes one would expect that for 2 bytes file the packets would be in a form of: 1:8184,

cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c

2005-05-18 Thread mturk
mturk 2005/05/18 23:31:42 Modified:jk/native/apache-2.0 mod_jk.c Log: Fix Apache2 ws_write. There is no need to break the write to 4K chunks. Since apache does not write directly to wire but rather creates output filter buckets this will also lower the number of buckets creat

Re: JK 1.2.13 TAGGED

2005-05-18 Thread Günter Knauf
Hi, > Henri Gomez wrote: >> Or provide a jk 1.2.13a including this fix for novell ? >> > I would like to skip that, but I like the Jean-Frederic's idea > about putting the tarballs inside binaries/netware/ my concern if any is that the patch should be tested by all platforms, not only with NetWar

cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c

2005-05-18 Thread mturk
mturk 2005/05/18 11:21:59 Modified:jk/native/apache-2.0 mod_jk.c Log: Add missing FlushPackets JkOption. Revision ChangesPath 1.149 +4 -1 jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c Index: mod_jk.c

cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c

2005-05-18 Thread mturk
mturk 2005/05/18 11:19:31 Modified:jk/native/apache-1.3 mod_jk.c jk/native/apache-2.0 mod_jk.c Log: Brr... Revert latest commit. We agreed not to flush packets by default. Revision ChangesPath 1.85 +2 -2 jakarta-tomcat-connectors/jk/native/apach

cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c

2005-05-18 Thread mturk
mturk 2005/05/18 11:17:23 Modified:jk/native/apache-1.3 mod_jk.c jk/native/apache-2.0 mod_jk.c Log: Add JK_OPT_FLUSHPACKETS to default options. Revision ChangesPath 1.84 +2 -2 jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c Index:

cvs commit: jakarta-tomcat-connectors/jk/xdocs/config apache.xml

2005-05-18 Thread mturk
mturk 2005/05/18 11:04:53 Modified:jk/native/apache-1.3 mod_jk.c jk/native/apache-2.0 mod_jk.c jk/native/common jk_ajp_common.c jk_global.h jk_service.h jk/native/iis jk_isapi_plugin.c jk/native/netscape jk_nsapi_plugin.c

Re: APR support

2005-05-18 Thread Mladen Turk
Remy Maucherat wrote: Hi, After optimizing JNI invocations with NIO, I got the benchmark results I wanted from APR. The performance of the HTTP APR connector is now the same as the regular HTTP connector (at least on Windows) Here are the results for Linux: Server SLES9/amd64 with sp1. Client RHE

Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net AprEndpoint.java

2005-05-18 Thread Remy Maucherat
[EMAIL PROTECTED] wrote: mturk 2005/05/18 09:01:46 Modified:util/java/org/apache/tomcat/util/net AprEndpoint.java Log: Fix typo. data.fdpool is APR pool not APR pollset. -Poll.destroy(data.fdpool); +Pool.destroy(data.fdpoo

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net AprEndpoint.java

2005-05-18 Thread mturk
mturk 2005/05/18 09:01:46 Modified:util/java/org/apache/tomcat/util/net AprEndpoint.java Log: Fix typo. data.fdpool is APR pool not APR pollset. Revision ChangesPath 1.29 +1 -1 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.java

Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c

2005-05-18 Thread Jean-Jacques Clar
I really like being able to do: write(8K)*n + flush(). +1 on adding a FlushPackets config option set to off by default. Thank you Mladen and Jean-Frederic. Jean-Jacques >>> [EMAIL PROTECTED] 5/18/2005 7:41 AM >>> Henri Gomez wrote: > good idea. > > Which state by default ? off (-FlushPackets)

Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c

2005-05-18 Thread jean-frederic clere
Henri Gomez wrote: good idea. Which state by default ? off (-FlushPackets). 2005/5/18, jean-frederic clere <[EMAIL PROTECTED]>: Mladen Turk wrote: jean-frederic clere wrote: Mladen Turk wrote: I think on/off is enough - Think of the questions nnn will bring in user list - So how about to just add

Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c

2005-05-18 Thread Henri Gomez
good idea. Which state by default ? 2005/5/18, jean-frederic clere <[EMAIL PROTECTED]>: > Mladen Turk wrote: > > jean-frederic clere wrote: > > > >> Mladen Turk wrote: > >> > >> I think on/off is enough - Think of the questions nnn will bring in > >> user list - > >> > > > > So how about to just

DO NOT REPLY [Bug 34956] New: - Tomcat should enforce the requirements from servlet 2.4 specification SRV.8.2

2005-05-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c

2005-05-18 Thread jean-frederic clere
Mladen Turk wrote: jean-frederic clere wrote: Mladen Turk wrote: I think on/off is enough - Think of the questions nnn will bring in user list - So how about to just add the flag to JkOptions like +FlushPackets? +1. Regards, Mladen.

DO NOT REPLY [Bug 34952] New: - Installer modifies windows service when it shouldn't

2005-05-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Filter question

2005-05-18 Thread Jochen Wiedmann
Hi, suggest, that I am creating a filter, which replaces the input stream. This works fine, if the input stream is used by the application itself. However, there are cases, when the Request class itself is accessing the input stream: If the method is POST and the content type is application/x-www

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c

2005-05-18 Thread mturk
mturk 2005/05/18 04:09:55 Modified:jk/native/common jk_uri_worker_map.c Log: Log invalid uri map request as warning rather then error. No functional change. Revision ChangesPath 1.55 +2 -2 jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.c

cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c

2005-05-18 Thread mturk
mturk 2005/05/18 04:03:32 Modified:jk/native/common jk_uri_worker_map.c Log: Log invalid uri map request as warning rather then error. No functional change. Revision ChangesPath 1.54 +3 -3 jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.c

Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c

2005-05-18 Thread Mladen Turk
jean-frederic clere wrote: Mladen Turk wrote: I think on/off is enough - Think of the questions nnn will bring in user list - So how about to just add the flag to JkOptions like +FlushPackets? Regards, Mladen. - To unsubscribe, e

Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c

2005-05-18 Thread jean-frederic clere
Mladen Turk wrote: jean-frederic clere wrote: Not sure what you mean by that. Like a generic callback? Yes to able to flush the same way we write. OK, makes sense. If 'JkFlush Off' is used a single ap_rflush will be issued when all the data is send. Then why not using 'JkFlush Off' as default beha

cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 InternalAprOutputBuffer.java

2005-05-18 Thread remm
remm2005/05/18 02:25:08 Modified:http11/src/java/org/apache/coyote/http11 InternalAprOutputBuffer.java Log: - Fix write algorithm (at least a return was missing), which could likely be improved further. Thanks to Jean-Francois for spotting the problem.

[EMAIL PROTECTED]: Project jakarta-tomcat-jk-native (in module jakarta-tomcat-connectors) failed

2005-05-18 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project jakarta-tomcat-jk-native has an issue affecting its community integration. This

[EMAIL PROTECTED]: Project jakarta-tomcat-jk-native (in module jakarta-tomcat-connectors) failed

2005-05-18 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project jakarta-tomcat-jk-native has an issue affecting its community integration. This

Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c

2005-05-18 Thread Mladen Turk
jean-frederic clere wrote: Not sure what you mean by that. Like a generic callback? Yes to able to flush the same way we write. OK, makes sense. If 'JkFlush Off' is used a single ap_rflush will be issued when all the data is send. Then why not using 'JkFlush Off' as default behaviour? That makes se

cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net AprEndpoint.java

2005-05-18 Thread remm
remm2005/05/18 02:02:32 Modified:util/java/org/apache/tomcat/util/net AprEndpoint.java Log: - Remove a useless synchronized, and add some javadoc. Revision ChangesPath 1.28 +31 -4 jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.jav

Re: JK 1.2.13 TAGGED

2005-05-18 Thread Mladen Turk
Henri Gomez wrote: Or provide a jk 1.2.13a including this fix for novell ? I would like to skip that, but I like the Jean-Frederic's idea about putting the tarballs inside binaries/netware/ Anyhow, the plan was retag that as 1.2.14 if everything else is OK, or make 1.2.14-rc-(xxx), after some test

Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c

2005-05-18 Thread jean-frederic clere
Mladen Turk wrote: jean-frederic clere wrote: Mladen Turk wrote: JkFlush (On|Off|size) with On as default for each packet write. That way we'd be able to flush after each write, flush after each 'size' bytes or not flush at all. Won't it be better to have a ws_flush()? Not sure what you mean by tha

Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c

2005-05-18 Thread Mladen Turk
jean-frederic clere wrote: Mladen Turk wrote: JkFlush (On|Off|size) with On as default for each packet write. That way we'd be able to flush after each write, flush after each 'size' bytes or not flush at all. Won't it be better to have a ws_flush()? Not sure what you mean by that. Like a generic c

Re: JK 1.2.13 TAGGED

2005-05-18 Thread Henri Gomez
Or provide a jk 1.2.13a including this fix for novell ? 2005/5/18, jean-frederic clere <[EMAIL PROTECTED]>: > Mladen Turk wrote: > > Günter Knauf wrote: > > > >> Hi Mladen, > >> > >> > >>> JK 1.2.13 has been taggeded as we agreed last week, > >>> and the tarballs are available at: > >>> http://www

Re: JK 1.2.13 TAGGED

2005-05-18 Thread jean-frederic clere
Mladen Turk wrote: Günter Knauf wrote: Hi Mladen, JK 1.2.13 has been taggeded as we agreed last week, and the tarballs are available at: http://www.apache.org/dist/jakarta/tomcat-connectors/jk/source/jk-1.2.13/ any particular reason why you didnt tag my last commit on jk_connect.c? http://cvs.a

DO NOT REPLY [Bug 34693] - Tomcat infinite wait on noised network

2005-05-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: JK 1.2.13 TAGGED - ws_write call to ap_rflush in mod_jk.c

2005-05-18 Thread jean-frederic clere
Mladen Turk wrote: Jean-Jacques Clar wrote: re-sending : Am I missing details? Calling ap_rflush() at the end of ws_write() in mod_jk.c is causing me problems when doing downloads from the server to a client. Performance degradation and, less importantly, memory usage, are the problems. Seems

Re: JK 1.2.13 TAGGED

2005-05-18 Thread Mladen Turk
Henri Gomez wrote: Yes ;-) Yes what? Broke a rule or recreate the tarballs, or both :)? And put a note about this change also in the download location In a form of? Any example? Regards, Mladen. - To unsubscribe, e-mail: [EMAI

Re: JK 1.2.13 TAGGED

2005-05-18 Thread Henri Gomez
Yes ;-) And put a note about this change also in the download location 2005/5/18, Mladen Turk <[EMAIL PROTECTED]>: > Günter Knauf wrote: > > Hi Mladen, > > > > > >>JK 1.2.13 has been taggeded as we agreed last week, > >>and the tarballs are available at: > >>http://www.apache.org/dist/jakarta/t

DO NOT REPLY [Bug 34693] - Tomcat infinite wait on noised network

2005-05-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: JK 1.2.13 TAGGED

2005-05-18 Thread Mladen Turk
Günter Knauf wrote: Hi Mladen, JK 1.2.13 has been taggeded as we agreed last week, and the tarballs are available at: http://www.apache.org/dist/jakarta/tomcat-connectors/jk/source/jk-1.2.13/ any particular reason why you didnt tag my last commit on jk_connect.c? http://cvs.apache.org/viewcvs.cgi/