Re: patch for setting pane background color

2015-02-11 Thread Thomas Adam
On Wed, Feb 11, 2015 at 12:57:22AM -0600, J Raynor wrote: > I’ve attached a patch that allows you to set the foreground and > background color for a pane. The way it works is that, when tmux > writes to the screen, if it would have written with the terminal’s > default color, but you’ve set the pa

Re: patch for setting pane background color

2015-02-11 Thread Thomas Sattler
Am 11.02.2015 um 07:57 schrieb J Raynor: > Also, when you set the background color with this patch, > it changes the background for the whole pane, and not > just for the parts of the pane that have text on them This seems not to be true when using colors like #c0c0c0 (I tested with latest tmux

Master crash on Linux & cygwin

2015-02-11 Thread İsmail Dönmez
Hi currently master branch seems to be crashing on me with Linux and Cygwin, valgrind reports 2 errors which might be the culprit(s): ==21229== ERROR SUMMARY: 2 errors from 2 contexts (suppressed: 0 from 0) ==21229== ==21229== 1 errors in context 1 of 2: ==21229== Invalid read of size 4 ==21229==

Re: patch for setting pane background color

2015-02-11 Thread Thomas Adam
On Wed, Feb 11, 2015 at 12:57:22AM -0600, J Raynor wrote: > I’ve attached a patch that allows you to set the foreground and > background color for a pane. The way it works is that, when tmux > writes to the screen, if it would have written with the terminal’s > default color, but you’ve set the pa

Re: patch for setting pane background color

2015-02-11 Thread John Krueger
I'm typically a lurker on this list, but this is something I'm definitely excited to see get added! -- John Krueger On Wed, Feb 11, 2015, at 08:31 AM, Thomas Adam wrote: > On Wed, Feb 11, 2015 at 12:57:22AM -0600, J Raynor wrote: > > I’ve attached a patch that allows you to set the foreground

Re: patch for setting pane background color

2015-02-11 Thread Nicholas Marriott
This will not work as it is on terminals which do not support BCE. To make it do so you will pretty much have to make tmux support BCE :-). On Wed, Feb 11, 2015 at 12:57:22AM -0600, J Raynor wrote: > I???ve attached a patch that allows you to set the foreground and > background color for a pane.

Re: Master crash on Linux & cygwin

2015-02-11 Thread Nicholas Marriott
Try this please: Index: cmd-queue.c === RCS file: /cvs/src/usr.bin/tmux/cmd-queue.c,v retrieving revision 1.21 diff -u -p -r1.21 cmd-queue.c --- cmd-queue.c 5 Feb 2015 10:26:29 - 1.21 +++ cmd-queue.c 11 Feb 2015 18:08:58 -00

Re: Master crash on Linux & cygwin

2015-02-11 Thread İsmail Dönmez
Hi, On Wed, Feb 11, 2015 at 8:11 PM, Nicholas Marriott wrote: > Try this please: Fixes both Cygwin and Linux. Thank you! > Index: cmd-queue.c > === > RCS file: /cvs/src/usr.bin/tmux/cmd-queue.c,v > retrieving revision 1.21 > diff

Re: patch for setting pane background color

2015-02-11 Thread J Raynor
I was able to reproduce the problem. If you start tmux with the -2 flag, does the problem go away? I've attached a new patch that fixes this problem without having to pass the -2 flag. On Wed, Feb 11, 2015 at 4:54 AM, Thomas Sattler wrote: > Am 11.02.2015 um 07:57 schrieb J Raynor: >> Also, wh

Re: patch for setting pane background color

2015-02-11 Thread J Raynor
> But might make tmux flicker quite a bit over SSH or on slower terminals. I don't think it'll cause flicker. Tmux tries to limit how much needs to be written to the terminal. I did a quick login test with trickle, setting upload/download speeds to 1K, 2K, 8K, and 16K. I don't see any flickerin

Re: patch for setting pane background color

2015-02-11 Thread J Raynor
> This will not work as it is on terminals which do not support BCE. To > make it do so you will pretty much have to make tmux support BCE :-). Ok, it now works on systems that don't support BCE. I've attached a new patch. diff --git a/cmd-display-panes.c b/cmd-display-panes.c index 9ce8971..150b

Re: patch for setting pane background color

2015-02-11 Thread J Raynor
> I've taken a very quick look at this over lunch, and have put additional > fixes/suggestions on top of your patch. The branch is here: > > https://github.com/ThomasAdam/tmux/commits/jr/pane-colours > > Have a look, tell me what you think. The cleanups are pretty trivial, but > reduces some of t