Re: [PATCH 3b/3] Allow custom key tables for e.g. multiple keystroke bindings.

2014-05-14 Thread Keith Amling
> - What's the point of having key_binding_map_value and > key_binding_map_entry? Why not just one key_table struct? > key_bindings_remove can remove it from the tree and unref it, the > unref func can free it when it hits 0. > > - Also if we just have key_table then key_binding_map could be

Re: [PATCH 3b/3] Allow custom key tables for e.g. multiple keystroke bindings.

2014-05-14 Thread Nicholas Marriott
Hi I don't have a lot of time right now, but here are some comments: - What's the point of having key_binding_map_value and key_binding_map_entry? Why not just one key_table struct? key_bindings_remove can remove it from the tree and unref it, the unref func can free it when it hits 0. - A