Re: Patch for Tmux: fix race condition when starting server

2012-10-25 Thread Nicholas Marriott
Hi It's not really a bug - it's just that if-shell and run-shell are always asynchronous. Your change fixes the case where you have a config file and create the first session from "tmux new", which is fine as far as it goes, but it only affects this one case. As you say it doesn't help where I h

Re: Patch for Tmux: fix race condition when starting server

2012-10-25 Thread Rob Hoelz
Does anyone have any feedback on Nicholas' statement, or my own? I would really like this bug to be fixed, and I'm willing to do the fix myself, but I wouldn't mind a little guidance on the "right" way to do it. -Rob On 10/22/12 11:50 AM, Nicholas Marriott wrote: > Hi > > I think all jobs run wi

Re: Patch for Tmux: fix race condition when starting server

2012-10-22 Thread Nicholas Marriott
Hi I think all jobs run with run-shell/if-shell should be synchronous with other commands. This is not quite as easy to achieve however... On Mon, Oct 22, 2012 at 11:32:28AM +0200, Rob Hoelz wrote: > On 10/20/12 12:13 PM, Thomas Adam wrote: > > Hi, > > > > On 20 October 2012 00:38, Rob Hoelz w

Re: Patch for Tmux: fix race condition when starting server

2012-10-22 Thread Rob Hoelz
On 10/20/12 12:13 PM, Thomas Adam wrote: > Hi, > > On 20 October 2012 00:38, Rob Hoelz wrote: >> Ok, I'm going to try sending this patch in again; I was able to view it >> fine in my mail reader last time, but it didn't render properly in the >> SF web view. I have also improved the patch a bit;

Re: Patch for Tmux: fix race condition when starting server

2012-10-20 Thread Thomas Adam
Hi, On 20 October 2012 00:38, Rob Hoelz wrote: > Ok, I'm going to try sending this patch in again; I was able to view it > fine in my mail reader last time, but it didn't render properly in the > SF web view. I have also improved the patch a bit; it should now more > closely conform to the style

Re: Patch for Tmux: fix race condition when starting server

2012-10-19 Thread Rob Hoelz
On Thu, 18 Oct 2012 18:20:24 +0200 Rob Hoelz wrote: > Hello tmux users and developers! > > I found an interesting issue on tmux 1.7. I have the following > snippet at the end of my tmux.conf: > > if-shell "[[ -e ~/.tmux.local.conf ]]" \ > "source-file ~/.tmux.local.conf" > > In tmux.local

Patch for Tmux: fix race condition when starting server

2012-10-18 Thread Rob Hoelz
Hello tmux users and developers! I found an interesting issue on tmux 1.7. I have the following snippet at the end of my tmux.conf: if-shell "[[ -e ~/.tmux.local.conf ]]" \ "source-file ~/.tmux.local.conf" In tmux.local.conf, I set certain environment variables, depending on the machine. H