Re: [Patch] vi-copy word-movement improvements

2010-02-04 Thread Nicholas Marriott
How about this? Not changed substantially, just renamed some bits as discussed. Index: mode-key.c === RCS file: /cvs/src/usr.bin/tmux/mode-key.c,v retrieving revision 1.30 diff -u -p -r1.30 mode-key.c --- mode-key.c 1 Feb 2010 22:15

Re: [Patch] vi-copy word-movement improvements

2010-02-04 Thread Nicholas Marriott
I'll put it in tonight. On Wed, Feb 03, 2010 at 06:28:14PM -0800, Micah Cowan wrote: > Have you had a chance to look at this yet? (Just prodding) > > It's the vi-B-W-E-cmds.diff one; it introduced "non-whitespace" > word-skipping movement commands. > > I'd like this patch to get in before I sta

Re: [Patch] vi-copy word-movement improvements

2010-02-03 Thread Micah Cowan
Have you had a chance to look at this yet? (Just prodding) It's the vi-B-W-E-cmds.diff one; it introduced "non-whitespace" word-skipping movement commands. I'd like this patch to get in before I start working on the numeric command-prefix stuff, so I don't have to rework this patch to adjust for

Re: [Patch] vi-copy word-movement improvements

2010-02-03 Thread clemens fischer
On Mon-2010/01/25-22:53 Micah Cowan wrote: > Nicholas Marriott wrote: >> I'd make this something like enum window_copy_search_mode, >> WINDOW_COPY_WORDSTART, WINDOW_COPY_WORDEND. > > OOC, why do you bother with such namespaces in locally-scoped > definitions? I like Nicholas' code very much, it

Re: [Patch] vi-copy word-movement improvements

2010-01-27 Thread Nicholas Marriott
I've committed the e diff, I'll look at the other one later on. On Mon, Jan 25, 2010 at 11:09:44PM -0800, Micah Cowan wrote: > New version of the patch. It's now split into two separate diffs, and > meant to apply after your reworking of window_copy_cursor_next_word > (which isn't in Sourceforge

Re: [Patch] vi-copy word-movement improvements

2010-01-25 Thread Micah Cowan
New version of the patch. It's now split into two separate diffs, and meant to apply after your reworking of window_copy_cursor_next_word (which isn't in Sourceforge CVS yet). As you requested, I used a copy of that function, rather than introducing a flag (so the enum definition's gone, too). Apo

Re: [Patch] vi-copy word-movement improvements

2010-01-25 Thread Micah Cowan
Nicholas Marriott wrote: > Hi > > Thanks for the diff, > > I think I'd prefer to see a change to add a vi-style next-word now and the > nonspace stuff separately, if that is possible. If it is going to be too > time-consuming don't worry. I'll try and get you that tonight (PST). >> Index: mode-

Re: [Patch] vi-copy word-movement improvements

2010-01-25 Thread Nicholas Marriott
Hi Thanks for the diff, I think I'd prefer to see a change to add a vi-style next-word now and the nonspace stuff separately, if that is possible. If it is going to be too time-consuming don't worry. > Index: mode-key.c > === > ---

[Patch] vi-copy word-movement improvements

2010-01-24 Thread Micah Cowan
= Background = I've noticed that the "next-word" copy-mode command, bound to "M-f" in emacs-mode and to "w" in vi-mode, behaves more like vi's "e", which skips to the next word-ending, than its "w", which skips to the next word-beginning. Also, the vi copy mode currently lacks vi's uppercased equ