Re: [PROPOSED FEATURE & PATCH] Add the ability to automatic renaming to show the cwd.

2012-12-12 Thread Nicholas Marriott
Hi Why do you pick the last session containing the window in window_name_callback? I don't like this much, I think either we should add format_window and do without a session or follow the same logic as cmd_window_session. Otherwise this looks reasonable to me. On Tue, Dec 11, 2012 at 12:00:03

Re: [PROPOSED FEATURE & PATCH] Add the ability to automatic renaming to show the cwd.

2012-12-11 Thread Ben Boeckel
On Tue, Dec 11, 2012 at 04:09:17 GMT, Patricio Palladino wrote: > Nice setup. But I find difficult to remember to alwas use a diffent > command to "cd". I don't use it as a standard 'cd' option. I have zsh tab-completion for it too, so it's not that much of an issue confusing the two. --Ben ---

Re: [PROPOSED FEATURE & PATCH] Add the ability to automatic renaming to show the cwd.

2012-12-11 Thread Patricio Palladino
I didn't resend the entire patch, only the modified parts. Here are all the changes: diff --git a/format.c b/format.c index 19f322a..9d151fe 100644 --- a/format.c +++ b/format.c @@ -150,7 +150,7 @@ format_replace(struct format_tree *ft, const char *key, size_t keylen, char **buf, size_t *len,

Re: [PROPOSED FEATURE & PATCH] Add the ability to automatic renaming to show the cwd.

2012-12-11 Thread Patricio Palladino
Hello, On Tue, Dec 11, 2012 at 12:33 AM, Ben Boeckel wrote: > On Mon, Dec 10, 2012 at 05:13:43 GMT, Patricio Palladino wrote: > I use the following setup: > > In .tmux.conf (ignoring colors): > > setw -g window-status-format '#I.#P#F:#T-#W' > > At shell startup: > > tmux_title () { >

Re: [PROPOSED FEATURE & PATCH] Add the ability to automatic renaming to show the cwd.

2012-12-11 Thread Thomas Adam
On 11 December 2012 05:13, Patricio Palladino wrote: > Hi, > > The pane_default_command test was incomplete in that patch. Here I > corrected it, and also implemented the feature I mentioned in the > previous mail. With this conditional replacement support variables as > values with #variable_name

Re: [PROPOSED FEATURE & PATCH] Add the ability to automatic renaming to show the cwd.

2012-12-11 Thread Patricio Palladino
Hi, The pane_default_command test was incomplete in that patch. Here I corrected it, and also implemented the feature I mentioned in the previous mail. With this conditional replacement support variables as values with #variable_name. And with this, I finally can get tmux automatic renaming work a

Re: [PROPOSED FEATURE & PATCH] Add the ability to automatic renaming to show the cwd.

2012-12-10 Thread Ben Boeckel
On Mon, Dec 10, 2012 at 05:13:43 GMT, Patricio Palladino wrote: > Hi tmux community! > > I have been using tmux for the last year, and has became an essential > tool for my development job, but I used to use panes almost > exclusively until some months ago. I think automatic renaming is a > great f

Re: [PROPOSED FEATURE & PATCH] Add the ability to automatic renaming to show the cwd.

2012-12-10 Thread Thomas Adam
On Mon, Dec 10, 2012 at 06:11:09PM +, Nicholas Marriott wrote: > Yes I would be happier with a format for automatic rename, it should not > be hard to do. Here's something for someone to pick up, if they want to: diff --git a/format.c b/format.c index 19f322a..9a9ce8d 100644 --- a/format.c ++

Re: [PROPOSED FEATURE & PATCH] Add the ability to automatic renaming to show the cwd.

2012-12-10 Thread Nicholas Marriott
Yes I would be happier with a format for automatic rename, it should not be hard to do. pane_current_path is already the WD from osdep_get_cwd, just need something like pane_current_program and to construct the name using format in window_name_callback. On Mon, Dec 10, 2012 at 03:01:05PM -0300,

Re: [PROPOSED FEATURE & PATCH] Add the ability to automatic renaming to show the cwd.

2012-12-10 Thread Patricio Palladino
Hi! On Mon, Dec 10, 2012 at 5:29 AM, Nicholas Marriott wrote: > Can you send the patch as a unified diff to the mailing list please? Sure, here it is: diff --git a/names.c b/names.c index 72f1ad1..603ffcf 100644 --- a/names.c +++ b/names.c @@ -73,9 +73,18 @@ window_name_callback(unused int fd,

Re: [PROPOSED FEATURE & PATCH] Add the ability to automatic renaming to show the cwd.

2012-12-10 Thread Thomas Adam
Hi, On Mon, Dec 10, 2012 at 08:29:07AM +, Nicholas Marriott wrote: > Can you send the patch as a unified diff to the mailing list please? > > osdep_get_cwd does return a static char[]. > > I'm not sure about adding a new option, it might be better to make > automatic-rename a tristate option

Re: [PROPOSED FEATURE & PATCH] Add the ability to automatic renaming to show the cwd.

2012-12-10 Thread Nicholas Marriott
Can you send the patch as a unified diff to the mailing list please? osdep_get_cwd does return a static char[]. I'm not sure about adding a new option, it might be better to make automatic-rename a tristate option (on/off/cwd), but that breaks toggling. Hmm. On Mon, Dec 10, 2012 at 02:13:43AM -

[PROPOSED FEATURE & PATCH] Add the ability to automatic renaming to show the cwd.

2012-12-09 Thread Patricio Palladino
Hi tmux community! I have been using tmux for the last year, and has became an essential tool for my development job, but I used to use panes almost exclusively until some months ago. I think automatic renaming is a great feature to remember which tab is which, and I couldn't live without it. But