Can you send the patch as a unified diff to the mailing list please? osdep_get_cwd does return a static char[].
I'm not sure about adding a new option, it might be better to make automatic-rename a tristate option (on/off/cwd), but that breaks toggling. Hmm. On Mon, Dec 10, 2012 at 02:13:43AM -0300, Patricio Palladino wrote: > Hi tmux community! > > I have been using tmux for the last year, and has became an essential > tool for my development job, but I used to use panes almost > exclusively until some months ago. I think automatic renaming is a > great feature to remember which tab is which, and I couldn't live > without it. But it gets somewhat useless when you have many windows > with title "zsh", so I spent quite a long time trying to make a zsh > hook to put the cwd instead of that, but didn't get the expected > results (automatic renaming stopped working, or it ignored > automatic-rename setting and change it always). > > So I decided to add this feature to tmux myself, and to my surprise it > was really easy. tmux codebase is one of the cleanest C codes I've > ever seen, indeed. > > I pushed the patch to a github repo in a feature branch that you can > get here: https://github.com/alcuadrado/tmux/tree/automatic-rename-cwd > > I have a doubt about this line: > https://github.com/alcuadrado/tmux/blob/automatic-rename-cwd/names.c#L83 > As far I've seen osdep_get_cwd returns a pointer to a statically > allocated char[], but I haven't found it documented anywhere. Is that > correct? > > Also, I know nothing about troff, so I couldn't add this feature to the doc. > > What do you think about this feature? And about the code? > > Thanks! > > Patricio > > ------------------------------------------------------------------------------ > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > tmux-users mailing list > tmux-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/tmux-users ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
