On Fri, May 11, 2012 at 09:12:09 +0100, Thomas Adam wrote:
> Hi,
>
> On 10 May 2012 07:02, Nicholas Marriott wrote:
> > Whoops, I missed this. I think it should use -t like everything else:
>
> That looks OK, but as I mentioned before, the semantics for -s change
> when used with -r, in that whe
Hi,
On 10 May 2012 07:02, Nicholas Marriott wrote:
> Whoops, I missed this. I think it should use -t like everything else:
That looks OK, but as I mentioned before, the semantics for -s change
when used with -r, in that when using -s, we're not looking up a
src-window, but a src-session. I am n
Whoops, I missed this. I think it should use -t like everything else:
Index: cmd-move-window.c
===
RCS file: /cvs/src/usr.bin/tmux/cmd-move-window.c,v
retrieving revision 1.11
diff -u -p -r1.11 cmd-move-window.c
--- cmd-move-window.c
On Tue, May 08, 2012 at 11:04:36 +0100, Thomas Adam wrote:
> On 8 May 2012 10:04, Thomas Adam wrote:
> > So I am not sure how best do this, other than have -r take a parameter to
> > specify a session, and use cmd_find_session() to look it up.
>
> Something like the following? Completely and utt
On 8 May 2012 10:04, Thomas Adam wrote:
> So I am not sure how best do this, other than have -r take a parameter to
> specify a session, and use cmd_find_session() to look it up.
Something like the following? Completely and utterly untested.
diff --git a/trunk/cmd-move-window.c b/trunk/cmd-move
On Tue, May 08, 2012 at 12:13:13AM +, Ben Boeckel wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> On Tue, Apr 24, 2012 at 22:07:40 GMT, Thomas Adam wrote:
> > diff --git a/trunk/cmd-move-window.c b/trunk/cmd-move-window.c
> > index 5c4dbbe..acb5044 100644
> > --- a/trunk/cmd-mov
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On Tue, Apr 24, 2012 at 22:07:40 GMT, Thomas Adam wrote:
> diff --git a/trunk/cmd-move-window.c b/trunk/cmd-move-window.c
> index 5c4dbbe..acb5044 100644
> --- a/trunk/cmd-move-window.c
> +++ b/trunk/cmd-move-window.c
> @@ -42,11 +42,22 @@ int
> cmd
Hi
RB_FOREACH_SAFE is fairly new, so yes no doubt there are a good few
places it could be used instead of manual loops.
I've applied the diff, thanks!
On Sun, Apr 29, 2012 at 05:35:28PM +0100, Thomas Adam wrote:
> Hi,
>
> On 29 April 2012 09:16, Nicholas Marriott wrote:
> > Hi
> >
> > This lo
Hi,
On 29 April 2012 09:16, Nicholas Marriott wrote:
> Hi
>
> This looks great, except you need to call winlink_remove on the old
> winlink to remove the old win ref count and free the winlink. Also no
Oops. That'll help plug some leaks, yes. Thanks for spotting that.
> point in the function
Hi
This looks great, except you need to call winlink_remove on the old
winlink to remove the old win ref count and free the winlink. Also no
point in the function returning an error that is never used or checking
that s is NULL when it never can be :-).
Going to go with this, minor tweaks only:
On Mon, Apr 23, 2012 at 11:25:28PM +0100, Nicholas Marriott wrote:
> Do we need a command at all or is the option enough?
Well, I can already see people wanting both, and I see both as light-weight,
especially since both code-paths between a flag to move-window and a session
option call the same f
Do we need a command at all or is the option enough?
If a manual trigger is really useful, could this be a flag to
move-window?
On Sun, Apr 22, 2012 at 02:46:52PM +0100, Thomas Adam wrote:
> This adds the definition file for the renumber-windows command, as well as
> supporting its addition in t
This adds the definition file for the renumber-windows command, as well as
supporting its addition in the Makefile.
---
trunk/Makefile.am|1 +
trunk/cmd-renumber-windows.c | 53 ++
trunk/cmd.c |1 +
trunk/tmux.h
13 matches
Mail list logo
