Hi RB_FOREACH_SAFE is fairly new, so yes no doubt there are a good few places it could be used instead of manual loops.
I've applied the diff, thanks! On Sun, Apr 29, 2012 at 05:35:28PM +0100, Thomas Adam wrote: > Hi, > > On 29 April 2012 09:16, Nicholas Marriott <nicholas.marri...@gmail.com> wrote: > > Hi > > > > This looks great, except you need to call winlink_remove on the old > > winlink to remove the old win ref count and free the winlink. Also no > > Oops. That'll help plug some leaks, yes. Thanks for spotting that. > > > point in the function returning an error that is never used or checking > > that s is NULL when it never can be :-). > > Heh, true. I think I might have over-tightened the belt a bit there. > > > Going to go with this, minor tweaks only: > > Looks fine to me, thanks. > > > + ?? ?? ?? /* Free the old winlinks (reducing window references too). */ > > + ?? ?? ?? RB_FOREACH_SAFE(wl, winlinks, &old_wins, wl1) > > + ?? ?? ?? ?? ?? ?? ?? winlink_remove(&old_wins, wl); > > +} > > I wonder if using RB_FOREACH_SAFE() in this way is also applicable to > session_group_synchronize1() as well? Rather than the while > (!RB_EMPTY(&old_windows)) call? I appreciate it's an aside. > > -- Thomas Adam ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
