> - What's the point of having key_binding_map_value and
> key_binding_map_entry? Why not just one key_table struct?
> key_bindings_remove can remove it from the tree and unref it, the
> unref func can free it when it hits 0.
>
> - Also if we just have key_table then key_binding_map could be
Hi
I don't have a lot of time right now, but here are some comments:
- What's the point of having key_binding_map_value and
key_binding_map_entry? Why not just one key_table struct?
key_bindings_remove can remove it from the tree and unref it, the
unref func can free it when it hits 0.
- A
To my great shame that last patch (3 of 3) was very wrong (and
undertested). This should be less wrong and maybe a little less
confused in e.g. unbinding.
Keith
---
cmd-bind-key.c | 44 +++--
cmd-list-keys.c | 80 +++---
cmd-switch-client.c | 16