Re: [PATCH 1/1] Hotfix for OSC 12 infinite echo issue

2013-01-17 Thread Nicholas Marriott
Ok, applied your fix thanks. On Thu, Jan 17, 2013 at 06:02:50PM +0900, Hayaki Saito wrote: > In present, semantics of xterm's OSC 12 sequence is always either one of "set > cursor color" or "get cursor color". > if the substring after ";" in an OSC 12 sequence means "set cursor color", It > can

Re: [PATCH 1/1] Hotfix for OSC 12 infinite echo issue

2013-01-17 Thread Hayaki Saito
In present, semantics of xterm's OSC 12 sequence is always either one of "set cursor color" or "get cursor color". if the substring after ";" in an OSC 12 sequence means "set cursor color", It can never begin with "?", and if it means the other, It always begins with "?". So I think that this con

Re: [PATCH 1/1] Hotfix for OSC 12 infinite echo issue

2013-01-16 Thread Nicholas Marriott
ok this makes more sense now thanks do we really need to drop all sequences starting with "?" or is it enough to match only when it is only "?"? On Thu, Jan 17, 2013 at 02:38:54AM +0900, Hayaki Saito wrote: > > Oh, I apologize for not providing you with enough explanation. > I just noticed that

Re: [PATCH 1/1] Hotfix for OSC 12 infinite echo issue

2013-01-16 Thread Hayaki Saito
Oh, I apologize for not providing you with enough explanation. I just noticed that this is configuration-specific issue. In order to reproduce this problem, we should enable visual bell. > set-option -g visual-bell on If we type this command on shell environment, ECHO-backed OSC sequences such a

Re: [PATCH 1/1] Hotfix for OSC 12 infinite echo issue

2013-01-16 Thread Nicholas Marriott
I don't understand what the problem is or how this fixes it. Where is ST in your change? On Wed, Jan 16, 2013 at 04:54:06PM +0900, Hayaki Saito wrote: > > Is the ? in this diff supposed to be \\234? > > No, It's just a hot fix, for infinite echo problem. > > On 2013/01/15, at 13:26, Nicholas Ma

Re: [PATCH 1/1] Hotfix for OSC 12 infinite echo issue

2013-01-15 Thread Hayaki Saito
> Is the ? in this diff supposed to be \\234? No, It's just a hot fix, for infinite echo problem. On 2013/01/15, at 13:26, Nicholas Marriott wrote: > Hi > > Why only check the first character of the string? > > Is the ? in this diff supposed to be \\234? > > > > > On Tue, Jan 01, 2013 at 1

Re: [PATCH 1/1] Hotfix for OSC 12 infinite echo issue

2013-01-14 Thread Nicholas Marriott
Hi Why only check the first character of the string? Is the ? in this diff supposed to be \\234? On Tue, Jan 01, 2013 at 11:51:24AM +0900, Hayaki Saito wrote: > > This is a hotfix patch for infinite echo loop issue which occurs with > following shell command. > > > $ echo -en '\033]12;?\03

[PATCH 1/1] Hotfix for OSC 12 infinite echo issue

2012-12-31 Thread Hayaki Saito
This is a hotfix patch for infinite echo loop issue which occurs with following shell command. > $ echo -en '\033]12;?\033\\' This problem occurs in some terminals that support OSC 12/get access feature (e.g. xterm). I think OSC 12 sequense should be completely parsed and validated. Some term