I don't understand what the problem is or how this fixes it. Where is ST in your change?
On Wed, Jan 16, 2013 at 04:54:06PM +0900, Hayaki Saito wrote: > > Is the ? in this diff supposed to be \\234? > > No, It's just a hot fix, for infinite echo problem. > > On 2013/01/15, at 13:26, Nicholas Marriott wrote: > > > Hi > > > > Why only check the first character of the string? > > > > Is the ? in this diff supposed to be \\234? > > > > > > > > > > On Tue, Jan 01, 2013 at 11:51:24AM +0900, Hayaki Saito wrote: > >> > >> This is a hotfix patch for infinite echo loop issue which occurs with > >> following shell command. > >> > >>> $ echo -en '\033]12;?\033\\' > >> > >> This problem occurs in some terminals that support OSC 12/get access > >> feature (e.g. xterm). > >> > >> I think OSC 12 sequense should be completely parsed and validated. > >> Some terminals like PuTTY accept 8bit ST (0x9c) control and treat it as > >> OSC terminate character. > >> So if cursor color string sequence includes 9c, it might cause unexpected > >> behavior. > >> > >> --- > >> input.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/input.c b/input.c > >> index 23b9574..9855324 100644 > >> --- a/input.c > >> +++ b/input.c > >> @@ -1560,7 +1560,8 @@ input_exit_osc(struct input_ctx *ictx) > >> server_status_window(ictx->wp->window); > >> break; > >> case 12: > >> - screen_set_cursor_colour(ictx->ctx.s, p); > >> + if (*p != '?') > >> + screen_set_cursor_colour(ictx->ctx.s, p); > >> break; > >> case 112: > >> if (*p == '\0') /* No arguments allowed. */ > >> -- > >> 1.7.11.5 > >> > >> > >> > >> ------------------------------------------------------------------------------ > >> Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS > >> and more. Get SQL Server skills now (including 2012) with LearnDevNow - > >> 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. > >> SALE $99.99 this month only - learn more at: > >> http://p.sf.net/sfu/learnmore_122512 > >> _______________________________________________ > >> tmux-users mailing list > >> tmux-users@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/tmux-users > ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
