Re: GitHub pull requests

2013-02-19 Thread Richard Woodbury
On Tue, Feb 19, 2013 at 6:22 PM, Nicholas Marriott < nicholas.marri...@gmail.com> wrote: > Also I > think tmux docs are not the place to tell people about using source > control tools, it's a distraction for the people who just want to use > tmux. > I agree with that. The line is pretty blurry be

Re: GitHub pull requests

2013-02-19 Thread Richard Woodbury
On Tue, Feb 19, 2013 at 1:23 PM, Nicholas Marriott < nicholas.marri...@gmail.com> wrote: > The NOTES file already says that code contributions should come to > mailing list by email. Yes, but it doesn't specify a preference for attached vs. inline. If there is no preference, may it is fine the w

Re: GitHub pull requests

2013-02-19 Thread Richard Woodbury
On Tue, Feb 19, 2013 at 2:13 AM, Thomas Adam wrote: > I did have a few notes on this once regarding the correct "policy" for > contributors; perhaps I will add a sentence about this to the NOTES > file. > I might also suggest creating a "Development" link on http://tmux.sourceforge.net, perhaps

Re: return of the son of reflow from 50,000 fathoms

2013-02-10 Thread Richard Woodbury
I worried that my code did a lot of reallocations, but it ran fine even on my older machines, so I let it be. This was also less of a concern when it was an optional feature, but now it matters greatly. Nicholas, your latest patch passes my smoke test. I will continue to use it and let you know if

Re: Patch to implement reflowing

2013-02-01 Thread Richard Woodbury
On Fri, Feb 1, 2013 at 6:30 AM, Nicholas Marriott wrote: > > Hi > > Take a look at this please. > > We reflow in window_pane_resize when the alternate screen is off > (saved_grid == NULL) and always when switching back from alternate > screen. No need to reflow from any of the modes. One quick fi

Re: Patch to implement reflowing

2013-01-31 Thread Richard Woodbury
On Thu, Jan 31, 2013 at 6:55 AM, Nicholas Marriott < nicholas.marri...@gmail.com> wrote: > Ok let's lose the option and make it the default and that means we don't > have to have resizep -F and that means no man page changes too. > > I think I would try to put the call to grid_reflow into screen_r

Re: Patch to implement reflowing

2013-01-30 Thread Richard Woodbury
On Wed, Jan 30, 2013 at 11:14 AM, Thomas Adam wrote: > I've pushed changes to tmux.git which means you'll need to rework your > patch slightly since GRID_FLAG_UTF8 is no longer used by anything. > > You're probably OK to just call grid_cell_{get,set}() without checking > first; but I've not looke

Re: Patch to implement reflowing

2013-01-30 Thread Richard Woodbury
On Wed, Jan 30, 2013 at 3:15 AM, Nicholas Marriott < nicholas.marri...@gmail.com> wrote: > Looks like your mailer mangled the whitespace in the first diff so can > you resend please as an attachment including this change? > Curses! Sorry about that... I'm more used to git pull requests. Please fi

Re: Patch to implement reflowing

2013-01-29 Thread Richard Woodbury
On Tue, Jan 29, 2013 at 6:10 PM, Thomas Adam wrote: > > Your patch segfaults tmux when I do this: > > tmux -Stemp -Ltemp -f/dev/null > ^b:setw reflow > ^b" > > (That is, start tmux on a new server with your patch compiled; > immediately set the 'reflow' option on the window; then call 'splitw' > o

Re: Patch to implement reflowing

2013-01-29 Thread Richard Woodbury
On Tue, Jan 29, 2013 at 7:15 AM, Nicholas Marriott wrote: > > Can you send a unified diff to the mailing list please? Sure thing. See below. >From df6f6960cb469bf5a5f6332697186afd1d568ab5 Mon Sep 17 00:00:00 2001 From: Richard Woodbury Date: Sun, 27 Jan 2013 16:44:49 -0500 Subjec

Patch to implement reflowing

2013-01-29 Thread Richard Woodbury
97186afd1d568ab5: Implement reflow-pane and reflow window option. (2013-01-27 16:44:49 -0500) -------- Richard Woodbury (1): Implement reflow-pane and reflow window option. Makefile.am |1