Re: display-message in bindings no longer working as I expect

2013-03-25 Thread Aaron Jensen
I haven't tested this yet, but given that Thomas is looking to release 1.8, should a fix for this go in it if it hasn't already? On Sunday, March 24, 2013 at 4:06 AM, Nicholas Marriott wrote: > I think perhaps #{} should me made to translate to # although in this > case it doesn't matter becau

Re: display-message in bindings no longer working as I expect

2013-03-23 Thread Aaron Jensen
through several people, finished off by Chris Johnsen. On Saturday, March 23, 2013 at 11:05 PM, Aaron Jensen wrote: > If I do this: > > bind ^H run "tmux display-message '#{pane_title}'" > > Then it will show blank instead of the current pane's title. I

display-message in bindings no longer working as I expect

2013-03-23 Thread Aaron Jensen
If I do this: bind ^H run "tmux display-message '#{pane_title}'" Then it will show blank instead of the current pane's title. It's as if it loses the context of the current pane. And yes, I do need the `run`, the real binding does more than this. This seems to be a recent regression. Thank

Crash in current master

2013-02-25 Thread Aaron Jensen
If I have this binding: bind ^H run "tmux display-message -p '#{pane_current_command}'" If I hit it, it crashes. The real binding does more than that, I just stripped it down to the repro (In other words, I do need the `run`). The problem commit: 2ccb67c Aaron -

Re: [PATCH 0/4] Add handling of client focus tracking

2013-02-23 Thread Aaron Jensen
A single patch is attached as well for easy application. On Friday, February 22, 2013 at 11:54 PM, Aaron Jensen wrote: > Add handling of client focus tracking. > > Also trying a different send-email approach, let me know how it works. > > Aaron Jensen (4): > Turn bracketed

[PATCH 3/4] Set focused by default

2013-02-22 Thread Aaron Jensen
--- server-client.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/server-client.c b/server-client.c index 3c14ff8..c8a98f2 100644 --- a/server-client.c +++ b/server-client.c @@ -95,6 +95,8 @@ server_client_create(int fd) c->tty.mouse.event = MOUSE_EVENT_UP; c->tty.mouse.fla

[PATCH 0/4] Add handling of client focus tracking

2013-02-22 Thread Aaron Jensen
Add handling of client focus tracking. Also trying a different send-email approach, let me know how it works. Aaron Jensen (4): Turn bracketed paste mode on and off externally Track client focus Set focused by default Check for client focus in server_client_check_focus server-client.c

[PATCH 2/4] Track client focus

2013-02-22 Thread Aaron Jensen
--- tmux.h | 4 tty-keys.c | 14 ++ 2 files changed, 18 insertions(+) diff --git a/tmux.h b/tmux.h index c905b66..966588c 100644 --- a/tmux.h +++ b/tmux.h @@ -237,6 +237,9 @@ enum key_code { KEYC_KP_ENTER, KEYC_KP_ZERO, KEYC_KP_PERIOD, + + KEYC_

[PATCH 1/4] Turn bracketed paste mode on and off externally

2013-02-22 Thread Aaron Jensen
--- tty.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tty.c b/tty.c index b5dcf6d..ab75d94 100644 --- a/tty.c +++ b/tty.c @@ -221,7 +221,7 @@ tty_start_tty(struct tty *tty) tty_puts(tty, "\033[?1000l\033[?1006l\033[?1005l"); if (tty_term_has(tt

[PATCH 4/4] Check for client focus in server_client_check_focus

2013-02-22 Thread Aaron Jensen
--- server-client.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/server-client.c b/server-client.c index c8a98f2..8d7fc2b 100644 --- a/server-client.c +++ b/server-client.c @@ -547,7 +547,8 @@ server_client_check_resize(struct window_pane *wp) void serv

Re: [PATCH] Implemented -o option for 'set-option'

2013-02-22 Thread Aaron Jensen
I just use git format-patch --stdout master > whatever.patch and attach the patch file On Fri, Feb 22, 2013 at 10:50 AM, Thiago Padilha wrote: > Anyone knows how I can use gmail to send this? > > On Fri, Feb 22, 2013 at 3:35 PM, Thiago Padilha > wrote: > > This option alters 'set-option' behavi

Re: Your recipe on achieving this simple workflow

2013-02-22 Thread Aaron Jensen
t; > > > On Fri, Feb 22, 2013 at 09:45:48AM -0800, Aaron Jensen wrote: > >I'm not getting the bleed through, but the resize causes some problems > >with rendering the prompt, it plops part of my fairly long prompt on > top > >of where i should be t

Re: Your recipe on achieving this simple workflow

2013-02-22 Thread Aaron Jensen
t; + return (-1); > + wp = w->active; > + > + TAILQ_FOREACH(wp1, &w->saved_panes, entry) { > + wp1->flags &= ~PANE_HIDDEN; > + RB_INSERT(window_pane_tree, &all_window_panes, wp1); > + } > + > +

Re: Your recipe on achieving this simple workflow

2013-02-22 Thread Aaron Jensen
I may have misunderstood what this is intending to do, but I'm seeing pane updates even though the panes are "hidden". In other words, my zoom'd pane is getting overwritten when the other panes change. Is that intended? On Fri, Feb 22, 2013 at 9:10 AM, Aaron Jensen wrote: &

Re: Your recipe on achieving this simple workflow

2013-02-22 Thread Aaron Jensen
I'm trying it today too. So far so good. Also, I was able to apply your patch :) On Fri, Feb 22, 2013 at 8:21 AM, Nicholas Marriott < nicholas.marri...@gmail.com> wrote: > not convinced about the way it works, need to think about it. also it > needs testing > > > On Fri, Feb 22, 2013 at 01:10:09

Re: Is there a way to get the name of the active command in my pane?

2013-02-22 Thread Aaron Jensen
; > size = 0; > for (i = 0; i < gd->hsize; i++) { > @@ -410,6 +411,8 @@ format_window_pane(struct format_tree *ft, struct > window_pane *wp) > format_add(ft, "pane_start_path", "%s", wp->cwd); > if ((cwd = osdep_get_cwd(wp->fd)) != NULL) > forma

Is there a way to get the name of the active command in my pane?

2013-02-22 Thread Aaron Jensen
The active command is pulled out to be put in the window name, i'm wondering if there is any way to access it from tmux otherwise? Specifically, I'd like to have a tmux binding that does different things depending on what the active command is. Thanks, Aaron

Re: Your recipe on achieving this simple workflow

2013-02-22 Thread Aaron Jensen
On Thursday, February 21, 2013 at 11:59 PM, Thomas Adam wrote: > On 22 February 2013 07:55, Aaron Jensen (mailto:aaronjen...@gmail.com)> wrote: > > You can try out my solution (it's a script, but there may be some ideas that > > are usable): > > > > https://g

Re: Your recipe on achieving this simple workflow

2013-02-21 Thread Aaron Jensen
You can try out my solution (it's a script, but there may be some ideas that are usable): https://github.com/aaronjensen/dotfiles/blob/master/bin/tmux-zoom https://github.com/aaronjensen/dotfiles/blob/master/tmux.conf#L86-L88 Basically it creates a new window with a temporary pane that it swa

Re: Your recipe on achieving this simple workflow

2013-02-21 Thread Aaron Jensen
> > I plan on submitting my hook patches instead which obsolete this. > > > > > > > > Oh, do you have them up somewhere? hooks would be awesome. > Found it: https://github.com/ThomasAdam/tmux/commits/ta/hook-support -

Re: Your recipe on achieving this simple workflow

2013-02-21 Thread Aaron Jensen
On Thursday, February 21, 2013 at 11:15 PM, Thomas Adam wrote: > On 22 February 2013 06:48, Thiago Padilha (mailto:tpadilh...@gmail.com)> wrote: > > Since the patch came from Thomas topic branch, I guess he plans to > > merge it eventually > > > > > I plan on submitting my hook patches instead

Re: Your recipe on achieving this simple workflow

2013-02-21 Thread Aaron Jensen
om/tarruda/dot-files/blob/master/.tmux.conf#L47-L49) > > > If you dont use zsh or dont care about 'polluting' your session > environment(which gets copied to each new pane/window), you can > probably replace the shared memory stuff with tmux setenv/showenv. > > On Thu,

Re: Your recipe on achieving this simple workflow

2013-02-21 Thread Aaron Jensen
I do something very similar, but take a slightly different approach. I think of it as "zooming" in on a pane. So if I have a window set up, I'll zoom a pane to break it out on its own, then return it to where it was. I got this from the tmux book but adapted it to be more resilient to window/pan

Re: [PATCH] Added support for Focus Event notification

2013-02-21 Thread Aaron Jensen
try fancy stuff that works > in xterm and may work elsewhere. > We should probably use something else because not may terminfo entries > actually have it (including the xterm terminfo itself). > On Thu, Feb 21, 2013 at 10:12:40AM -0800, Aaron Jensen wrote: >>Inlline... >

Re: [PATCH] Added support for Focus Event notification

2013-02-21 Thread Aaron Jensen
Inlline... On Thu, Feb 21, 2013 at 9:28 AM, Nicholas Marriott < nicholas.marri...@gmail.com> wrote: > Ok the session_set_current_winlink idea is good so I have applied that > bit but renamed to session_set_current. > > Here is an updated diff with a few changes: > > - Spacing fixes. Looks like yo

Re: [PATCH] Added support for Focus Event notification

2013-02-20 Thread Aaron Jensen
On Wednesday, February 20, 2013 at 11:49 PM, Nicholas Marriott wrote: > Are you telling me that in iterm these are on by default? Even if tmux > or the user doesn't ask for them? > > No, sorry I wasn't clear. They are not on by default. You can turn them on the same way you'd turn them on in tm

Re: [PATCH] Added support for Focus Event notification

2013-02-20 Thread Aaron Jensen
Aleks pinged me and wanted to weigh in directly (CCing to get him on the thread) On Wednesday, February 20, 2013 at 4:42 PM, Aaron Jensen wrote: > > > On Wednesday, February 20, 2013 at 3:56 PM, Aaron Jensen wrote: > > > On Wed, Feb 20, 2013 at 3:36 PM,

Re: [PATCH] Added support for Focus Event notification

2013-02-20 Thread Aaron Jensen
On Wednesday, February 20, 2013 at 3:56 PM, Aaron Jensen wrote: > On Wed, Feb 20, 2013 at 3:36 PM, Nicholas Marriott > mailto:nicholas.marri...@gmail.com)> wrote: > > I will look at the diff tomorrow, but I don't see why we need an option. > > > > If you

Re: [PATCH] Added support for Focus Event notification

2013-02-20 Thread Aaron Jensen
On Wed, Feb 20, 2013 at 3:36 PM, Nicholas Marriott < nicholas.marri...@gmail.com> wrote: > I will look at the diff tomorrow, but I don't see why we need an option. > > If you enable focusing in your terminal, you'll get it in tmux (if the > application has turned it on). That's what you want, righ

Re: [PATCH] Added support for Focus Event notification

2013-02-20 Thread Aaron Jensen
On Wednesday, February 20, 2013 at 8:21 AM, Aaron Jensen wrote: > Updated patch. Something that is confusing to me is that when I turn the > filter off, something is still preventing ^[[O from getting printed to the > screen. I'm guessing something in tux's input key handlin

Re: [PATCH] Added support for Focus Event notification

2013-02-20 Thread Aaron Jensen
ltering is really necessary, but that is beyond me. >From 4f0d0ba710c3818c6042296d019ccb42c71efffc Mon Sep 17 00:00:00 2001 From: Aaron Jensen Date: Wed, 20 Feb 2013 08:18:49 -0800 Subject: [PATCH] Squashed commit of the following: commit 8847957774a8221fdb94791e30107d35dffea706 Author: Aaron

Re: [PATCH] Added support for Focus Event notification

2013-02-20 Thread Aaron Jensen
On Tuesday, February 19, 2013 at 11:53 PM, Aaron Jensen wrote: > 3) I removed the option completely, it's not needed I don't think. > > 4) akracun had added some logic to let panes track their focus status so they > couldn't ever get double notified. It's n

Re: [PATCH] Added support for Focus Event notification

2013-02-19 Thread Aaron Jensen
double notify is better than not notifying, but what do you guys think? 5) I haven't updated CHANGES or man pages, I'm not sure if I should or if you guys will. Thanks, Aaron >From 861356b8d074a7b4f3cc55f130270439cad3d756 Mon Sep 17 00:00:00 2001 From: Aaron Jensen Date: Tue

Re: [PATCH] Added support for Focus Event notification

2013-02-19 Thread Aaron Jensen
On Tuesday, February 19, 2013 at 9:52 PM, Aaron Jensen wrote: > On Tuesday, February 19, 2013 at 8:17 AM, Nicholas Marriott wrote: > > > Good question. My guess is that since akracun originally wrote it without > > > the window switching handling he originally envi

Re: [PATCH] Added support for Focus Event notification

2013-02-19 Thread Aaron Jensen
On Tuesday, February 19, 2013 at 8:17 AM, Nicholas Marriott wrote: > > Good question. My guess is that since akracun originally wrote it without > > the window switching handling he originally envisioned it as a window > > feature, but I won't put works in his mouth. Now that it handles window > >

Re: [PATCH] Added support for Focus Event notification

2013-02-19 Thread Aaron Jensen
Awesome, thanks for the comments. I pinged akracun as well. One of us will put together a new patch. Questions inline. On Tuesday, February 19, 2013 at 1:03 AM, Nicholas Marriott wrote: > > + window_pane_focus_notify(w->active, 1); > > > > > We can't apply it with all these little // commen

Re: GitHub pull requests

2013-02-19 Thread Aaron Jensen
On Tuesday, February 19, 2013 at 12:46 AM, Nicholas Marriott wrote: > Hi > > tmux doesn't use GitHub, it is on SourceForge. > > I want one central point for reviewing and discussing code changes and > the best is the mailing list. Particularly since we may need to apply > stuff to OpenBSD CVS bef

GitHub pull requests

2013-02-18 Thread Aaron Jensen
Hello, I know you all have decided to explicitly not accept pull requests via github, but I'm curious why? I just submitted a patch via send-email and it was rather painful. git send-email was super slow (took 30 seconds before prompting me for my password). Also it wanted to send each commit

Re: [PATCH] Added support for Focus Event notification

2013-02-18 Thread Aaron Jensen
Most of the work in here was from akracun: https://github.com/akracun/tmux I just added support for window switching and did some refactoring. I'm pretty new to the code base, so let me know if you'd like me to fix anything up. This code is in response to http://sourceforge.net/p/tmux/tickets/

[PATCH] Added support for Focus Event notification

2013-02-18 Thread Aaron Jensen
From: a added focus filtering Will send \e[I or \e[O when panes are focused/unfocused. Must be enabled with the focus-filter window option. --- cmd-break-pane.c | 3 +++ examples/tmux.vim | 2 +- input-keys.c | 10 ++ input.c | 8 options-table.c | 5 +