Hi,
On 22 March 2012 11:14, Nicholas Marriott wrote:
> Hi
>
> I tweaked this a bit so the output format is the same for one or many
> variables and applied it, thanks!
Sorry to bring this up now after this patch has gone out, but I'm
curious to know if the following patch isn't more preferred wh
Hi
RB_FOREACH_SAFE is fairly new, so yes no doubt there are a good few
places it could be used instead of manual loops.
I've applied the diff, thanks!
On Sun, Apr 29, 2012 at 05:35:28PM +0100, Thomas Adam wrote:
> Hi,
>
> On 29 April 2012 09:16, Nicholas Marriott wrote:
> > Hi
> >
> > This lo
Hi,
On 29 April 2012 09:16, Nicholas Marriott wrote:
> Hi
>
> This looks great, except you need to call winlink_remove on the old
> winlink to remove the old win ref count and free the winlink. Also no
Oops. That'll help plug some leaks, yes. Thanks for spotting that.
> point in the function
Hi
This looks great, except you need to call winlink_remove on the old
winlink to remove the old win ref count and free the winlink. Also no
point in the function returning an error that is never used or checking
that s is NULL when it never can be :-).
Going to go with this, minor tweaks only:
