Re: [TLS] Finished stuffing/PSK Binders

2016-10-12 Thread Benjamin Kaduk
On 10/12/2016 09:27 AM, Ilari Liusvaara wrote: > On Wed, Oct 12, 2016 at 09:43:05PM +1100, Martin Thomson wrote: >> On 12 October 2016 at 19:50, Ilari Liusvaara >> wrote: >> >> Maybe we should require text for every extension that can appear in >> the HRR: what to do if the extension is in the HR

Re: [TLS] Finished stuffing/PSK Binders

2016-10-12 Thread Ilari Liusvaara
On Wed, Oct 12, 2016 at 10:13:57AM -0500, Benjamin Kaduk wrote: > On 10/12/2016 09:27 AM, Ilari Liusvaara wrote: > > On Wed, Oct 12, 2016 at 09:43:05PM +1100, Martin Thomson wrote: > > > That would waste a bit of space with extensions signaling support > > for some rewrites if the server doesn't u

Re: [TLS] Finished stuffing/PSK Binders

2016-10-12 Thread Ilari Liusvaara
On Wed, Oct 12, 2016 at 09:43:05PM +1100, Martin Thomson wrote: > On 12 October 2016 at 19:50, Ilari Liusvaara wrote: > > I also noticed another edge case: What is to prevent server from > > omitting key share group (emitting a cookie, so the restart is > > not spurious), presumably causing the cl

Re: [TLS] Finished stuffing/PSK Binders

2016-10-12 Thread Martin Thomson
On 12 October 2016 at 19:50, Ilari Liusvaara wrote: > I also noticed another edge case: What is to prevent server from > omitting key share group (emitting a cookie, so the restart is > not spurious), presumably causing the client to blank its key_share > and then proceed to accept DH versus clien

Re: [TLS] Finished stuffing/PSK Binders

2016-10-12 Thread Ilari Liusvaara
On Tue, Oct 11, 2016 at 07:48:05PM -0700, Eric Rescorla wrote: > On Tue, Oct 11, 2016 at 5:16 PM, Martin Thomson > wrote: > > > On 12 October 2016 at 00:51, Eric Rescorla wrote: > > > See: > > > https://github.com/tlswg/tls13-spec/pull/678 > > > > I'm convinced that this is the right change. Re

Re: [TLS] Finished stuffing/PSK Binders

2016-10-11 Thread Eric Rescorla
Thanks, I'll look at this. I'll be merging this change (modulo your comments) Friday unless there is significant objection. -Ekr On Tue, Oct 11, 2016 at 5:16 PM, Martin Thomson wrote: > On 12 October 2016 at 00:51, Eric Rescorla wrote: > > See: > > https://github.com/tlswg/tls13-spec/pull/678

Re: [TLS] Finished stuffing/PSK Binders

2016-10-11 Thread Martin Thomson
On 12 October 2016 at 00:51, Eric Rescorla wrote: > See: > https://github.com/tlswg/tls13-spec/pull/678 I'm convinced that this is the right change. Reconstruction was always going to be brittle. I will note that I don't think that the change gets the error codes right though. I explained why

Re: [TLS] Finished stuffing/PSK Binders

2016-10-11 Thread Eric Rescorla
On Sun, Oct 9, 2016 at 7:10 AM, Eric Rescorla wrote: > > > On Sun, Oct 9, 2016 at 6:58 AM, Ilari Liusvaara > wrote: > >> On Fri, Oct 07, 2016 at 08:01:43AM -0700, Eric Rescorla wrote: >> > After the discussion on PR #615, I took another pass at this with some >> > help from the research communit

Re: [TLS] Finished stuffing/PSK Binders

2016-10-09 Thread Hugo Krawczyk
On Fri, Oct 7, 2016 at 1:08 PM, Eric Rescorla wrote: > > > On Fri, Oct 7, 2016 at 10:03 AM, Ilari Liusvaara > wrote: > >> On Fri, Oct 07, 2016 at 09:35:40AM -0700, Eric Rescorla wrote: >> > On Fri, Oct 7, 2016 at 8:26 AM, Ilari Liusvaara < >> ilariliusva...@welho.com> >> > wrote: >> > >> > > On

Re: [TLS] Finished stuffing/PSK Binders

2016-10-09 Thread Eric Rescorla
On Sun, Oct 9, 2016 at 8:44 AM, Ilari Liusvaara wrote: > On Sun, Oct 09, 2016 at 07:10:59AM -0700, Eric Rescorla wrote: > > On Sun, Oct 9, 2016 at 6:58 AM, Ilari Liusvaara < > ilariliusva...@welho.com> > > wrote: > > > > > On Fri, Oct 07, 2016 at 08:01:43AM -0700, Eric Rescorla wrote: > > > > Aft

Re: [TLS] Finished stuffing/PSK Binders

2016-10-09 Thread Ilari Liusvaara
On Sun, Oct 09, 2016 at 07:10:59AM -0700, Eric Rescorla wrote: > On Sun, Oct 9, 2016 at 6:58 AM, Ilari Liusvaara > wrote: > > > On Fri, Oct 07, 2016 at 08:01:43AM -0700, Eric Rescorla wrote: > > > After the discussion on PR #615, I took another pass at this with some > > > help from the research

Re: [TLS] Finished stuffing/PSK Binders

2016-10-09 Thread Eric Rescorla
On Sun, Oct 9, 2016 at 6:58 AM, Ilari Liusvaara wrote: > On Fri, Oct 07, 2016 at 08:01:43AM -0700, Eric Rescorla wrote: > > After the discussion on PR #615, I took another pass at this with some > > help from the research community. Please see: > > > >https://github.com/tlswg/tls13-spec/pull/

Re: [TLS] Finished stuffing/PSK Binders

2016-10-09 Thread Ilari Liusvaara
On Fri, Oct 07, 2016 at 08:01:43AM -0700, Eric Rescorla wrote: > After the discussion on PR #615, I took another pass at this with some > help from the research community. Please see: > >https://github.com/tlswg/tls13-spec/pull/672 > Also, an observation: This seems to interact in somewhat a

Re: [TLS] Finished stuffing/PSK Binders

2016-10-08 Thread Ilari Liusvaara
On Fri, Oct 07, 2016 at 01:41:48PM -0700, Eric Rescorla wrote: > On Fri, Oct 7, 2016 at 1:39 PM, Benjamin Kaduk wrote: > > > On 10/07/2016 12:08 PM, Eric Rescorla wrote: > > > > > > > > On Fri, Oct 7, 2016 at 10:03 AM, Ilari Liusvaara > > wrote: > > > >> On Fri, Oct 07, 2016 at 09:35:40AM -0700,

Re: [TLS] Finished stuffing/PSK Binders

2016-10-07 Thread Eric Rescorla
On Fri, Oct 7, 2016 at 1:39 PM, Benjamin Kaduk wrote: > On 10/07/2016 12:08 PM, Eric Rescorla wrote: > > > > On Fri, Oct 7, 2016 at 10:03 AM, Ilari Liusvaara > wrote: > >> On Fri, Oct 07, 2016 at 09:35:40AM -0700, Eric Rescorla wrote: >> > On Fri, Oct 7, 2016 at 8:26 AM, Ilari Liusvaara < >> ila

Re: [TLS] Finished stuffing/PSK Binders

2016-10-07 Thread Benjamin Kaduk
On 10/07/2016 12:08 PM, Eric Rescorla wrote: > > > On Fri, Oct 7, 2016 at 10:03 AM, Ilari Liusvaara > mailto:ilariliusva...@welho.com>> wrote: > > On Fri, Oct 07, 2016 at 09:35:40AM -0700, Eric Rescorla wrote: > > On Fri, Oct 7, 2016 at 8:26 AM, Ilari Liusvaara > mailto:ilariliusva...@w

Re: [TLS] Finished stuffing/PSK Binders

2016-10-07 Thread Eric Rescorla
On Fri, Oct 7, 2016 at 10:03 AM, Ilari Liusvaara wrote: > On Fri, Oct 07, 2016 at 09:35:40AM -0700, Eric Rescorla wrote: > > On Fri, Oct 7, 2016 at 8:26 AM, Ilari Liusvaara < > ilariliusva...@welho.com> > > wrote: > > > > > On Fri, Oct 07, 2016 at 08:01:43AM -0700, Eric Rescorla wrote: > > > > 4.

Re: [TLS] Finished stuffing/PSK Binders

2016-10-07 Thread Ilari Liusvaara
On Fri, Oct 07, 2016 at 09:35:40AM -0700, Eric Rescorla wrote: > On Fri, Oct 7, 2016 at 8:26 AM, Ilari Liusvaara > wrote: > > > On Fri, Oct 07, 2016 at 08:01:43AM -0700, Eric Rescorla wrote: > > > 4. I've taken a suggestion from David Benjamin to move the negotiation > > > of the PSK key exchange

Re: [TLS] Finished stuffing/PSK Binders

2016-10-07 Thread Eric Rescorla
On Fri, Oct 7, 2016 at 8:26 AM, Ilari Liusvaara wrote: > On Fri, Oct 07, 2016 at 08:01:43AM -0700, Eric Rescorla wrote: > > After the discussion on PR #615, I took another pass at this with some > > help from the research community. Please see: > > > >https://github.com/tlswg/tls13-spec/pull/

Re: [TLS] Finished stuffing/PSK Binders

2016-10-07 Thread Ilari Liusvaara
On Fri, Oct 07, 2016 at 08:01:43AM -0700, Eric Rescorla wrote: > After the discussion on PR #615, I took another pass at this with some > help from the research community. Please see: > >https://github.com/tlswg/tls13-spec/pull/672 > > > Key changes in this PR: > > 1. I have merged the HMAC

[TLS] Finished stuffing/PSK Binders

2016-10-07 Thread Eric Rescorla
After the discussion on PR #615, I took another pass at this with some help from the research community. Please see: https://github.com/tlswg/tls13-spec/pull/672 Key changes in this PR: 1. I have merged the HMAC into the PreSharedKey message, where it is now called "PSK Binder" to make very