Re: [PATCH] grep: fix ASan heap-buffer-overflow.

In article , enh wrote: >-=-=-=-=-=- > >here's a patch that doesn't actually break anything. the previous >version was wrong in the non-copy case, so this version always copies. >(the alternative would be to remember the overwritten byte and restore >it on the next call, but this brings the code

Re: [PATCH] grep: fix ASan heap-buffer-overflow.

here's a patch that doesn't actually break anything. the previous version was wrong in the non-copy case, so this version always copies. (the alternative would be to remember the overwritten byte and restore it on the next call, but this brings the code closer to getdelim(3).) Index: file.c ==

Re: [PATCH] grep: fix ASan heap-buffer-overflow.

On 30.03.2019 06:12, enh wrote: > Like the regular fgetln(), grep_fgetln() doesn't NUL-terminate the > string, which regexec() doesn't like. ASan just gained the ability to > intercept regexec(), which is why we didn't find this previously. > > Bug: http://b/129089665 > Test: adb shell grep -R /sy