Re: [sympy] Help needed: guidance on group theory

This is very helpful guidance, thank you! On Sunday, 30 March 2025 at 23:04:33 UTC+3 Oscar wrote: > I'm not going to read a textbook to review the pull request. Please > explain clearly on the pull request what the code does, where the > algorithm comes from, why it is correct and whether it is r

Re: [sympy] Help needed: guidance on group theory

I'm not going to read a textbook to review the pull request. Please explain clearly on the pull request what the code does, where the algorithm comes from, why it is correct and whether it is reasonable from a performance perspective. Don't assume that anyone reviewing the pull request understands

Re: [sympy] Help needed: guidance on group theory

The algorithm in itself, as seen in the issue, is further detailed in the handbook of computational group theory , from which

Re: [sympy] Help needed: guidance on group theory

The problem with that PR is that it is for a part of the codebase that is not known well by any of the regular sympy contributors. The code as implemented seems to come from the linked issue but there that code was shown by someone who was asking about it rather than making a clear claim that the c

[sympy] Help needed: guidance on group theory

Hello everyone, I’ve submitted a PR (#27730 ) adding functionality to sympy.combinatorics, specfically for permutation groups, but it has gone unnoticed. I couldn’t find a reviewer familiar with the module. If anyone can review it or point me to th