This is very helpful guidance, thank you! On Sunday, 30 March 2025 at 23:04:33 UTC+3 Oscar wrote:
> I'm not going to read a textbook to review the pull request. Please > explain clearly on the pull request what the code does, where the > algorithm comes from, why it is correct and whether it is reasonable > from a performance perspective. > > Don't assume that anyone reviewing the pull request understands even > what any of the relevant sympy functions does (I don't). I'm happy to > review it but you will need to convince me that it is correct without > me needing to spend any significant time going over that part of the > codebase. > > On Sun, 30 Mar 2025 at 19:12, Voaides Negustor Robert > <[email protected]> wrote: > > > > The algorithm in itself, as seen in the issue, is further detailed in > the handbook of computational group theory, from which I have done more > serious research. > > So I think it should be correct. > > > > However, review is greatly appreciated. > > On Saturday, 29 March 2025 at 15:04:16 UTC+2 Oscar wrote: > >> > >> The problem with that PR is that it is for a part of the codebase that > >> is not known well by any of the regular sympy contributors. The code > >> as implemented seems to come from the linked issue but there that code > >> was shown by someone who was asking about it rather than making a > >> clear claim that the code is correct. > >> > >> If anyone else on the mailing list here has experience with sympy's > >> group theory functionality then it would be good if they can verify > >> whether or not the code is correct. > >> > >> On Sun, 16 Mar 2025 at 16:41, Voaides Negustor Robert > >> <[email protected]> wrote: > >> > > >> > Hello everyone, > >> > > >> > I’ve submitted a PR (#27730) adding functionality to > sympy.combinatorics, specfically for permutation groups, but it has gone > unnoticed. I couldn’t find a reviewer familiar with the module. > >> > > >> > If anyone can review it or point me to the right person, I’d really > appreciate it. > >> > > >> > Best, > >> > > >> > Robert > >> > > >> > -- > >> > You received this message because you are subscribed to the Google > Groups "sympy" group. > >> > To unsubscribe from this group and stop receiving emails from it, > send an email to [email protected]. > >> > To view this discussion visit > https://groups.google.com/d/msgid/sympy/0769de67-526a-4ba4-85ec-b2e461fefd40n%40googlegroups.com > . > > > > -- > > You received this message because you are subscribed to the Google > Groups "sympy" group. > > To unsubscribe from this group and stop receiving emails from it, send > an email to [email protected]. > > To view this discussion visit > https://groups.google.com/d/msgid/sympy/fa4bb130-ec4f-4797-ada4-43abe1a7df84n%40googlegroups.com > . > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/sympy/a3f40b31-cf5f-4d55-826d-1a6dad06de4fn%40googlegroups.com.
