Re: [swift-dev] Todo cleanups & such

2017-11-01 Thread John McCall via swift-dev
> On Nov 1, 2017, at 8:05 PM, David Sweeris via swift-dev > wrote: > > In "SILFunction.h", line 171, it says, > /// The function's set of semantics attributes. > /// > /// TODO: Why is this using a std::string? Why don't we use uniqued > /// StringRefs? > llvm::SmallVector SemanticsAt

[swift-dev] Todo cleanups & such

2017-11-01 Thread David Sweeris via swift-dev
In "SILFunction.h", line 171, it says, /// The function's set of semantics attributes. /// /// TODO: Why is this using a std::string? Why don't we use uniqued /// StringRefs? llvm::SmallVector SemanticsAttrSet; As an outside contributor, seeing as how I have no idea why a std::string was