In "SILFunction.h", line 171, it says,
  /// The function's set of semantics attributes.
  ///
  /// TODO: Why is this using a std::string? Why don't we use uniqued
  /// StringRefs?
  llvm::SmallVector<std::string, 1> SemanticsAttrSet;

As an outside contributor, seeing as how I have no idea why a std::string was 
used instead of a uniqued StringRef (or TBH, even what it means to "unique" a 
StringRef in this context), is this the sort of thing I should not worry about 
"fixing"?

- Dave Sweeris
_______________________________________________
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Reply via email to