Re: [swift-corelibs-dev] Measurement Formatters & ICU

2016-08-23 Thread Philippe Hausler via swift-corelibs-dev
Just because it was super-easy for me to fix: https://github.com/apple/swift-corelibs-foundation/pull/587 That should allow C++ to be built if desired into CoreFoundation. However round tripping that into the Darwin version of CoreFoundation may be a bit cagey. > On Aug 23, 2016, at 4:53 PM, He

Re: [swift-corelibs-dev] Measurement Formatters & ICU

2016-08-23 Thread Henry Betts via swift-corelibs-dev
> On 23 Aug 2016, at 16:58, Philippe Hausler wrote: > > Is there a specific version of ICU that we need to pick that functionality > up? As it stands we don’t have a upper version limit on ICU but if we had a > portion of the ICU source in CF it would probably mean that we would get > symboli

Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin

2016-08-23 Thread Philippe Hausler via swift-corelibs-dev
Looks like there was a merge done without the requirement that I set forth in the pull request. This means the Xcode project is properly broken now. > On Aug 23, 2016, at 4:14 PM, Luke Howard via swift-corelibs-dev > wrote: > > c26f465e breaks even further on Darwin – Xcode project not updated

Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin

2016-08-23 Thread Luke Howard via swift-corelibs-dev
c26f465e breaks even further on Darwin – Xcode project not updated, after updating that: /Users/lukeh/CVSRoot/apple/swift-corelibs-foundation/Foundation/NSURLSession/MultiHandle.swift:216:38: error: '_EasyHandle' is not a member type of 'URLSessionTask' fileprivate extension URLSessionTask._Easy

Re: [swift-corelibs-dev] Measurement Formatters & ICU

2016-08-23 Thread Philippe Hausler via swift-corelibs-dev
+Daphne since she was the one who implemented the Darwin version of the unit and measurements and I think she has some ideas on how we could perhaps build a uniform version for Linux hosts. Per the C++; the script for that phase probably needs a bit of love since we haven’t had a need for C++ t

Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin

2016-08-23 Thread Philippe Hausler via swift-corelibs-dev
Tossed up a PR for correcting this uniformly without needing alteration of the #if statements https://github.com/apple/swift-corelibs-foundation/pull/584 > On Aug 23, 2016, at 8:42 AM, Chris Bailey via swift-corelibs-dev > wrote: > > We're currently making the last few changes which should me

Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin

2016-08-23 Thread Chris Bailey via swift-corelibs-dev
We're currently making the last few changes which should mean that Dispatch always builds on Linux if your using Foundation, and as Dispatch is already there on Darwin, it should mean we can remove the condition statements entirely. Chris From: Luke Howard via swift-corelibs-dev To:

Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin

2016-08-23 Thread Luke Howard via swift-corelibs-dev
Also, the NSData test is broken on Darwin when libdispatch is enabled – possibly the system DispatchData is being pulled in and something funny happens, this seems to work around it but I’m not sure if it is the correct fix: +++ b/Foundation/NSData.swift @@ -228,7 +228,7 @@ open class NSData : N

[swift-corelibs-dev] f8c3fe6c breaks on Darwin

2016-08-23 Thread Luke Howard via swift-corelibs-dev
Enabling libdispatch seems to break the tests on Darwin because DEPLOYMENT_ENABLE_LIBDISPATCH is not added to the XCode project build flags (both for the C/Swift compilers). -- www.lukehoward.com soundcloud.com/lukehoward___ swift-corelibs-dev mailing