We're currently making the last few changes which should mean that
Dispatch always builds on Linux if your using Foundation, and as Dispatch
is already there on Darwin, it should mean we can remove the condition
statements entirely.
Chris
From: Luke Howard via swift-corelibs-dev <swift-corelibs-dev@swift.org>
To: Tony Parker via swift-corelibs-dev <swift-corelibs-dev@swift.org>
Date: 23/08/2016 08:55
Subject: Re: [swift-corelibs-dev] f8c3fe6c breaks on Darwin
Sent by: swift-corelibs-dev-boun...@swift.org
Also, the NSData test is broken on Darwin when libdispatch is enabled –
possibly the system DispatchData is being pulled in and something funny
happens, this seems to work around it but I’m not sure if it is the
correct fix:
+++ b/Foundation/NSData.swift
@@ -228,7 +228,7 @@ open class NSData : NSObject, NSCopying,
NSMutableCopying, NSSecureCoding {
}
open override func isEqual(_ value: Any?) -> Bool {
-#if DEPLOYMENT_ENABLE_LIBDISPATCH
+#if DEPLOYMENT_ENABLE_LIBDISPATCH && !os(OSX)
if let data = value as? DispatchData {
if data.count != length {
return false
On 23 Aug 2016, at 5:46 PM, Luke Howard via swift-corelibs-dev <
swift-corelibs-dev@swift.org> wrote:
Enabling libdispatch seems to break the tests on Darwin because
DEPLOYMENT_ENABLE_LIBDISPATCH is not added to the XCode project build
flags (both for the C/Swift compilers).
--
www.lukehoward.com
soundcloud.com/lukehoward
_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
--
www.lukehoward.com
soundcloud.com/lukehoward
_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
_______________________________________________
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
