Re: svn commit: r279877 - stable/10/sys/boot/fdt

2015-04-04 Thread Adrian Chadd
On 4 April 2015 at 02:17, Ed Schouten wrote: > 2015-04-04 11:16 GMT+02:00 Ed Schouten : >> Couldn't this use calloc() instead? > > Oh, wait. This is the boot loader. The boot loader wouldn't > necessarily have a calloc() function. .. why not? Wouldn't it be worth the code savings to have calloc

Re: svn commit: r279877 - stable/10/sys/boot/fdt

2015-04-04 Thread Ed Schouten
2015-04-04 11:16 GMT+02:00 Ed Schouten : > Couldn't this use calloc() instead? Oh, wait. This is the boot loader. The boot loader wouldn't necessarily have a calloc() function. -- Ed Schouten ___ svn-src-stable-10@freebsd.org mailing list https://list

Re: svn commit: r279877 - stable/10/sys/boot/fdt

2015-04-04 Thread Ed Schouten
Hi Alexander, Quick question: 2015-03-11 10:49 GMT+01:00 Alexander Motin : > buf = (char *)malloc(sizeof(char) * sz); > - bzero(buf, sizeof(char) * sz); > - > if (buf == NULL) { > sprintf(command_errbuf, "could not allocate space " > "for

svn commit: r279877 - stable/10/sys/boot/fdt

2015-03-11 Thread Alexander Motin
Author: mav Date: Wed Mar 11 09:49:06 2015 New Revision: 279877 URL: https://svnweb.freebsd.org/changeset/base/279877 Log: MFC r279275: Fix potential NULL dereference. Submitted by: Dmitry Luhtionov Modified: stable/10/sys/boot/fdt/fdt_loader_cmd.c Directory Properties: stable/10/ (