svn commit: r326377 - in head/sys: amd64/conf arm/conf i386/conf mips/conf modules/aic7xxx/ahc modules/aic7xxx/ahd powerpc/conf sparc64/conf

2017-11-29 Thread Scott Long
Author: scottl Date: Wed Nov 29 23:41:49 2017 New Revision: 326377 URL: https://svnweb.freebsd.org/changeset/base/326377 Log: It's time to retire AHC_REG_PRETTY_PRINT and AHD_REG_PRETTY_PRINT from the standard kernels. They are still available as custom compile options. Modified: head/sy

Re: svn commit: r326377 - in head/sys: amd64/conf arm/conf i386/conf mips/conf modules/aic7xxx/ahc modules/aic7xxx/ahd powerpc/conf sparc64/conf

2017-11-29 Thread Scott Long
> On Nov 29, 2017, at 6:19 PM, Bruce Evans wrote: > > On Wed, 29 Nov 2017, Scott Long wrote: > >> Log: >> It's time to retire AHC_REG_PRETTY_PRINT and AHD_REG_PRETTY_PRINT from >> the standard kernels. They are still available as custom compile >> op

Re: svn commit: r327559 - in head: . sys/net

2018-01-05 Thread Scott Long
> On Jan 5, 2018, at 11:20 AM, Eugene Grosbein wrote: > > CC'ng scottl@ as author of the change in question. > > 06.01.2018 0:39, Matt Joras wrote: > For what it's worth, this was the conclusion I came to, and at Isilon we've made the same change being discussed here. For the case o

svn commit: r327709 - head/sys/cam

2018-01-08 Thread Scott Long
Author: scottl Date: Tue Jan 9 00:00:55 2018 New Revision: 327709 URL: https://svnweb.freebsd.org/changeset/base/327709 Log: Protect against a possible NULL deference from an accessor function. Obtained from:Netflix Modified: head/sys/cam/cam_periph.h Modified: head/sys/cam/c

svn commit: r327710 - in head/sys/cam: . ata scsi

2018-01-08 Thread Scott Long
Author: scottl Date: Tue Jan 9 00:10:59 2018 New Revision: 327710 URL: https://svnweb.freebsd.org/changeset/base/327710 Log: Don't hold the periph lock when calling into cam_periph_runccb() from the ada and da dump routines. This avoids difficult locking problems from needing to be handled

svn commit: r327711 - head/sys/cam/nvme

2018-01-08 Thread Scott Long
Author: scottl Date: Tue Jan 9 00:17:15 2018 New Revision: 327711 URL: https://svnweb.freebsd.org/changeset/base/327711 Log: Don't hold the periph locks during dump. Obtained from:Netflix Modified: head/sys/cam/nvme/nvme_da.c Modified: head/sys/cam/nvme/nvme_da.c ==

svn commit: r327741 - head/sys/cam

2018-01-09 Thread Scott Long
Author: scottl Date: Tue Jan 9 21:23:16 2018 New Revision: 327741 URL: https://svnweb.freebsd.org/changeset/base/327741 Log: Hold a refcount on the periph while running the allocation queue. This will allow sub-transports to release their probe pseudo-device with fewer convoluted restricti

svn commit: r327742 - head/sys/cam/nvme

2018-01-09 Thread Scott Long
Author: scottl Date: Tue Jan 9 21:24:05 2018 New Revision: 327742 URL: https://svnweb.freebsd.org/changeset/base/327742 Log: Release the held refcount on the probe periph when probing is done, now that r327741 lets this happen. Obtained from:Netflix Modified: head/sys/cam/nvme

svn commit: r327761 - head/sbin/camcontrol

2018-01-09 Thread Scott Long
Author: scottl Date: Wed Jan 10 05:29:02 2018 New Revision: 327761 URL: https://svnweb.freebsd.org/changeset/base/327761 Log: Implement the ability to query NVME for its controller data so that it will be shown when issueing the 'camcontrol devlist' command. Obtained from:Netflix

svn commit: r327762 - head/sbin/camcontrol

2018-01-09 Thread Scott Long
Author: scottl Date: Wed Jan 10 05:52:24 2018 New Revision: 327762 URL: https://svnweb.freebsd.org/changeset/base/327762 Log: Refactor code related to 'camcontrol devlist' Obtained from:Netflix Modified: head/sbin/camcontrol/camcontrol.c Modified: head/sbin/camcontrol/camcontrol

svn commit: r328165 - in head: sbin/camcontrol sys/cam sys/cam/mmc

2018-01-19 Thread Scott Long
Author: scottl Date: Fri Jan 19 15:32:27 2018 New Revision: 328165 URL: https://svnweb.freebsd.org/changeset/base/328165 Log: Revert ABI breakage to CAM that came in with MMC/SD support in r320844. Make it possible to retrieve mmc parameters via the XPT_GET_ADVINFO call instead. Convert cam

Re: svn commit: r328165 - in head: sbin/camcontrol sys/cam sys/cam/mmc

2018-01-19 Thread Scott Long
> On Jan 19, 2018, at 11:01 AM, O. Hartmann wrote: > > It seems, this broke buildkernel for me (and probably others): > > [...] > ===> bhnd/cores/bhnd_pci (all) > --- mmc_xpt.o --- > /usr/src/sys/cam/mmc/mmc_xpt.c:371:17: error: assigning to 'off_t' (aka > 'long') from > incompatible type 'st

svn commit: r328170 - head/sys/cam/mmc

2018-01-19 Thread Scott Long
Author: scottl Date: Fri Jan 19 19:18:14 2018 New Revision: 328170 URL: https://svnweb.freebsd.org/changeset/base/328170 Log: Fix compile errors in r328165 Reported by: O. Hartmann Sponsored by: Netflix Modified: head/sys/cam/mmc/mmc_xpt.c Modified: head/sys/cam/mmc/mmc_xpt.c ===

svn commit: r328445 - head/sys/cam/scsi

2018-01-26 Thread Scott Long
Author: scottl Date: Fri Jan 26 18:42:28 2018 New Revision: 328445 URL: https://svnweb.freebsd.org/changeset/base/328445 Log: Fix a cut-and-paste error in a panic message Modified: head/sys/cam/scsi/scsi_da.c Modified: head/sys/cam/scsi/scsi_da.c =

svn commit: r328455 - in head/sys/cam: . scsi

2018-01-26 Thread Scott Long
Author: scottl Date: Fri Jan 26 23:56:07 2018 New Revision: 328455 URL: https://svnweb.freebsd.org/changeset/base/328455 Log: Move CAM_PERIPH_PRINT() to cam_periph.h Modified: head/sys/cam/cam_periph.h head/sys/cam/scsi/scsi_da.c Modified: head/sys/cam/cam_periph.h

svn commit: r328464 - head/sys/cam/scsi

2018-01-27 Thread Scott Long
Author: scottl Date: Sat Jan 27 07:18:02 2018 New Revision: 328464 URL: https://svnweb.freebsd.org/changeset/base/328464 Log: Finish the incomplete move of CAM_PERIPH_PRINT(). Reported by: kevans Modified: head/sys/cam/scsi/scsi_da.c Modified: head/sys/cam/scsi/scsi_da.c ==

svn commit: r331528 - head/sys/dev/ciss

2018-03-24 Thread Scott Long
Author: scottl Date: Sun Mar 25 06:08:18 2018 New Revision: 331528 URL: https://svnweb.freebsd.org/changeset/base/331528 Log: Update a TBD string with a real model number Submitted by: Sam Gwydir Modified: head/sys/dev/ciss/ciss.c Modified: head/sys/dev/ciss/ciss.c =

svn commit: r333147 - head/sys/cam

2018-05-01 Thread Scott Long
Author: scottl Date: Tue May 1 17:48:50 2018 New Revision: 333147 URL: https://svnweb.freebsd.org/changeset/base/333147 Log: Add and fix comments for cam_periph_runccb() Sponsored by: Netflix Modified: head/sys/cam/cam_periph.c Modified: head/sys/cam/cam_periph.c ==

svn commit: r333152 - in head/sys/cam: ata scsi

2018-05-01 Thread Scott Long
Author: scottl Date: Tue May 1 20:09:29 2018 New Revision: 333152 URL: https://svnweb.freebsd.org/changeset/base/333152 Log: cam_periph_runccb() changed several years ago to overwrite the ccb callback pointer. It's now unhelpful and misleading for callers to continue to set it, so bring al

svn commit: r333154 - head/sys/cam/scsi

2018-05-01 Thread Scott Long
Author: scottl Date: Tue May 1 21:42:27 2018 New Revision: 333154 URL: https://svnweb.freebsd.org/changeset/base/333154 Log: Refactor dadone(). There was no useful code sharing in it; it was just a 1500 line switch statement. Callers now specify a discrete completion handler, though they'

svn commit: r308217 - in head/sys/dev: mpr mps

2016-11-02 Thread Scott Long
Author: scottl Date: Wed Nov 2 15:13:25 2016 New Revision: 308217 URL: https://svnweb.freebsd.org/changeset/base/308217 Log: Add a fallback to the device mapper logic. We've seen systems in the field that are apparently misconfigured by the manufacturer and cause the mapping logic to fail.

svn commit: r308296 - head/sys/cam/scsi

2016-11-04 Thread Scott Long
Author: scottl Date: Fri Nov 4 16:56:36 2016 New Revision: 308296 URL: https://svnweb.freebsd.org/changeset/base/308296 Log: asc/ascq 44/0 is typically a non-transient, permanent error (at least until the components are reset). Therefore retries are pointless. This is very visible in SATL

svn commit: r308299 - head/sys/cam/scsi

2016-11-04 Thread Scott Long
Author: scottl Date: Fri Nov 4 17:08:52 2016 New Revision: 308299 URL: https://svnweb.freebsd.org/changeset/base/308299 Log: If the da periph probe state machine gets an asc=0x44 error, the periph is not going to recover until the system is reset. Treat it as a special case and don't allow

svn commit: r308301 - in head/sys/dev: mpr mps

2016-11-04 Thread Scott Long
Author: scottl Date: Fri Nov 4 17:25:47 2016 New Revision: 308301 URL: https://svnweb.freebsd.org/changeset/base/308301 Log: Record the LogInfo field when reporting the IOCStatus. Helps in debugging errors. Submitted by: slm Obtained from:Netflix MFC after:3 days Modifi

svn commit: r308423 - head/sys/dev/mpt

2016-11-07 Thread Scott Long
Author: scottl Date: Mon Nov 7 17:34:19 2016 New Revision: 308423 URL: https://svnweb.freebsd.org/changeset/base/308423 Log: Fix the fallout from r308268 (mpt driver causes endless witness warnings in VMWare and elsewhere) with the precision of a dull, rusty butter knife. Reported by: t

svn commit: r308431 - head/sys/dev/nvme

2016-11-07 Thread Scott Long
Author: scottl Date: Tue Nov 8 00:24:49 2016 New Revision: 308431 URL: https://svnweb.freebsd.org/changeset/base/308431 Log: Convert the Q-Pair and PRP list memory allocations to use BUSDMA. Add a bunch of safery belts and error handling in related codepaths. Reviewed by: jimharris O

Re: svn commit: r308217 - in head/sys/dev: mpr mps

2016-11-09 Thread Scott Long
> On Nov 4, 2016, at 3:18 AM, Harry Schmalzbauer wrote: > > Bezüglich Scott Long's Nachricht vom 02.11.2016 16:13 (localtime): >> Author: scottl >> Date: Wed Nov 2 15:13:25 2016 >> New Revision: 308217 >> URL: https://svnweb.freebsd.org/changeset/base/308217 >> >> Log: >> Add a fallback to th

svn commit: r309201 - head/sys/netipsec

2016-11-26 Thread Scott Long
Author: scottl Date: Sat Nov 26 23:15:11 2016 New Revision: 309201 URL: https://svnweb.freebsd.org/changeset/base/309201 Log: Add a missing header Modified: head/sys/netipsec/keydb.h Modified: head/sys/netipsec/keydb.h =

svn commit: r353456 - head/usr.sbin/pciconf

2019-10-12 Thread Scott Long
Author: scottl Date: Sat Oct 12 22:27:57 2019 New Revision: 353456 URL: https://svnweb.freebsd.org/changeset/base/353456 Log: Change from the non-standard nomenclature of "chip" and "card" to the standard nomenclature of "device" and "vendor" with the "sub" variants. This changes the printed

Re: svn commit: r353456 - head/usr.sbin/pciconf

2019-10-12 Thread Scott Long
> On Oct 12, 2019, at 7:10 PM, Rodney W. Grimes > wrote: > >> Author: scottl >> Date: Sat Oct 12 22:27:57 2019 >> New Revision: 353456 >> URL: https://svnweb.freebsd.org/changeset/base/353456 >> >> Log: >> Change from the non-standard nomenclature of "chip" and "card" to the >> standard nom

svn commit: r353462 - head/usr.sbin/pciconf

2019-10-12 Thread Scott Long
Author: scottl Date: Sun Oct 13 05:11:53 2019 New Revision: 353462 URL: https://svnweb.freebsd.org/changeset/base/353462 Log: Fix the botched field ordering in the last commit. While here, fix whitespace, and also reorder the fields so they are easier to read on an 80 column display (the li

svn commit: r354143 - head/sys/dev/sound/pci/hda

2019-10-28 Thread Scott Long
Author: scottl Date: Mon Oct 28 23:31:22 2019 New Revision: 354143 URL: https://svnweb.freebsd.org/changeset/base/354143 Log: Add device IDs for the next generation of Intel HDA audio. MFC after:3 days Modified: head/sys/dev/sound/pci/hda/hdac.c head/sys/dev/sound/pci/hda/hdac.h

svn commit: r354631 - head/sys/x86/x86

2019-11-11 Thread Scott Long
Author: scottl Date: Mon Nov 11 22:18:05 2019 New Revision: 354631 URL: https://svnweb.freebsd.org/changeset/base/354631 Log: Add the text attribute for MDS_NO in the IA32_ARCH_CAP MSR. Modified: head/sys/x86/x86/identcpu.c Modified: head/sys/x86/x86/identcpu.c ==

svn commit: r354655 - in head/sys/x86: include x86

2019-11-12 Thread Scott Long
Author: scottl Date: Tue Nov 12 19:15:16 2019 New Revision: 354655 URL: https://svnweb.freebsd.org/changeset/base/354655 Log: Add new bit definitions for TSX, related to the TAA issue. The actual mitigation will follow in a future commit. Sponsored by: Intel Modified: head/sys/x86/inc

svn commit: r354683 - head/sys/dev/fb

2019-11-13 Thread Scott Long
Author: scottl Date: Wed Nov 13 15:31:31 2019 New Revision: 354683 URL: https://svnweb.freebsd.org/changeset/base/354683 Log: Stop the VESA driver from whining loudly in the dmesg during boot on systems that use EFI instead of BIOS. Modified: head/sys/dev/fb/vesa.c Modified: head/sys/dev/f

svn commit: r354729 - head/sys/x86/x86

2019-11-15 Thread Scott Long
Author: scottl Date: Fri Nov 15 11:53:06 2019 New Revision: 354729 URL: https://svnweb.freebsd.org/changeset/base/354729 Log: Fix a typo in how the AVX512DQ feature bit is checked. Reviewed by: kib Sponsored by: Intel Modified: head/sys/x86/x86/busdma_machdep.c head/sys/x86/x86/cpu_

svn commit: r354730 - head/sys/x86/x86

2019-11-15 Thread Scott Long
Author: scottl Date: Fri Nov 15 11:54:51 2019 New Revision: 354730 URL: https://svnweb.freebsd.org/changeset/base/354730 Log: Revert a patch that accidentally was committed with r354729 Modified: head/sys/x86/x86/busdma_machdep.c Modified: head/sys/x86/x86/busdma_machdep.c ==

Re: svn commit: r354703 - head/sys/dev/ioat

2019-11-15 Thread Scott Long
> On Nov 15, 2019, at 2:18 AM, Konstantin Belousov wrote: > > On Thu, Nov 14, 2019 at 09:41:36AM -0500, Alexander Motin wrote: >> On 14.11.2019 05:11, Konstantin Belousov wrote: >>> On Thu, Nov 14, 2019 at 04:39:49AM +, Alexander Motin wrote: Author: mav Date: Thu Nov 14 04:39:48

svn commit: r354756 - in head/sys: kern sys

2019-11-15 Thread Scott Long
Author: scottl Date: Fri Nov 15 23:27:17 2019 New Revision: 354756 URL: https://svnweb.freebsd.org/changeset/base/354756 Log: Create a new sysctl subtree, machdep.mitigations. Its purpose is to organize knobs and indicators for code that mitigates functional and security issues in the archi

svn commit: r354759 - in head/sys: amd64/amd64 dev/cpuctl x86/include x86/x86

2019-11-15 Thread Scott Long
Author: scottl Date: Sat Nov 16 00:26:42 2019 New Revision: 354759 URL: https://svnweb.freebsd.org/changeset/base/354759 Log: TSX Asynchronous Abort mitigation for Intel CVE-2019-11135. This CVE has already been announced in FreeBSD SA-19:26.mcu. Mitigation for TAA involves either turning

svn commit: r355009 - head/sys/cam/scsi

2019-11-22 Thread Scott Long
Author: scottl Date: Fri Nov 22 18:18:36 2019 New Revision: 355009 URL: https://svnweb.freebsd.org/changeset/base/355009 Log: Remove NEEDGIANT from the scsi_sg /dev node. It likely has not been needed for many years. Reported by: imp Modified: head/sys/cam/scsi/scsi_sg.c Modified: h

svn commit: r355012 - in head: share/man/man4 sys/dev/trm

2019-11-22 Thread Scott Long
Author: scottl Date: Fri Nov 22 18:50:53 2019 New Revision: 355012 URL: https://svnweb.freebsd.org/changeset/base/355012 Log: Schedule the trm(4) driver for removal. It relies on Giant and thus has required compat shims in CAM for 12 years. Relnotes: yes Modified: head/share/man/m

svn commit: r355021 - in head: share/man/man4 sys/dev/hpt27xx

2019-11-22 Thread Scott Long
Author: scottl Date: Fri Nov 22 20:23:22 2019 New Revision: 355021 URL: https://svnweb.freebsd.org/changeset/base/355021 Log: Mark hpt27xx for removal in 13.0; all CAM drivers will be Giant-free by then. Relnotes: yes Modified: head/share/man/man4/hpt27xx.4 head/sys/dev/hpt27xx/hpt

svn commit: r355114 - in head: share/man/man4 sys/dev/hpt27xx

2019-11-26 Thread Scott Long
Author: scottl Date: Tue Nov 26 17:25:49 2019 New Revision: 355114 URL: https://svnweb.freebsd.org/changeset/base/355114 Log: Revert r355021. In my haste to grep for Giant, I missed that it was in conditional ifdefs for this driver. We will consider removing those ifdefs in the future.

svn commit: r355134 - head/sys/x86/x86

2019-11-27 Thread Scott Long
Author: scottl Date: Wed Nov 27 19:12:32 2019 New Revision: 355134 URL: https://svnweb.freebsd.org/changeset/base/355134 Log: Clean up and clarify meta commentary on TAA. Add a state to denote that TSX doesn't exist on the CPU. MFC after:3 days Sponsored by: Intel Modified: head

svn commit: r355164 - in head: . share/man/man4 sys/amd64/conf sys/conf sys/dev/trm sys/i386/conf sys/modules sys/modules/trm

2019-11-27 Thread Scott Long
Author: scottl Date: Thu Nov 28 02:32:17 2019 New Revision: 355164 URL: https://svnweb.freebsd.org/changeset/base/355164 Log: Remove the trm(4) driver Differential Revision:https://reviews.freebsd.org/D22575 Deleted: head/share/man/man4/trm.4 head/sys/dev/trm/ head/sys/module

Re: svn commit: r351458 - head/share/man/man4

2019-08-24 Thread Scott Long
Thank you! Scott > On Aug 24, 2019, at 9:38 AM, Konstantin Belousov wrote: > > Author: kib > Date: Sat Aug 24 15:38:07 2019 > New Revision: 351458 > URL: https://svnweb.freebsd.org/changeset/base/351458 > > Log: > Add nvdimm(4) man page. > > Reviewed by: emaste > Discussed with: scott

Re: svn commit: r351550 - head/sys/cam/scsi

2019-08-27 Thread Scott Long
This is very concerning, and I wonder if it’s the cause of the mystery use-after-free / double-complete that I’ve seen for years and have never been able to catch. Can you say more about how you found it? Scott > On Aug 27, 2019, at 10:41 AM, Alexander Motin wrote: > > Author: mav > Date: T

Re: svn commit: r351550 - head/sys/cam/scsi

2019-08-27 Thread Scott Long
diagnose it I inserted assertion into > xpt_free_ccb(), checking ccb->ccb_h.pinfo.index for values used for > requests still in send queue. Not sure it is to be persistent, but in > this case it lead me directly to this place. > > On 27.08.2019 16:23, Scott Long wrote: >> T

svn commit: r345573 - in head/sys/dev: mpr mps

2019-09-03 Thread Scott Long
Author: scottl Date: Wed Mar 27 12:25:46 2019 New Revision: 345573 URL: https://svnweb.freebsd.org/changeset/base/345573 Log: Add missing break statements. Coverity CID 1400446. Reported by: mav Modified: head/sys/dev/mpr/mpr_table.c head/sys/dev/mps/mps_table.c Modified: head/sys/d

svn commit: r351939 - head/share/misc

2019-09-06 Thread Scott Long
Author: scottl Date: Fri Sep 6 17:06:48 2019 New Revision: 351939 URL: https://svnweb.freebsd.org/changeset/base/351939 Log: Add myself as a mentor for Scott Phillip (scottph) Modified: head/share/misc/committers-src.dot Modified: head/share/misc/committers-src.dot =

Re: svn commit: r349146 - head/share/man/man4

2019-06-17 Thread Scott Long
It’s customary to refer to PCI configuration registers in the plural form. Would you mind changing back from “register” to “registers”? Thanks, Scott > On Jun 17, 2019, at 10:54 AM, Niclas Zeising wrote: > > Author: zeising (doc,ports committer) > Date: Mon Jun 17 16:54:51 2019 > New Revisio

Re: svn commit: r349146 - head/share/man/man4

2019-06-17 Thread Scott Long
> On Jun 17, 2019, at 11:37 AM, Niclas Zeising wrote: > > On 2019-06-17 19:27, Scott Long wrote: >> It’s customary to refer to PCI configuration registers in the plural form. >> Would >> you mind changing back from “register” to “registers”? > > I didn&

svn commit: r349184 - head/sys/amd64/vmm/intel

2019-06-18 Thread Scott Long
Author: scottl Date: Wed Jun 19 06:41:07 2019 New Revision: 349184 URL: https://svnweb.freebsd.org/changeset/base/349184 Log: Implement VT-d capability detection on chipsets that have multiple translation units with differing capabilities From the author via Bugzilla: --- When an atte

Re: svn commit: r349243 - head/sys/cam

2019-06-20 Thread Scott Long
Hi Alexander, I’m not a fan of removing the M_ZERO. I understand your argument that lengths are provided elsewhere, but having the buffer be zero’d is defensive against future bugs that might leak buffer contents. GETATTR isn’t typically in a performance path, is there any measurable benefit to

Re: svn commit: r349243 - head/sys/cam

2019-06-21 Thread Scott Long
licitly made to not read outside > the range that was copied to the buffer with simple and dumb memcpy(). > > The effect is clearly visible in profiler when GEOM confxml calls it 3 > times for each disk, taking about 25% of the sysctl's CPU time. With > hundreds of disks it is n

svn commit: r349283 - head/sys/cam

2019-06-21 Thread Scott Long
Author: scottl Date: Fri Jun 21 23:40:26 2019 New Revision: 349283 URL: https://svnweb.freebsd.org/changeset/base/349283 Log: Refactor xpt_getattr() to make it more readable. No outwardly visible functional changes, though code flow was modified a bit internally to lessen the need for goto

svn commit: r349335 - head/usr.sbin/bhyve

2019-06-24 Thread Scott Long
Author: scottl Date: Mon Jun 24 19:31:32 2019 New Revision: 349335 URL: https://svnweb.freebsd.org/changeset/base/349335 Log: Add the PCI HDAudio device model from the 2016 GSoC. Detailed information can be found at https://wiki.freebsd.org/SummerOfCode2016/HDAudioEmulationForBhyve

svn commit: r349336 - head/usr.sbin/bhyve

2019-06-24 Thread Scott Long
Author: scottl Date: Mon Jun 24 19:42:32 2019 New Revision: 349336 URL: https://svnweb.freebsd.org/changeset/base/349336 Log: Add a section about the HD Audio module support Modified: head/usr.sbin/bhyve/bhyve.8 Modified: head/usr.sbin/bhyve/bhyve.8 ==

Re: svn commit: r349231 - in head/sys: kern sys ufs/ufs

2019-06-27 Thread Scott Long
> On Jun 27, 2019, at 3:09 PM, Konstantin Belousov wrote: > > On Thu, Jun 27, 2019 at 02:01:11PM -0600, Alan Somers wrote: >> On Thu, Jun 27, 2019 at 1:18 PM Konstantin Belousov >> wrote: >>> >>> On Thu, Jun 20, 2019 at 02:13:11PM +, Alan Somers wrote: Author: asomers Date: Thu

Re: svn commit: r349791 - head/sys/vm

2019-07-08 Thread Scott Long
Hi Bruce, This isn’t the first time I’ve witnessed your passion on this topic. It would help immensely if there was some documentation, maybe in /sys/sys/param.h, or maybe even in a manual page, on what a “click” is, what a “db” is, why they’re important, and how they should be used. Do you have

svn commit: r349948 - in head/sys/amd64: include vmm

2019-07-12 Thread Scott Long
Author: scottl Date: Fri Jul 12 18:37:56 2019 New Revision: 349948 URL: https://svnweb.freebsd.org/changeset/base/349948 Log: Tie the name limit of a VM to SPECNAMELEN from devfs instead of a hard-coded value. Don't allocate space for it from the kernel stack. Account for prefix, suffix, and

Re: svn commit: r349953 - head/sys/amd64/vmm

2019-07-12 Thread Scott Long
Thanks, sorry about that, I had compiled and tested this a dozen times before committing, not sure how this crept in. Scott > On Jul 12, 2019, at 1:14 PM, Konstantin Belousov wrote: > > Author: kib > Date: Fri Jul 12 19:14:52 2019 > New Revision: 349953 > URL: https://svnweb.freebsd.org/change

svn commit: r350255 - head/usr.sbin/bhyve

2019-07-23 Thread Scott Long
Author: scottl Date: Tue Jul 23 18:40:07 2019 New Revision: 350255 URL: https://svnweb.freebsd.org/changeset/base/350255 Log: Fix the register layout for the Buffer Descript List Entry. It got jumbled around during some other cleanups and was causing audio failures on some guests. PR:

Re: svn commit: r349863 - in head/sys/contrib/dev/acpica: . compiler components/dispatcher components/events components/executer components/namespace components/tables components/utilities include

2019-08-01 Thread Scott Long
Hi, I need to ask that this be backed out. I have two systems that are failing to boot when this revision is present. One I can’t debug because it causes USB to fail to probe, leaving me without a working console (and no network access for other reasons). The other fails in a different way and

Re: svn commit: r350510 - in head/sys/contrib/dev/acpica: . compiler components/dispatcher components/events components/executer components/namespace components/tables components/utilities include

2019-08-01 Thread Scott Long
Thanks. I’m working on the root cause right now, hopefully will have more information soon. Scott > On Aug 1, 2019, at 11:45 AM, Jung-uk Kim wrote: > > Author: jkim > Date: Thu Aug 1 17:45:43 2019 > New Revision: 350510 > URL: https://svnweb.freebsd.org/changeset/base/350510 > > Log: > Rev

Re: svn commit: r350550 - head/share/mk

2019-08-07 Thread Scott Long
> On Aug 7, 2019, at 10:00 AM, John Baldwin wrote: > > On 8/6/19 9:56 AM, Glen Barber wrote: >> On Sat, Aug 03, 2019 at 01:06:18AM +, John Baldwin wrote: >>> Author: jhb >>> Date: Sat Aug 3 01:06:17 2019 >>> New Revision: 350550 >>> URL: https://svnweb.freebsd.org/changeset/base/350550 >>>

Re: svn commit: r350694 - in head: share/man/man9 sys/dev/fdc sys/geom sys/geom/cache sys/geom/concat sys/geom/eli sys/geom/gate sys/geom/journal sys/geom/label sys/geom/linux_lvm sys/geom/mirror sys/

2019-08-07 Thread Scott Long
Good work on this and on r347229 and the sbuf improvements! Scott > On Aug 7, 2019, at 1:28 PM, Conrad Meyer wrote: > > Author: cem > Date: Wed Aug 7 19:28:35 2019 > New Revision: 350694 > URL: https://svnweb.freebsd.org/changeset/base/350694 > > Log: > GEOM: Reduce unnecessary log interlea

svn commit: r362998 - in head: stand/defaults sys/amd64/amd64 sys/powerpc/aim sys/vm

2020-07-07 Thread Scott Long
Author: scottl Date: Tue Jul 7 20:33:11 2020 New Revision: 362998 URL: https://svnweb.freebsd.org/changeset/base/362998 Log: Migrate the feature of excluding RAM pages to use "excludelist" as its nomenclature. MFC after:1 week Modified: head/stand/defaults/loader.conf head/sys/a

svn commit: r362999 - head/stand/defaults

2020-07-07 Thread Scott Long
Author: scottl Date: Tue Jul 7 20:42:35 2020 New Revision: 362999 URL: https://svnweb.freebsd.org/changeset/base/362999 Log: Fix a example/docs typo from r362998, no functional change. Modified: head/stand/defaults/loader.conf Modified: head/stand/defaults/loader.conf ==

svn commit: r363060 - in head: stand/defaults sys/amd64/amd64 sys/powerpc/aim sys/vm

2020-07-09 Thread Scott Long
Author: scottl Date: Thu Jul 9 22:38:36 2020 New Revision: 363060 URL: https://svnweb.freebsd.org/changeset/base/363060 Log: Revert r362998, r326999 while a better compatibility strategy is devised. Modified: head/stand/defaults/loader.conf head/sys/amd64/amd64/pmap.c head/sys/powerpc/ai

svn commit: r366668 - in head/sys/dev: mpr mps

2020-10-13 Thread Scott Long
Author: scottl Date: Tue Oct 13 14:10:49 2020 New Revision: 38 URL: https://svnweb.freebsd.org/changeset/base/38 Log: Bring the request_descriptor union into harmony internally. No functional change. Modified: head/sys/dev/mpr/mpr.c head/sys/dev/mps/mps.c Modified: head/sys/dev/

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-24 Thread Scott Long
> On Oct 24, 2020, at 9:46 PM, Rodney W. Grimes > wrote: > >>> >>> Something feels very wrong about this becoming a defined path in base, >>> it is further dependence on /usr/local which in the early days we spent >>> a great deal of time removing. >>> >>> I believe the whole ports system al

svn commit: r367053 - head/usr.bin/calendar/calendars

2020-10-25 Thread Scott Long
Alexander Botero-Lowry died in San Francisco, California, United States, 2012 08/25 Beech Rintoul born in Oakland, California, United States, 1952 08/25 Jean Milanez Melo born in Divinopolis, Minas Gerais, Brazil, 1982 -08/26 Scott Long born in Chicago, Illinois, United States, 1974 +08/25

Re: svn commit: r366962 - in head: include usr.bin/calendar

2020-10-26 Thread Scott Long
> On Oct 26, 2020, at 1:50 AM, Baptiste Daroussin wrote: > > On Mon, Oct 26, 2020 at 12:11:56AM -0600, Warner Losh wrote: >> On Mon, Oct 26, 2020 at 12:01 AM Alex Kozlov wrote: >> >>> On Sun, Oct 25, 2020 at 11:37:34AM +0100, Stefan Esser wrote: Am 25.10.20 um 06:56 schrieb Alex Kozlov: >

svn commit: r367686 - head/lib/libutil

2020-11-14 Thread Scott Long
ocalbase.3 == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/lib/libutil/getlocalbase.3 Sat Nov 14 17:57:50 2020 (r367686) @@ -0,0 +1,110 @@ +.\" +.\" SPDX-License-Identifier: BSD-2-Clause-FreeBSD +.\" +.\" Copyright 2020 Scott Long +.\&q

svn commit: r367687 - in head: sbin/nvmecontrol usr.sbin/mailwrapper usr.sbin/pkg

2020-11-14 Thread Scott Long
Author: scottl Date: Sat Nov 14 18:01:14 2020 New Revision: 367687 URL: https://svnweb.freebsd.org/changeset/base/367687 Log: Replace hardcoded references to _PATH_LOCALBASE with calls to getlocalbase.3 Reviewed by: imp, se Modified: head/sbin/nvmecontrol/comnd.c head/sbin/nvmecontrol

Re: svn commit: r367686 - head/lib/libutil

2020-11-14 Thread Scott Long
> > Got this on arm64 with the following src.conf: > > WITH_MALLOC_PRODUCTION=1 > WITH_EXTRA_TCP_STACKS=1 > WITH_BEARSSL=1 > WITH_PIE=1 > WITH_RETPOLINE=1 > > --Gordon > > On Sat, Nov 14, 2020 at 05:57:50PM +, Scott Long wrote: >>

svn commit: r367689 - head/lib/libutil

2020-11-14 Thread Scott Long
Author: scottl Date: Sat Nov 14 19:04:36 2020 New Revision: 367689 URL: https://svnweb.freebsd.org/changeset/base/367689 Log: Fix a problem with r367686 related to the use of ssize_t. Not sure how this escaped prior testing, but it should be better now. Reported by: lots Modified: he

svn commit: r367701 - head/lib/libutil

2020-11-14 Thread Scott Long
Author: scottl Date: Sun Nov 15 07:48:52 2020 New Revision: 367701 URL: https://svnweb.freebsd.org/changeset/base/367701 Log: Because getlocalbase() returns -1 on error, it needs to use a signed type internally. Do that, and make sure that conversations between signed and unsigned don't ove

svn commit: r367702 - in head: sbin/nvmecontrol usr.sbin/mailwrapper usr.sbin/pkg

2020-11-14 Thread Scott Long
Author: scottl Date: Sun Nov 15 07:50:29 2020 New Revision: 367702 URL: https://svnweb.freebsd.org/changeset/base/367702 Log: Fix the previous revision, it suffered from an incomplete change to the getlocalbase API. Also don't erroneously subtract the lenth from the buffer a second time. M

Re: svn commit: r367687 - in head: sbin/nvmecontrol usr.sbin/mailwrapper usr.sbin/pkg

2020-11-15 Thread Scott Long
I fixed this in r367702, sorry for the breakage. Scott > On Nov 15, 2020, at 11:12 AM, Brandon Bergren wrote: > >> --- head/usr.sbin/pkg/pkg.c Sat Nov 14 17:57:50 2020(r367686) >> +++ head/usr.sbin/pkg/pkg.c Sat Nov 14 18:01:14 2020(r367687) >> @@ -43,6 +43,7 @@ __FBSDID("$Fr

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Scott Long
> On Nov 15, 2020, at 11:31 AM, Jessica Clarke wrote: > > Hi Scott, > I'm concerned by this diff; see my comments below. > >> On 15 Nov 2020, at 07:48, Scott Long wrote: >> >> Author: scottl >> Date: Sun Nov 15 07:48:52 2020 >> New R

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Scott Long
> On Nov 15, 2020, at 12:01 PM, Jessica Clarke wrote: >> >> I felt similar concerns, but my misunderstanding of strlcpy() drove the >> result. Since the use case for getlocalbase() lends itself to also use >> strlcat()/strlcpy(), I was trying to replicate the API semantics of those, >> at least

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Scott Long
age: pkg [-v] [-d] [-l] [-N] [-j |-c |-r >>> ] [-C ] [-R ] [-o var=value] >>> [-4|-6] [] >>> >>> For more information on available commands and options see 'pkg help'. >>> root@crow:~ # >>> >>> >>> I would double ch

Re: svn commit: r367701 - head/lib/libutil

2020-11-15 Thread Scott Long
> On Nov 15, 2020, at 1:05 PM, Warner Losh wrote: > > Hey Scott, > > On Sun, Nov 15, 2020 at 11:46 AM Scott Long wrote: > The man page for strlcpy() made reference to the return value being > equivalent to what snprintf() does. The man page for snprintf() states > th

svn commit: r367711 - in head: lib/libutil sbin/nvmecontrol usr.sbin/mailwrapper usr.sbin/pkg

2020-11-15 Thread Scott Long
Author: scottl Date: Sun Nov 15 20:24:59 2020 New Revision: 367711 URL: https://svnweb.freebsd.org/changeset/base/367711 Log: Revert the whole getlocalbase() set of changes while a different design is hashed out. Deleted: head/lib/libutil/getlocalbase.3 head/lib/libutil/getlocalbase.c Mod

svn commit: r355429 - head/sys/dev/sound/pci/hda

2019-12-05 Thread Scott Long
Author: scottl Date: Thu Dec 5 19:39:51 2019 New Revision: 355429 URL: https://svnweb.freebsd.org/changeset/base/355429 Log: Add support for new sound HDA hardware Sponsored by: Intel Modified: head/sys/dev/sound/pci/hda/hdac.c head/sys/dev/sound/pci/hda/hdac.h head/sys/dev/sound/pc

svn commit: r355436 - in head/sys: amd64/amd64 x86/x86

2019-12-05 Thread Scott Long
Author: scottl Date: Fri Dec 6 02:43:05 2019 New Revision: 355436 URL: https://svnweb.freebsd.org/changeset/base/355436 Log: Move the mds, irbs, and ssb mitigation knobs into machdep.mitigations. They're in both the old and new places in HEAD for the moment for discussion and transition. T

Re: svn commit: r355436 - in head/sys: amd64/amd64 x86/x86

2019-12-06 Thread Scott Long
ote: > > > >> On Dec 6, 2019, at 4:36 AM, Ed Maste wrote: >> >> On Thu, 5 Dec 2019 at 21:43, Scott Long wrote: >>> >>> Author: scottl >>> Date: Fri Dec 6 02:43:05 2019 >>> New Revision: 355436 >>> URL: https://svnweb.free

svn commit: r355589 - head/sys/x86/x86

2019-12-10 Thread Scott Long
Author: scottl Date: Tue Dec 10 18:57:39 2019 New Revision: 355589 URL: https://svnweb.freebsd.org/changeset/base/355589 Log: Fix the TAA state machine to do the right thing when the TAA migitation is available in microcode and the operator has set the sysctl to automatic mode. Reported

Re: svn commit: r355430 - head/sys/cam/scsi

2019-12-11 Thread Scott Long
U+FFFD doesn’t make sense for an ASCII string, but 0x3F might. Any idea what Windows shows for this device? Scott > On Dec 11, 2019, at 8:42 AM, Alan Somers wrote: > > In this case the offending descriptor is solid 0xFF, so replacing individual > characters wouldn't accomplish anything. I c

svn commit: r355741 - in head: sys/dev/pci usr.sbin/pciconf

2019-12-13 Thread Scott Long
Author: scottl Date: Fri Dec 13 23:46:59 2019 New Revision: 355741 URL: https://svnweb.freebsd.org/changeset/base/355741 Log: Add accessors for the Vendor Specific Extended Capability (VSEC) Parse out the VSEC. If the user invokes a second -c command line option, do a hex dump of the vendor

svn commit: r356050 - in head: share/man/man9 sys/arm/arm sys/arm64/arm64 sys/mips/mips sys/powerpc/powerpc sys/riscv/riscv sys/sparc64/sparc64 sys/sys sys/x86/x86

2019-12-24 Thread Scott Long
Author: scottl Date: Tue Dec 24 14:48:46 2019 New Revision: 356050 URL: https://svnweb.freebsd.org/changeset/base/356050 Log: Introduce the concept of busdma tag templates. A template can be allocated off the stack, initialized to default values, and then filled in with driver-specific value

svn commit: r356051 - head/sys/sys

2019-12-24 Thread Scott Long
Author: scottl Date: Tue Dec 24 14:49:37 2019 New Revision: 356051 URL: https://svnweb.freebsd.org/changeset/base/356051 Log: Bump __FreeBSD_version for the addition of busdma templates. Modified: head/sys/sys/param.h Modified: head/sys/sys/param.h ===

svn commit: r356052 - head/sys/dev/mpr

2019-12-24 Thread Scott Long
Author: scottl Date: Tue Dec 24 14:50:17 2019 New Revision: 356052 URL: https://svnweb.freebsd.org/changeset/base/356052 Log: Convert the mpr driver to use busdma templates. Modified: head/sys/dev/mpr/mpr.c head/sys/dev/mpr/mpr_pci.c head/sys/dev/mpr/mpr_user.c Modified: head/sys/dev/mpr

svn commit: r356098 - head/sys/dev/pci

2019-12-26 Thread Scott Long
Author: scottl Date: Thu Dec 26 21:00:06 2019 New Revision: 356098 URL: https://svnweb.freebsd.org/changeset/base/356098 Log: Abstract the locking for PCIe hotplug. It still uses Giant so there's no functional change yet. Modified: head/sys/dev/pci/pci_pci.c head/sys/dev/pci/pcib_private

svn commit: r356267 - head/usr.sbin/pciconf

2020-01-01 Thread Scott Long
Author: scottl Date: Thu Jan 2 06:56:28 2020 New Revision: 356267 URL: https://svnweb.freebsd.org/changeset/base/356267 Log: Add a compact columnar output format, available by specifying a second '-l' command line option. Thanks to the removal of unnecessary information and the organizatio

Re: svn commit: r356192 - head/sys/geom

2020-01-04 Thread Scott Long
Good job! > On Dec 29, 2019, at 7:46 PM, Alexander Motin wrote: > > Author: mav > Date: Mon Dec 30 00:46:10 2019 > New Revision: 356192 > URL: https://svnweb.freebsd.org/changeset/base/356192 > > Log: > Retire nstart/nend counters. > > Those counters were abused for decade to workaround brok

svn commit: r356762 - head/usr.sbin/pciconf

2020-01-15 Thread Scott Long
Author: scottl Date: Wed Jan 15 16:47:44 2020 New Revision: 356762 URL: https://svnweb.freebsd.org/changeset/base/356762 Log: Fix a spacing error from the previous commit for -ll mode. Add a little more space padding to that mode to give the columns a consistent offset. Modified: head/usr.

  1   2   3   4   >