svn commit: r310892 - head/usr.sbin/bsnmpd/tools/bsnmptools

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 09:43:35 2016 New Revision: 310892 URL: https://svnweb.freebsd.org/changeset/base/310892 Log: Don't call snmp_pdu_free(..) until finished with the pdu and when ready to allocate a new one via snmp_pdu_create(..) This fixes bsnmpwalk, so it no longer crashes a

svn commit: r310893 - head/usr.sbin/syslogd

2016-12-31 Thread Hiroki Sato
Author: hrs Date: Sat Dec 31 09:52:00 2016 New Revision: 310893 URL: https://svnweb.freebsd.org/changeset/base/310893 Log: Remove extra NULL-check before free(3). Modified: head/usr.sbin/syslogd/syslogd.c Modified: head/usr.sbin/syslogd/syslogd.c =

svn commit: r310894 - head/usr.sbin/bsnmpd/tools/bsnmptools

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 10:01:25 2016 New Revision: 310894 URL: https://svnweb.freebsd.org/changeset/base/310894 Log: snmp_pdu_free the right object at the right time in snmptool_walk r310892 was on the right track, but unfortunately it was resolving the problem incorrectly and acci

svn commit: r310907 - head/sys/vm

2016-12-31 Thread Mateusz Guzik
Author: mjg Date: Sat Dec 31 10:37:56 2016 New Revision: 310907 URL: https://svnweb.freebsd.org/changeset/base/310907 Log: Use vrefact in vnode_pager_alloc. Modified: head/sys/vm/vnode_pager.c Modified: head/sys/vm/vnode_pager.c ===

svn commit: r310921 - head/usr.sbin/inetd

2016-12-31 Thread Hiroki Sato
Author: hrs Date: Sat Dec 31 11:03:34 2016 New Revision: 310921 URL: https://svnweb.freebsd.org/changeset/base/310921 Log: - Add static for symbols which need not to be exported. - Clean up warnings to the WARNS=6 level. Modified: head/usr.sbin/inetd/builtins.c head/usr.sbin/inetd/inetd.c

svn commit: r310925 - head/sys/sys

2016-12-31 Thread Konstantin Belousov
Author: kib Date: Sat Dec 31 11:07:33 2016 New Revision: 310925 URL: https://svnweb.freebsd.org/changeset/base/310925 Log: Remove unused declaration. The setconf() implementation was removed by r52778 Nov 1 1999. Sponsored by: The FreeBSD Foundation MFC after:1 week Modified:

svn commit: r310931 - head/contrib/bsnmp/lib

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 11:13:00 2016 New Revision: 310931 URL: https://svnweb.freebsd.org/changeset/base/310931 Log: Use strdup in snmp_parse_server(..) when possible instead of malloc+strcpy This simplifies the code and mutes a Coverity warning about sc->cport being improperly all

svn commit: r310942 - head/contrib/bsnmp/lib

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 11:24:12 2016 New Revision: 310942 URL: https://svnweb.freebsd.org/changeset/base/310942 Log: Unbreak the build by passing the string to strdup, not its length MFC after:1 week X-MFC with: r310931 Pointyhat to: ngie Modified: head/contrib/bsnmp/lib

svn commit: r310950 - head/contrib/bsnmp/snmp_mibII

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 11:50:36 2016 New Revision: 310950 URL: https://svnweb.freebsd.org/changeset/base/310950 Log: MIB-II: use strlcpy when copying interface names to .ifr_name .ifra_name is assumed to be NUL terminated; using strlcpy(3) ensures that it's indeed NUL terminated wh

svn commit: r310952 - head/contrib/bsnmp/snmp_mibII

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 12:03:25 2016 New Revision: 310952 URL: https://svnweb.freebsd.org/changeset/base/310952 Log: MIB-II: use strlcpy instead of strcpy when copying {descr,name} This is of course to avoid buffer overruns The remaining strcpy instance in the module needs to be

svn commit: r310954 - head/usr.sbin/bsnmpd/tools/libbsnmptools

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 12:14:25 2016 New Revision: 310954 URL: https://svnweb.freebsd.org/changeset/base/310954 Log: Set value->v.octetstring.len to a correct value on malloc success/failure The previous code always set value->v.octetstring.len to len, regardless of the result from

svn commit: r310957 - head/contrib/bsnmp/snmpd

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 12:18:17 2016 New Revision: 310957 URL: https://svnweb.freebsd.org/changeset/base/310957 Log: Use strlcpy when copying `com` to pdu->community to avoid potential buffer overruns MFC after:1 week Reported by: Coverity CID: 1006823, 1006824 M

svn commit: r310958 - head/contrib/bsnmp/snmpd

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 12:30:14 2016 New Revision: 310958 URL: https://svnweb.freebsd.org/changeset/base/310958 Log: Initialize ret to SNMPD_INPUT_OK at the top of snmp_input_start(..) to avoid returning an uninitialized value There are some really complicated, snakey if-statements

svn commit: r310960 - head/contrib/bsnmp/snmpd

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 12:37:53 2016 New Revision: 310960 URL: https://svnweb.freebsd.org/changeset/base/310960 Log: Similar to r310954, set .len to 0 on malloc failure and to `len` only on success MFC after:1 week Modified: head/contrib/bsnmp/snmpd/export.c Modified: head/

svn commit: r310961 - head/sbin/sysctl

2016-12-31 Thread Andriy Voskoboinyk
Author: avos Date: Sat Dec 31 12:39:15 2016 New Revision: 310961 URL: https://svnweb.freebsd.org/changeset/base/310961 Log: sysctl(8): fix typename for uint32_t. MFC after:5 days. Modified: head/sbin/sysctl/sysctl.c Modified: head/sbin/sysctl/sysctl.c ===

svn commit: r310963 - in head: . sys/sys

2016-12-31 Thread Baptiste Daroussin
Author: bapt Date: Sat Dec 31 12:41:42 2016 New Revision: 310963 URL: https://svnweb.freebsd.org/changeset/base/310963 Log: Bump copyright year. Happy New Year 2017! Modified: head/COPYRIGHT head/sys/sys/copyright.h Modified: head/COPYRIGHT

svn commit: r310972 - head/sys/boot/fdt/dts/arm

2016-12-31 Thread Jared McNeill
Author: jmcneill Date: Sat Dec 31 13:10:06 2016 New Revision: 310972 URL: https://svnweb.freebsd.org/changeset/base/310972 Log: Fix a typo in the third address of the reg property for the usbphy node. MFC after:1 week Modified: head/sys/boot/fdt/dts/arm/a83t.dtsi Modified: head/sys/

svn commit: r310974 - head/usr.sbin/syslogd

2016-12-31 Thread Hiroki Sato
Author: hrs Date: Sat Dec 31 13:15:52 2016 New Revision: 310974 URL: https://svnweb.freebsd.org/changeset/base/310974 Log: - Use more descriptive names for variables. - Set O_CLOEXEC to the signal pipe and /dev/klog. - Use a single signal handler to catch both SIGHUP and SIGCHLD. - Fix a b

svn commit: r310976 - head/lib/libc/locale

2016-12-31 Thread Pedro F. Giffuni
Author: pfg Date: Sat Dec 31 15:30:00 2016 New Revision: 310976 URL: https://svnweb.freebsd.org/changeset/base/310976 Log: Move __hidden attribute towards the end of the declaration. Apple had them at the start but moving them to the end is better for faster reading and fits better what i

svn commit: r310977 - head/sys/sys

2016-12-31 Thread Pedro F. Giffuni
Author: pfg Date: Sat Dec 31 15:58:15 2016 New Revision: 310977 URL: https://svnweb.freebsd.org/changeset/base/310977 Log: Addition of clang nullability qualifiers. Add two new qualifiers for use by the static checkers: _Nonnull The _Nonnull nullability qualifier indicates that null

svn commit: r310982 - head/sys/vm

2016-12-31 Thread Konstantin Belousov
Author: kib Date: Sat Dec 31 19:30:22 2016 New Revision: 310982 URL: https://svnweb.freebsd.org/changeset/base/310982 Log: Ansify vm/vm_pager.c. Style. Reviewed by: alc Sponsored by: The FreeBSD Foundation MFC after:1 week Modified: head/sys/vm/vm_pager.c Modified: head/sys/vm

svn commit: r310983 - head/sys/kern

2016-12-31 Thread Mateusz Guzik
Author: mjg Date: Sat Dec 31 19:59:31 2016 New Revision: 310983 URL: https://svnweb.freebsd.org/changeset/base/310983 Log: vfs: switch nodes_created, recycles_count and free_owe_inact to counter(9) Reviewed by: kib Modified: head/sys/kern/vfs_subr.c Modified: head/sys/kern/vfs_subr.c =

svn commit: r310984 - head/lib/libc/net

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 21:00:08 2016 New Revision: 310984 URL: https://svnweb.freebsd.org/changeset/base/310984 Log: Use calloc instead of malloc + memset(.., 0, ..) MFC after:1 week Modified: head/lib/libc/net/getaddrinfo.c Modified: head/lib/libc/net/getaddrinfo.c =

svn commit: r310985 - head

2016-12-31 Thread Alan Somers
Author: asomers Date: Sat Dec 31 21:31:58 2016 New Revision: 310985 URL: https://svnweb.freebsd.org/changeset/base/310985 Log: Update ObsoleteFiles.inc for r310803 MFC after:26 days X-MFC-with: 310803 Modified: head/ObsoleteFiles.inc Modified: head/ObsoleteFiles.inc

Re: svn commit: r310984 - head/lib/libc/net

2016-12-31 Thread Pedro Giffuni
On 12/31/16 16:00, Ngie Cooper wrote: Author: ngie Date: Sat Dec 31 21:00:08 2016 New Revision: 310984 URL: https://svnweb.freebsd.org/changeset/base/310984 Log: Use calloc instead of malloc + memset(.., 0, ..) MFC after:1 week Modified: head/lib/libc/net/getaddrinfo.c Modified: h

Re: svn commit: r310984 - head/lib/libc/net

2016-12-31 Thread Ngie Cooper (yaneurabeya)
> On Dec 31, 2016, at 13:49, Pedro Giffuni wrote: > > > > On 12/31/16 16:00, Ngie Cooper wrote: >> Author: ngie >> Date: Sat Dec 31 21:00:08 2016 >> New Revision: 310984 >> URL: https://svnweb.freebsd.org/changeset/base/310984 >> >> Log: >> Use calloc instead of malloc + memset(.., 0, ..) >>

svn commit: r310986 - head/usr.sbin/bsnmpd/tools/libbsnmptools

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 22:18:33 2016 New Revision: 310986 URL: https://svnweb.freebsd.org/changeset/base/310986 Log: snmp_output_resp: style(9): sort variables by alignment MFC after:3 days Modified: head/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c Modified: head/usr.sbi

svn commit: r310987 - head/usr.sbin/bsnmpd/tools/libbsnmptools

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 22:46:17 2016 New Revision: 310987 URL: https://svnweb.freebsd.org/changeset/base/310987 Log: snmp_output_err_resp, snmp_output_resp: allocate `object` using calloc, not on the stack Some of the callers try to determine whether or not `object` is valid by t

svn commit: r310988 - head/contrib/bsnmp/lib

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sat Dec 31 23:20:57 2016 New Revision: 310988 URL: https://svnweb.freebsd.org/changeset/base/310988 Log: snmp_discover_engine: fix up req/resp (PDU object) handling a bit - Call snmp_pdu_free on req and resp when done with the objects - Call snmp_pdu_free on req before

svn commit: r310989 - head/usr.sbin/bsnmpd/tools/bsnmptools

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sun Jan 1 00:23:43 2017 New Revision: 310989 URL: https://svnweb.freebsd.org/changeset/base/310989 Log: Call snmp_pdu_free on req/resp with a consistent, correct pattern - snmp_pdu_free should be called before snmp_pdu_create is called again - snmp_pdu_free should

svn commit: r310994 - head/tests/sys/vfs

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sun Jan 1 04:01:27 2017 New Revision: 310994 URL: https://svnweb.freebsd.org/changeset/base/310994 Log: Make sys/vfs/lookup_cap_dotdot actually work with "kyua test" The tests don't work when reading/writing to file descriptors in the sandbox after entering capability

svn commit: r310995 - head/tests/sys/vfs

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sun Jan 1 04:02:06 2017 New Revision: 310995 URL: https://svnweb.freebsd.org/changeset/base/310995 Log: Bump WARNS to 6 to catch simple QA issues like some of the ones I squashed in r310994 Modified: head/tests/sys/vfs/Makefile Modified: head/tests/sys/vfs/Makefile

svn commit: r310996 - head/lib/libarchive/tests

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sun Jan 1 04:13:24 2017 New Revision: 310996 URL: https://svnweb.freebsd.org/changeset/base/310996 Log: Look for list.h in ${.CURDIR} to unbreak the build with a ports-based copy of llvm38 on ^/stable/11 (oh, the bugs you find when you set CC,CXX,CPP manually and it skips

svn commit: r310999 - head/contrib/bsnmp/lib

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sun Jan 1 05:13:54 2017 New Revision: 310999 URL: https://svnweb.freebsd.org/changeset/base/310999 Log: bsnmpclient(3) also documents snmp_client_init, snmp_client_set_host, and snmp_client_set_port. Add them to the NAME section MFC after:3 days Modified: head/c

svn commit: r311000 - head/contrib/bsnmp/lib

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sun Jan 1 05:14:58 2017 New Revision: 311000 URL: https://svnweb.freebsd.org/changeset/base/311000 Log: Fix spelling errors MFC after:3 days Reported by: igor Modified: head/contrib/bsnmp/lib/bsnmpclient.3 Modified: head/contrib/bsnmp/lib/bsnmpclient.3 ===

svn commit: r311001 - head/contrib/bsnmp/lib

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sun Jan 1 05:16:24 2017 New Revision: 311001 URL: https://svnweb.freebsd.org/changeset/base/311001 Log: Bump .Dd for the spelling and .Nm updates MFC after:3 days Modified: head/contrib/bsnmp/lib/bsnmpclient.3 Modified: head/contrib/bsnmp/lib/bsnmpclient.3 ==

svn commit: r311002 - in head: lib/libbsnmp/libbsnmp tools/build/mk

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sun Jan 1 05:21:08 2017 New Revision: 311002 URL: https://svnweb.freebsd.org/changeset/base/311002 Log: Install bsnmpclient(3) as snmp_client_{init,set_host,set_port}(3) MFC after:3 days X-MFC with: r310999 Modified: head/lib/libbsnmp/libbsnmp/Makefile head/

svn commit: r311003 - head/contrib/bsnmp/lib

2016-12-31 Thread Ngie Cooper
Author: ngie Date: Sun Jan 1 05:23:01 2017 New Revision: 311003 URL: https://svnweb.freebsd.org/changeset/base/311003 Log: Fix spelling errors; bump .Dd for the change MFC after:3 days Modified: head/contrib/bsnmp/lib/bsnmplib.3 Modified: head/contrib/bsnmp/lib/bsnmplib.3 =