Author: ngie
Date: Sat Dec 31 21:00:08 2016
New Revision: 310984
URL: https://svnweb.freebsd.org/changeset/base/310984

Log:
  Use calloc instead of malloc + memset(.., 0, ..)
  
  MFC after:    1 week

Modified:
  head/lib/libc/net/getaddrinfo.c

Modified: head/lib/libc/net/getaddrinfo.c
==============================================================================
--- head/lib/libc/net/getaddrinfo.c     Sat Dec 31 19:59:31 2016        
(r310983)
+++ head/lib/libc/net/getaddrinfo.c     Sat Dec 31 21:00:08 2016        
(r310984)
@@ -691,9 +691,8 @@ reorder(struct addrinfo *sentinel)
                return(n);
 
        /* allocate a temporary array for sort and initialization of it. */
-       if ((aio = malloc(sizeof(*aio) * n)) == NULL)
+       if ((aio = calloc(1, sizeof(*aio) * n)) == NULL)
                return(n);      /* give up reordering */
-       memset(aio, 0, sizeof(*aio) * n);
 
        /* retrieve address selection policy from the kernel */
        TAILQ_INIT(&policyhead);
@@ -1449,9 +1448,8 @@ copy_ai(const struct addrinfo *pai)
        size_t l;
 
        l = sizeof(*ai) + pai->ai_addrlen;
-       if ((ai = (struct addrinfo *)malloc(l)) == NULL)
+       if ((ai = calloc(1, l)) == NULL)
                return NULL;
-       memset(ai, 0, l);
        memcpy(ai, pai, sizeof(*ai));
        ai->ai_addr = (struct sockaddr *)(void *)(ai + 1);
        memcpy(ai->ai_addr, pai->ai_addr, pai->ai_addrlen);
@@ -1874,8 +1872,7 @@ addrinfo_unmarshal_func(char *buffer, si
                size = new_ai.ai_addrlen + sizeof(struct addrinfo) +
                        _ALIGNBYTES;
 
-               sentinel = (struct addrinfo *)malloc(size);
-               memset(sentinel, 0, size);
+               sentinel = calloc(1, size);
 
                memcpy(sentinel, &new_ai, sizeof(struct addrinfo));
                sentinel->ai_addr = (struct sockaddr *)_ALIGN((char *)sentinel +
@@ -1888,8 +1885,7 @@ addrinfo_unmarshal_func(char *buffer, si
                        memcpy(&size, p, sizeof(size_t));
                        p += sizeof(size_t);
 
-                       sentinel->ai_canonname = (char *)malloc(size + 1);
-                       memset(sentinel->ai_canonname, 0, size + 1);
+                       sentinel->ai_canonname = calloc(1, size + 1);
 
                        memcpy(sentinel->ai_canonname, p, size);
                        p += size;
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to