Re: svn commit: r244112 - head/sys/kern

2012-12-16 Thread Alfred Perlstein
On 12/15/12 11:45 PM, Andriy Gapon wrote: on 16/12/2012 07:00 Ian Lepore said the following: The question here isn't whether aborting or continuing beyond that point is a good idea. Some developer already made that choice by coding a KASSERT() instead of a panic(). The developer decided that a

Re: svn commit: r244112 - head/sys/kern

2012-12-16 Thread Andriy Gapon
on 16/12/2012 10:06 Alfred Perlstein said the following: > On 12/15/12 11:45 PM, Andriy Gapon wrote: >> on 16/12/2012 07:00 Ian Lepore said the following: >>> Some developer already made that choice by coding a >>> KASSERT() instead of a panic(). >> Please don't perpetuate this argument. The poin

Re: svn commit: r244271 - head/usr.sbin/iostat

2012-12-16 Thread Mikolaj Golub
On Sat, Dec 15, 2012 at 05:00:39PM -0800, Adrian Chadd wrote: > Hi, > > People may have scripts based on the current output. > > You should have introduced a new parameter which modifies the output > behaviour in the way you wanted, rather than modifying the existing > behaviour. > > Please cons

Re: svn commit: r243515 - head/sys/kern

2012-12-16 Thread Andriy Gapon
on 13/12/2012 22:17 Attilio Rao said the following: > Right, but as I said, for the time being we can at least have a > correct panic() semantic and take the right time to fix the > generic_stop_cpus() and then absorb also the panic() fix into it. > Right now the mechanism is still broken in panic

svn commit: r244288 - head/sys/kern

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 13:56:38 2012 New Revision: 244288 URL: http://svnweb.freebsd.org/changeset/base/244288 Log: Use 'cred' variable. Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c ==

svn commit: r244293 - head/sys/kern

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 14:14:18 2012 New Revision: 244293 URL: http://svnweb.freebsd.org/changeset/base/244293 Log: Make the check easier to read. Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c

svn commit: r244294 - head/sys/kern

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 14:24:59 2012 New Revision: 244294 URL: http://svnweb.freebsd.org/changeset/base/244294 Log: Don't add audit record when coredumps are disabled or name cannot be expanded. Discussed with: rwatson Obtained from:WHEEL Systems Modified: head/sys/

svn commit: r244295 - head/sbin/growfs

2012-12-16 Thread Edward Tomasz Napierala
Author: trasz Date: Sun Dec 16 14:37:25 2012 New Revision: 244295 URL: http://svnweb.freebsd.org/changeset/base/244295 Log: When growing a filesystem, don't leave unused space at the end if there is not enough room for a full cylinder group. Reviewed by: mckusick@ Modified: head/sbin/

svn commit: r244296 - head/sys/kern

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 14:53:27 2012 New Revision: 244296 URL: http://svnweb.freebsd.org/changeset/base/244296 Log: Move expand_name() after process lock is released. This fixed panic where we hold mutex (process lock) and try to obtain sleepable lock (vnode lock in expand_name()).

Re: svn commit: r244112 - head/sys/kern

2012-12-16 Thread Adrian Chadd
On 15 December 2012 23:45, Andriy Gapon wrote: > on 16/12/2012 07:00 Ian Lepore said the following: >> The question here isn't whether aborting or continuing beyond that point >> is a good idea. Some developer already made that choice by coding a >> KASSERT() instead of a panic(). The developer

Re: svn commit: r243515 - head/sys/kern

2012-12-16 Thread Attilio Rao
On Sun, Dec 16, 2012 at 1:59 AM, Andriy Gapon wrote: > on 13/12/2012 22:17 Attilio Rao said the following: >> Right, but as I said, for the time being we can at least have a >> correct panic() semantic and take the right time to fix the >> generic_stop_cpus() and then absorb also the panic() fix i

Re: svn commit: r243515 - head/sys/kern

2012-12-16 Thread Andriy Gapon
on 16/12/2012 20:49 Attilio Rao said the following: > - about panic(), the check is much more easy, just see my first > response to Ryan, because we don't have the wakeup/restart race as > generic_stop_cpu() does That's what I meant - could you please resend that message to me? -- Andriy Gapon _

svn commit: r244307 - head/sys/boot/sparc64/boot1

2012-12-16 Thread Marius Strobl
Author: marius Date: Sun Dec 16 20:43:29 2012 New Revision: 244307 URL: http://svnweb.freebsd.org/changeset/base/244307 Log: Restore pre-r234898 printing of boot loader and path. MFC after:3 days Modified: head/sys/boot/sparc64/boot1/boot1.c Modified: head/sys/boot/sparc64/boot1/boo

svn commit: r244308 - head/sys/sparc64/conf

2012-12-16 Thread Marius Strobl
Author: marius Date: Sun Dec 16 20:54:07 2012 New Revision: 244308 URL: http://svnweb.freebsd.org/changeset/base/244308 Log: Revert r237842 and switch back to SCHED_ULE. All problems I encountered with the latter have been fixed with r241780. MFC after:3 days Modified: head/sys/spa

svn commit: r244316 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 22:59:25 2012 New Revision: 244316 URL: http://svnweb.freebsd.org/changeset/base/244316 Log: Prefer snprintf() over sprintf(). Obtained from:WHEEL Systems Modified: head/sbin/savecore/savecore.c Modified: head/sbin/savecore/savecore.c ===

svn commit: r244317 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 22:59:58 2012 New Revision: 244317 URL: http://svnweb.freebsd.org/changeset/base/244317 Log: Sort flags properly. Obtained from:WHEEL Systems Modified: head/sbin/savecore/savecore.c Modified: head/sbin/savecore/savecore.c

svn commit: r244318 - in head: sbin/setkey usr.sbin/ndp

2012-12-16 Thread Eitan Adler
Author: eadler Date: Sun Dec 16 23:00:13 2012 New Revision: 244318 URL: http://svnweb.freebsd.org/changeset/base/244318 Log: Minor wording improvments to some manual pages Approved by: bcr (mentor) Obtained from:DragonflyBSD (a5294ca835317c68c919ab43936da4f05ab6e926) MFC after:

svn commit: r244319 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 23:04:31 2012 New Revision: 244319 URL: http://svnweb.freebsd.org/changeset/base/244319 Log: Make use of the fact that we changed working directory to the dump directory earlier. Obtained from:WHEEL Systems Modified: head/sbin/savecore/savecore.c M

svn commit: r244320 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 23:06:12 2012 New Revision: 244320 URL: http://svnweb.freebsd.org/changeset/base/244320 Log: Implement -m option to savecore(8) that allows to limit number of kernel dumps stored. Once the limit is reached it restarts from 0. Reviewed by: avg Obtained from:

svn commit: r244321 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 23:09:27 2012 New Revision: 244321 URL: http://svnweb.freebsd.org/changeset/base/244321 Log: With rotating kernel dumps the higest dump number is not necessarily the last one. To make it easier to find the last one create symlinks with 'last' suffix that will poi

svn commit: r244323 - in head: . etc/defaults

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 23:29:56 2012 New Revision: 244323 URL: http://svnweb.freebsd.org/changeset/base/244323 Log: Use new savecore(8) option and limit number of kernel dumps that will be kept around to the 10 most recent ones. Add UPDATING entry with info how to return to the prev

Re: svn commit: r244112 - head/sys/kern

2012-12-16 Thread Navdeep Parhar
On Sun, Dec 16, 2012 at 09:23:13AM -0800, Adrian Chadd wrote: > On 15 December 2012 23:45, Andriy Gapon wrote: > > on 16/12/2012 07:00 Ian Lepore said the following: > >> The question here isn't whether aborting or continuing beyond that point > >> is a good idea. Some developer already made that

svn commit: r244325 - head/sbin/route

2012-12-16 Thread Hiroki Sato
Author: hrs Date: Sun Dec 16 23:46:59 2012 New Revision: 244325 URL: http://svnweb.freebsd.org/changeset/base/244325 Log: - Fix strtol() error handling. - Add a range condition of given FIB number and the related error messages. - Fix free() problem. Spotted by: Artyom Mirgorodskiy

svn commit: r244331 - head/usr.sbin/gssd

2012-12-16 Thread Rick Macklem
Author: rmacklem Date: Mon Dec 17 00:31:55 2012 New Revision: 244331 URL: http://svnweb.freebsd.org/changeset/base/244331 Log: Fix the gssd daemon so that it uses syslog() to report an error instead of calling err() when it is daemonized, so that the error gets logged. Discussed with:

svn commit: r244332 - head/sys/boot/i386/efi

2012-12-16 Thread Rui Paulo
Author: rpaulo Date: Mon Dec 17 00:34:07 2012 New Revision: 244332 URL: http://svnweb.freebsd.org/changeset/base/244332 Log: amd64 only has rela sections. Modified: head/sys/boot/i386/efi/ldscript.amd64 Modified: head/sys/boot/i386/efi/ldscript.amd64 =

Re: svn commit: r244112 - head/sys/kern

2012-12-16 Thread Adrian Chadd
On 16 December 2012 15:32, Navdeep Parhar wrote: >> The status quo _does not change_ by default. > > So now we have a knob that could be used to change the behaviour of all > the KASSERTs in the system; one that hints that it may be possible to > continue even if an assertion in the FreeBSD kern

svn commit: r244341 - head/sys/dev/ale

2012-12-16 Thread Pyun YongHyeon
Author: yongari Date: Mon Dec 17 06:01:57 2012 New Revision: 244341 URL: http://svnweb.freebsd.org/changeset/base/244341 Log: Make sure to stop both TX and RX MACs in ale_stop_mac(). Previously it used to stop TX MAC only such that MAC reconfiguration after getting a link didn't work as expe