Re: svn commit: r319295 - head/usr.bin/mkimg/tests

2017-06-01 Thread Ngie Cooper (yaneurabeya)
> On Jun 1, 2017, at 13:06, Alexey Dokuchaev wrote: > > On Thu, Jun 01, 2017 at 11:27:18AM -0700, Ngie Cooper (yaneurabeya) wrote: >> ... >> I vote for not checking in the SHAs. If something fails (as someone else >> mentioned on the lists), it's really hard to debug why it failed. > > Like I'v

Re: svn commit: r319295 - head/usr.bin/mkimg/tests

2017-06-01 Thread Alexey Dokuchaev
On Thu, Jun 01, 2017 at 11:27:18AM -0700, Ngie Cooper (yaneurabeya) wrote: > ... > I vote for not checking in the SHAs. If something fails (as someone else > mentioned on the lists), it's really hard to debug why it failed. Like I've said, it's not "really" hard. Check out previous version and ge

Re: svn commit: r319295 - head/usr.bin/mkimg/tests

2017-06-01 Thread Ngie Cooper (yaneurabeya)
> On Jun 1, 2017, at 10:16, Alexey Dokuchaev wrote: > > On Thu, Jun 01, 2017 at 09:58:38AM -0700, Simon J. Gerraty wrote: >> One option would be to store a sha256 hash of the result. >> If the image generated by the test hashes to the correct value - you >> pass. > > That should be preferred.

Re: svn commit: r319295 - head/usr.bin/mkimg/tests

2017-06-01 Thread Alexey Dokuchaev
On Thu, Jun 01, 2017 at 09:58:38AM -0700, Simon J. Gerraty wrote: > One option would be to store a sha256 hash of the result. > If the image generated by the test hashes to the correct value - you > pass. That should be preferred. Storing binary blobs in VCS is bad practice. > Of course if the t

Re: svn commit: r319295 - head/usr.bin/mkimg/tests

2017-06-01 Thread Simon J. Gerraty
Ngie Cooper (yaneurabeya) wrote: > > These should not be stored uuencoded. It serves no purpose other > > than bloating the repo and causing spammy commit mails like this one > > where we got a huge tail of garbage output. The tests appear to contain generated filesystem images. eg. img-1x1-512-

Re: svn commit: r319295 - head/usr.bin/mkimg/tests

2017-06-01 Thread Brooks Davis
On Thu, Jun 01, 2017 at 08:11:45AM -0700, Marcel Moolenaar wrote: > > > On May 31, 2017, at 11:06 PM, Ngie Cooper (yaneurabeya) > > wrote: > > > > > >> On May 31, 2017, at 10:03 PM, Brooks Davis wrote: > >> > >> On Wed, May 31, 2017 at 08:01:12AM +, Ngie Cooper wrote: > >>> Author: ngie

Re: svn commit: r319295 - head/usr.bin/mkimg/tests

2017-06-01 Thread Ngie Cooper
> On Jun 1, 2017, at 08:35, Marcel Moolenaar wrote: > > >> On Jun 1, 2017, at 8:32 AM, Alan Somers wrote: ... >> If the files are binary, then why not store them as binary files? > > A 100MB image, committed as binary file is 100MB of data. The hexdump -C > equivalent is often only a few hu

Re: svn commit: r319295 - head/usr.bin/mkimg/tests

2017-06-01 Thread Marcel Moolenaar
> On Jun 1, 2017, at 8:32 AM, Alan Somers wrote: > > On Thu, Jun 1, 2017 at 9:11 AM, Marcel Moolenaar wrote: >> >> On May 31, 2017, at 11:06 PM, Ngie Cooper (yaneurabeya) >> wrote: >> >> >> On May 31, 2017, at 10:03 PM, Brooks Davis wrote: >> >> On Wed, May 31, 2017 at 08:01:12AM +, N

Re: svn commit: r319295 - head/usr.bin/mkimg/tests

2017-06-01 Thread Alan Somers
On Thu, Jun 1, 2017 at 9:11 AM, Marcel Moolenaar wrote: > > On May 31, 2017, at 11:06 PM, Ngie Cooper (yaneurabeya) > wrote: > > > On May 31, 2017, at 10:03 PM, Brooks Davis wrote: > > On Wed, May 31, 2017 at 08:01:12AM +, Ngie Cooper wrote: > > Author: ngie > Date: Wed May 31 08:01:12 2017

Re: svn commit: r319295 - head/usr.bin/mkimg/tests

2017-06-01 Thread Marcel Moolenaar
> On May 31, 2017, at 11:06 PM, Ngie Cooper (yaneurabeya) > wrote: > > >> On May 31, 2017, at 10:03 PM, Brooks Davis wrote: >> >> On Wed, May 31, 2017 at 08:01:12AM +, Ngie Cooper wrote: >>> Author: ngie >>> Date: Wed May 31 08:01:12 2017 >>> New Revision: 319295 >>> URL: https://svnweb.

Re: svn commit: r319295 - head/usr.bin/mkimg/tests

2017-06-01 Thread Pedro Giffuni
On 06/01/17 01:06, Ngie Cooper (yaneurabeya) wrote: On May 31, 2017, at 10:03 PM, Brooks Davis wrote: On Wed, May 31, 2017 at 08:01:12AM +, Ngie Cooper wrote: Author: ngie Date: Wed May 31 08:01:12 2017 New Revision: 319295 URL: https://svnweb.freebsd.org/changeset/base/319295 Log: Up

Re: svn commit: r319295 - head/usr.bin/mkimg/tests

2017-06-01 Thread Ngie Cooper (yaneurabeya)
> On May 31, 2017, at 10:03 PM, Brooks Davis wrote: > > On Wed, May 31, 2017 at 08:01:12AM +, Ngie Cooper wrote: >> Author: ngie >> Date: Wed May 31 08:01:12 2017 >> New Revision: 319295 >> URL: https://svnweb.freebsd.org/changeset/base/319295 >> >> Log: >> Update the usr.bin/mkimg golden

Re: svn commit: r319295 - head/usr.bin/mkimg/tests

2017-05-31 Thread Brooks Davis
On Wed, May 31, 2017 at 08:01:12AM +, Ngie Cooper wrote: > Author: ngie > Date: Wed May 31 08:01:12 2017 > New Revision: 319295 > URL: https://svnweb.freebsd.org/changeset/base/319295 > > Log: > Update the usr.bin/mkimg golden test output files after ^/head@r319125 > > ^/head@r319125 ch

svn commit: r319295 - head/usr.bin/mkimg/tests

2017-05-31 Thread Ngie Cooper
Author: ngie Date: Wed May 31 08:01:12 2017 New Revision: 319295 URL: https://svnweb.freebsd.org/changeset/base/319295 Log: Update the usr.bin/mkimg golden test output files after ^/head@r319125 ^/head@r319125 changed the location of the backup pmbr, requiring the output files to be regen