> On Jun 1, 2017, at 13:06, Alexey Dokuchaev wrote:
>
> On Thu, Jun 01, 2017 at 11:27:18AM -0700, Ngie Cooper (yaneurabeya) wrote:
>> ...
>> I vote for not checking in the SHAs. If something fails (as someone else
>> mentioned on the lists), it's really hard to debug why it failed.
>
> Like I'v
On Thu, Jun 01, 2017 at 11:27:18AM -0700, Ngie Cooper (yaneurabeya) wrote:
> ...
> I vote for not checking in the SHAs. If something fails (as someone else
> mentioned on the lists), it's really hard to debug why it failed.
Like I've said, it's not "really" hard. Check out previous version and
ge
> On Jun 1, 2017, at 10:16, Alexey Dokuchaev wrote:
>
> On Thu, Jun 01, 2017 at 09:58:38AM -0700, Simon J. Gerraty wrote:
>> One option would be to store a sha256 hash of the result.
>> If the image generated by the test hashes to the correct value - you
>> pass.
>
> That should be preferred.
On Thu, Jun 01, 2017 at 09:58:38AM -0700, Simon J. Gerraty wrote:
> One option would be to store a sha256 hash of the result.
> If the image generated by the test hashes to the correct value - you
> pass.
That should be preferred. Storing binary blobs in VCS is bad practice.
> Of course if the t
Ngie Cooper (yaneurabeya) wrote:
> > These should not be stored uuencoded. It serves no purpose other
> > than bloating the repo and causing spammy commit mails like this one
> > where we got a huge tail of garbage output.
The tests appear to contain generated filesystem images.
eg. img-1x1-512-
On Thu, Jun 01, 2017 at 08:11:45AM -0700, Marcel Moolenaar wrote:
>
> > On May 31, 2017, at 11:06 PM, Ngie Cooper (yaneurabeya)
> > wrote:
> >
> >
> >> On May 31, 2017, at 10:03 PM, Brooks Davis wrote:
> >>
> >> On Wed, May 31, 2017 at 08:01:12AM +, Ngie Cooper wrote:
> >>> Author: ngie
> On Jun 1, 2017, at 08:35, Marcel Moolenaar wrote:
>
>
>> On Jun 1, 2017, at 8:32 AM, Alan Somers wrote:
...
>> If the files are binary, then why not store them as binary files?
>
> A 100MB image, committed as binary file is 100MB of data. The hexdump -C
> equivalent is often only a few hu
> On Jun 1, 2017, at 8:32 AM, Alan Somers wrote:
>
> On Thu, Jun 1, 2017 at 9:11 AM, Marcel Moolenaar wrote:
>>
>> On May 31, 2017, at 11:06 PM, Ngie Cooper (yaneurabeya)
>> wrote:
>>
>>
>> On May 31, 2017, at 10:03 PM, Brooks Davis wrote:
>>
>> On Wed, May 31, 2017 at 08:01:12AM +, N
On Thu, Jun 1, 2017 at 9:11 AM, Marcel Moolenaar wrote:
>
> On May 31, 2017, at 11:06 PM, Ngie Cooper (yaneurabeya)
> wrote:
>
>
> On May 31, 2017, at 10:03 PM, Brooks Davis wrote:
>
> On Wed, May 31, 2017 at 08:01:12AM +, Ngie Cooper wrote:
>
> Author: ngie
> Date: Wed May 31 08:01:12 2017
> On May 31, 2017, at 11:06 PM, Ngie Cooper (yaneurabeya)
> wrote:
>
>
>> On May 31, 2017, at 10:03 PM, Brooks Davis wrote:
>>
>> On Wed, May 31, 2017 at 08:01:12AM +, Ngie Cooper wrote:
>>> Author: ngie
>>> Date: Wed May 31 08:01:12 2017
>>> New Revision: 319295
>>> URL: https://svnweb.
On 06/01/17 01:06, Ngie Cooper (yaneurabeya) wrote:
On May 31, 2017, at 10:03 PM, Brooks Davis wrote:
On Wed, May 31, 2017 at 08:01:12AM +, Ngie Cooper wrote:
Author: ngie
Date: Wed May 31 08:01:12 2017
New Revision: 319295
URL: https://svnweb.freebsd.org/changeset/base/319295
Log:
Up
> On May 31, 2017, at 10:03 PM, Brooks Davis wrote:
>
> On Wed, May 31, 2017 at 08:01:12AM +, Ngie Cooper wrote:
>> Author: ngie
>> Date: Wed May 31 08:01:12 2017
>> New Revision: 319295
>> URL: https://svnweb.freebsd.org/changeset/base/319295
>>
>> Log:
>> Update the usr.bin/mkimg golden
On Wed, May 31, 2017 at 08:01:12AM +, Ngie Cooper wrote:
> Author: ngie
> Date: Wed May 31 08:01:12 2017
> New Revision: 319295
> URL: https://svnweb.freebsd.org/changeset/base/319295
>
> Log:
> Update the usr.bin/mkimg golden test output files after ^/head@r319125
>
> ^/head@r319125 ch
Author: ngie
Date: Wed May 31 08:01:12 2017
New Revision: 319295
URL: https://svnweb.freebsd.org/changeset/base/319295
Log:
Update the usr.bin/mkimg golden test output files after ^/head@r319125
^/head@r319125 changed the location of the backup pmbr, requiring the
output files to be regen
14 matches
Mail list logo