[snip everything]
uugh.
Someone please solve this by writing ETHER_ADDR_COMPARE() so it can be
overridden per architecture.
:)
I committed Ryan's work. If someone has a better thingy, please do
feel free to review and commit the thingy. :-P
-adrian
(woo, first bikeshed in a while
On Mon, 8 Aug 2016, Bruce Simpson wrote:
On 07/08/16 20:23, Peter Jeremy wrote:
On 08/07/16 05:48, Adrian Chadd wrote:
+#defineETHER_IS_BROADCAST(addr) \
...
IMHO, Adrian's code is clearer and micro-optimisations like this belong
in the complier, not the code.
Both are unclear micr
On 07/08/16 20:23, Peter Jeremy wrote:
On 08/07/16 05:48, Adrian Chadd wrote:
+#defineETHER_IS_BROADCAST(addr) \
...
IMHO, Adrian's code is clearer and micro-optimisations like this belong
in the complier, not the code.
*cough* *cough* 2007 wants its patch back.
https://people.freeb
On 2016-Aug-07 11:03:23 +0200, Hans Petter Selasky wrote:
>On 08/07/16 05:48, Adrian Chadd wrote:
>> +#define ETHER_IS_BROADCAST(addr) \
>> +(((addr)[0] & (addr)[1] & (addr)[2] & \
>> + (addr)[3] & (addr)[4] & (addr)[5]) == 0xff)
>>
>The compiler might be able to produce more optimal
On 08/07/16 05:48, Adrian Chadd wrote:
Author: adrian
Date: Sun Aug 7 03:48:33 2016
New Revision: 303811
URL: https://svnweb.freebsd.org/changeset/base/303811
Log:
Extract out the various local definitions of ETHER_IS_BROADCAST() and
turn them into a shared definition.
Set M_MCAST/M_BCAS
Author: adrian
Date: Sun Aug 7 03:48:33 2016
New Revision: 303811
URL: https://svnweb.freebsd.org/changeset/base/303811
Log:
Extract out the various local definitions of ETHER_IS_BROADCAST() and
turn them into a shared definition.
Set M_MCAST/M_BCAST appropriately upon packet reception i
