On 07/08/16 20:23, Peter Jeremy wrote:
On 08/07/16 05:48, Adrian Chadd wrote:
+#define        ETHER_IS_BROADCAST(addr) \
...
IMHO, Adrian's code is clearer and micro-optimisations like this belong
in the complier, not the code.

*cough* *cough* 2007 wants its patch back.

https://people.freebsd.org/~bms/dump/old/latest-8021p.diff

The whole point of using bcmp() was to allow it to be inlined by the compiler for the target arch, rather than forcing it to play guessing games with (lowest-common-denominator machine-word-size) integer accesses.

ETHER_IS_MULTICAST(), by contrast, only needs to check a single bit in the 48-bit MAC.
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to