Re: svn commit: r296970 - head/lib/libxo/tests

2016-03-19 Thread Simon J. Gerraty
NGie Cooper wrote: > > SUBDIR+=encoder > > > > +.if ${MACHINE} == "host" > > +# make it easy to test without install > > +TESTSDIR=${.OBJDIR} > > +CFLAGS+=-I${.CURDIR:H} > > +.endif > > + > > .include > > This commit seems unnecessary -- have you tried make check yet? That appears

Re: svn commit: r296970 - head/lib/libxo/tests

2016-03-19 Thread Simon J. Gerraty
Bryan Drewery wrote: > Btw I recently hooked up MK_TESTS to DIRDEPS_BUILD and added them all > (at the time) to targets/. Hmm how did you do that? In our build local.dirdeps.mk checks each DEP_RELDIR to see if there is a tests/Makefile.depend.host below it, and if so adds it to the dependency gr

svn commit: r296970 - head/lib/libxo/tests

2016-03-19 Thread Simon J. Gerraty
Author: sjg Date: Thu Mar 17 00:37:04 2016 New Revision: 296970 URL: https://svnweb.freebsd.org/changeset/base/296970 Log: We need libutil and make it feasible to at least build the tests in situ Modified: head/lib/libxo/tests/Makefile Modified: head/lib/libxo/tests/Makefile ===

Re: svn commit: r296970 - head/lib/libxo/tests

2016-03-19 Thread Bryan Drewery
On 3/16/16 9:04 PM, Simon J. Gerraty wrote: > NGie Cooper wrote: >>> SUBDIR+=encoder >>> >>> +.if ${MACHINE} == "host" >>> +# make it easy to test without install >>> +TESTSDIR=${.OBJDIR} >>> +CFLAGS+=-I${.CURDIR:H} >>> +.endif >>> + >>> .include >> >> This commit seems unnecessary --

Re: svn commit: r296970 - head/lib/libxo/tests

2016-03-18 Thread NGie Cooper
> On Mar 16, 2016, at 17:37, Simon J. Gerraty wrote: > > Author: sjg > Date: Thu Mar 17 00:37:04 2016 > New Revision: 296970 > URL: https://svnweb.freebsd.org/changeset/base/296970 > > Log: > We need libutil > > and make it feasible to at least build the tests in situ > > Modified: > head/