On 3/16/16 9:04 PM, Simon J. Gerraty wrote:
> NGie Cooper <yaneurab...@gmail.com> wrote:
>>> SUBDIR+= encoder
>>>
>>> +.if ${MACHINE} == "host"
>>> +# make it easy to test without install
>>> +TESTSDIR= ${.OBJDIR}
>>> +CFLAGS+= -I${.CURDIR:H}
>>> +.endif
>>> +
>>> .include <bsd.test.mk>
>>
>> This commit seems unnecessary -- have you tried make check yet?
>
> That appears to require installing things before you test that they
> work - seems a bit backwards?
>
> Note the above is only relevant when building with DIRDEPS.
> Where we want to be able to build and run relevant tests as part of the
> build as we go - when MACHINE = "host" that is.
>
> Phil wants to fix this so that it runs all his test suite properly and
> also need to arrange to auto-update the makefile here as new tests are
> added to the distribution.
> Probably need somthing like bmake's after-import target.
>
> Anyway, being able to have this work in context of DIRDEPS_BUILD will
> help (I haven't added the MK_TESTS hooks yet).
>
>
Btw I recently hooked up MK_TESTS to DIRDEPS_BUILD and added them all
(at the time) to targets/.
--
Regards,
Bryan Drewery
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
