On Fri, Feb 27, 2015 at 12:52 PM, Benjamin Kaduk wrote:
> On Fri, 27 Feb 2015, Ian Lepore wrote:
>
>> I wonder if it would be useful to have the system itself mail the
>> summary line of every new review that's created to some list? It would
>> probably need to be several lists -- I sure don't wa
On Fri, 27 Feb 2015, Ian Lepore wrote:
> I wonder if it would be useful to have the system itself mail the
> summary line of every new review that's created to some list? It would
> probably need to be several lists -- I sure don't want to see every
> ports phab that gets created, but getting a s
https://reviews.freebsd.org/D1981
contains the fix. Please continue the conversation there. I believe I
fixed everything, including a bug in the original code.
Warner
> On Feb 27, 2015, at 8:56 AM, Ian Lepore wrote:
>
> On Fri, 2015-02-27 at 08:46 -0700, Warner Losh wrote:
>> Sure wish my co
On Fri, 2015-02-27 at 08:46 -0700, Warner Losh wrote:
> Sure wish my code review got this much love…
>
> Warner
>
IMO, the biggest problem with phab reviews is advertising them. You can
guess who might be interested and add them as reviewers. You can try
posting a summary and the url to some m
Sure wish my code review got this much love…
Warner
> On Feb 27, 2015, at 8:30 AM, Ed Maste wrote:
>
> On 27 February 2015 at 10:12, Benjamin Kaduk wrote:
>>
>> As of r278229, the kernel is compiled with -fwrapv, so signed integer
>> overflow in the FreeBSD kernel is defined behavior.
>
> Th
On 27 February 2015 at 10:12, Benjamin Kaduk wrote:
>
> As of r278229, the kernel is compiled with -fwrapv, so signed integer
> overflow in the FreeBSD kernel is defined behavior.
This is primarily a workaround to accommodate existing code though;
it's not a result of an explicit decision that we
On Fri, Feb 27, 2015 at 4:56 AM, Bruce Evans wrote:
> On Fri, 27 Feb 2015, Andrew Turner wrote:
>
> On Fri, 27 Feb 2015 02:56:59 + (UTC)
>> Warner Losh wrote:
>> ...
>>
>>>
>>> Didn't we recently have issues with signed integer overflow being
>> undefined? Even though we worked around it wi
On Fri, 27 Feb 2015, Andrew Turner wrote:
On Fri, 27 Feb 2015 02:56:59 + (UTC)
Warner Losh wrote:
...
/*
+ * We need some randomness. Implement the classic Linear Congruential
+ * generator X_{n+1}=(aX_n+c) mod m. These values are optimized for
+ * m = 2^32, a = 69069 and c = 5. This is s
On Fri, 27 Feb 2015 02:56:59 + (UTC)
Warner Losh wrote:
...
> /*
> + * We need some randomness. Implement the classic Linear Congruential
> + * generator X_{n+1}=(aX_n+c) mod m. These values are optimized for
> + * m = 2^32, a = 69069 and c = 5. This is signed so that we can get
> + * both po
Author: imp
Date: Fri Feb 27 02:56:58 2015
New Revision: 279349
URL: https://svnweb.freebsd.org/changeset/base/279349
Log:
Create sched_rand() and move the LCG code into that. Call this when
we need randomness in ULE. This removes random() call from the
rebalance interval code.
Submitte
10 matches
Mail list logo
