https://reviews.freebsd.org/D1981
contains the fix. Please continue the conversation there. I believe I fixed everything, including a bug in the original code. Warner > On Feb 27, 2015, at 8:56 AM, Ian Lepore <i...@freebsd.org> wrote: > > On Fri, 2015-02-27 at 08:46 -0700, Warner Losh wrote: >> Sure wish my code review got this much love… >> >> Warner >> > > IMO, the biggest problem with phab reviews is advertising them. You can > guess who might be interested and add them as reviewers. You can try > posting a summary and the url to some mailing list. > > I wonder if it would be useful to have the system itself mail the > summary line of every new review that's created to some list? It would > probably need to be several lists -- I sure don't want to see every > ports phab that gets created, but getting a single mail for every src > review created wouldn't be too much. > > I don't know if that's a good idea or not, but the reason we reliably > get post-commit reviews is because the changes reliably appear in front > of everyone's eyes at that point. > > -- Ian > > >>> On Feb 27, 2015, at 8:30 AM, Ed Maste <ema...@freebsd.org> wrote: >>> >>> On 27 February 2015 at 10:12, Benjamin Kaduk <bjkf...@gmail.com> wrote: >>>> >>>> As of r278229, the kernel is compiled with -fwrapv, so signed integer >>>> overflow in the FreeBSD kernel is defined behavior. >>> >>> This is primarily a workaround to accommodate existing code though; >>> it's not a result of an explicit decision that we want to support >>> signed integer overflow. >>> >>> -Ed >>> >> > >
signature.asc
Description: Message signed with OpenPGP using GPGMail
