On Fri, 2014-10-31 at 14:30 -0700, Garrett Cooper wrote:
> On Oct 28, 2014, at 4:33, Bruce Evans wrote:
>
> > On Tue, 28 Oct 2014, [utf-8] Dag-Erling Smørgrav wrote:
> >
> >> Bruce Evans writes:
> >>> Dag-Erling Smørgrav writes:
> This is a bug on all platforms, and both clang and (recent
Garrett Cooper wrote this message on Fri, Oct 31, 2014 at 14:30 -0700:
> On Oct 28, 2014, at 4:33, Bruce Evans wrote:
>
> > On Tue, 28 Oct 2014, [utf-8] Dag-Erling Smørgrav wrote:
> >
> >> Bruce Evans writes:
> >>> Dag-Erling Smørgrav writes:
> This is a bug on all platforms, and both cla
On Oct 28, 2014, at 4:33, Bruce Evans wrote:
> On Tue, 28 Oct 2014, [utf-8] Dag-Erling Smørgrav wrote:
>
>> Bruce Evans writes:
>>> Dag-Erling Smørgrav writes:
This is a bug on all platforms, and both clang and (recent) gcc
should complain about it. That printf() call will print gar
On Wed, Oct 29, 2014 at 1:08 PM, Kurt Jaeger wrote:
> Hi!
>
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191263
>
>> Right now the submitter tests on 32bit and if time permits, I'll
>> experiment on ARM as well.
>
> The submitter has provided a new patch, he tested it and, I tested it on
>
Hi!
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191263
> Right now the submitter tests on 32bit and if time permits, I'll
> experiment on ARM as well.
The submitter has provided a new patch, he tested it and, I tested it on
- 10.0p10 amd64
- 10.1-RC3-i386
- 10.1-RC3-armv6 (raspberry-pi)
A
Hi!
> Dag-Erling Smørgrav writes:
> > Kurt Jaeger writes:
> > > I do not have a working arm setup right now.
> > This is a bug on all platforms, and both clang and (recent) gcc should
> > complain about it. That printf() call will print garbage.
>
> Correction: it will print garbage on 32-bit
On Tue, 28 Oct 2014, [utf-8] Dag-Erling Sm??rgrav wrote:
Bruce Evans writes:
Dag-Erling Sm??rgrav writes:
This is a bug on all platforms, and both clang and (recent) gcc
should complain about it. That printf() call will print garbage.
No, this is only a bug on 32-bit arches. The is is SSI
Bruce Evans writes:
> Dag-Erling Smørgrav writes:
> > This is a bug on all platforms, and both clang and (recent) gcc
> > should complain about it. That printf() call will print garbage.
> No, this is only a bug on 32-bit arches. The is is SSIZE_MAX.
If you mean "it only has consequences on 32
On Tue, 28 Oct 2014, [utf-8] Dag-Erling Sm??rgrav wrote:
Kurt Jaeger writes:
Konstantin Belousov writes:
On Mon, Oct 27, 2014 at 11:38:17AM +, Kurt Jaeger wrote:
/scratch/tmp/kib/src/bin/dd/args.c:192: warning: format '%jd' expects type
'intmax_t', but argument 3 has type 'int'
Thanks
Dag-Erling Smørgrav writes:
> Kurt Jaeger writes:
> > I do not have a working arm setup right now.
> This is a bug on all platforms, and both clang and (recent) gcc should
> complain about it. That printf() call will print garbage.
Correction: it will print garbage on 32-bit platforms, where si
Kurt Jaeger writes:
> Konstantin Belousov writes:
> > On Mon, Oct 27, 2014 at 11:38:17AM +, Kurt Jaeger wrote:
> > /scratch/tmp/kib/src/bin/dd/args.c:192: warning: format '%jd' expects type
> > 'intmax_t', but argument 3 has type 'int'
> Thanks for the pointer. I'll take it up with the submi
Hi!
> > So, given this detailed review, should I revert the change ?
>
> Yes. You would have to change half of it just to get it to compile
> on 32-bit arches.
Done. It's clearly my fault, I was sloppy in testing 8-(
--
p...@freebsd.org +49 171 31013726 years to go !
_
On Mon, 2014-10-27 at 17:20 +0100, Kurt Jaeger wrote:
> Hi!
>
> > > Log:
> > > bin/dd: Fix incorrect casting of arguments
> [...]
> > Both of these work correctly in my version (with a relatively small patch
> > and no breakage of other cases). (I actually typed large values as -1
> > and 11
On Mon, 27 Oct 2014, Kurt Jaeger wrote:
Log:
bin/dd: Fix incorrect casting of arguments
[...]
Both of these work correctly in my version (with a relatively small patch
and no breakage of other cases). (I actually typed large values as -1
and 11. -1 means (uintmax_t)-
Hi!
> > Log:
> > bin/dd: Fix incorrect casting of arguments
[...]
> Both of these work correctly in my version (with a relatively small patch
> and no breakage of other cases). (I actually typed large values as -1
> and 11. -1 means (uintmax_t)-1 although this
> is undoc
On Mon, Oct 27, 2014 at 04:54:27PM +0100, Kurt Jaeger wrote:
> > On Mon, Oct 27, 2014 at 11:38:17AM +, Kurt Jaeger wrote:
> > > Author: pi (ports committer)
> > > Date: Mon Oct 27 11:38:17 2014
> > > New Revision: 273734
> > > URL: https://svnweb.freebsd.org/changeset/base/273734
> > >
> > > L
On Mon, 27 Oct 2014, Kurt Jaeger wrote:
Log:
bin/dd: Fix incorrect casting of arguments
dd(1) casts many of its numeric arguments from uintmax_t to intmax_t
and back again to detect whether or not the original arguments were
negative. This caused wrong behaviour in some boundary cases:
$
On Mon, 27 Oct 2014, Konstantin Belousov wrote:
On Mon, Oct 27, 2014 at 11:38:17AM +, Kurt Jaeger wrote:
Log:
bin/dd: Fix incorrect casting of arguments
This causes non-trivial amount of errors like
cc1: warnings being treated as errors
/scratch/tmp/kib/src/bin/dd/args.c: In function 'f
> On Mon, Oct 27, 2014 at 11:38:17AM +, Kurt Jaeger wrote:
> > Author: pi (ports committer)
> > Date: Mon Oct 27 11:38:17 2014
> > New Revision: 273734
> > URL: https://svnweb.freebsd.org/changeset/base/273734
> >
> > Log:
> > bin/dd: Fix incorrect casting of arguments
> This causes non-triv
On Mon, Oct 27, 2014 at 11:38:17AM +, Kurt Jaeger wrote:
> Author: pi (ports committer)
> Date: Mon Oct 27 11:38:17 2014
> New Revision: 273734
> URL: https://svnweb.freebsd.org/changeset/base/273734
>
> Log:
> bin/dd: Fix incorrect casting of arguments
This causes non-trivial amount of erro
Author: pi (ports committer)
Date: Mon Oct 27 11:38:17 2014
New Revision: 273734
URL: https://svnweb.freebsd.org/changeset/base/273734
Log:
bin/dd: Fix incorrect casting of arguments
dd(1) casts many of its numeric arguments from uintmax_t to intmax_t
and back again to detect whether or n
21 matches
Mail list logo
