On Mon, 2014-10-27 at 17:20 +0100, Kurt Jaeger wrote: > Hi! > > > > Log: > > > bin/dd: Fix incorrect casting of arguments > [...] > > Both of these work correctly in my version (with a relatively small patch > > and no breakage of other cases). (I actually typed large values as -1 > > and 11111111111111111111111111. -1 means (uintmax_t)-1 although this > > is undocumented and now broken). > > So, given this detailed review, should I revert the change ? >
Given that it breaks the build for 32 bit architectures, it probably should be reverted until a different set of changes is available. -- Ian _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
