Re: svn commit: r249800 - head/sys/dev/bwn

2013-04-29 Thread hiren panchasara
On Mon, Apr 29, 2013 at 10:42 AM, Adrian Chadd wrote: > On 29 April 2013 09:44, hiren panchasara wrote: > >>> Does anyone here have bwn hardware that works? >> >> I do not. > > Have an expresscard slot? Want some? Yes and yes :-) cheers, Hiren > > > > adrian

Re: svn commit: r249800 - head/sys/dev/bwn

2013-04-29 Thread Adrian Chadd
On 29 April 2013 09:44, hiren panchasara wrote: >> Does anyone here have bwn hardware that works? > > I do not. Have an expresscard slot? Want some? adrian ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-h

Re: svn commit: r249800 - head/sys/dev/bwn

2013-04-29 Thread hiren panchasara
On Mon, Apr 29, 2013 at 9:19 AM, Adrian Chadd wrote: > On 29 April 2013 08:23, John Baldwin wrote: >>> - dr->setdesc(dr, desc, paddr, meta->mt_m->m_len - >>> + dr->setdesc(dr, desc, meta->mt_paddr, meta->mt_m->m_len - >>> sizeof(*hdr), 0, 0, 0); >>> return (error);

Re: svn commit: r249800 - head/sys/dev/bwn

2013-04-29 Thread Adrian Chadd
On 29 April 2013 08:23, John Baldwin wrote: >> - dr->setdesc(dr, desc, paddr, meta->mt_m->m_len - >> + dr->setdesc(dr, desc, meta->mt_paddr, meta->mt_m->m_len - >> sizeof(*hdr), 0, 0, 0); >> return (error); >> } > > I would leave the comment alone. In the common c

Re: svn commit: r249800 - head/sys/dev/bwn

2013-04-29 Thread John Baldwin
On Sunday, April 28, 2013 8:06:16 pm hiren panchasara wrote: > On Tue, Apr 23, 2013 at 9:46 AM, hiren panchasara wrote: > > On Tue, Apr 23, 2013 at 9:34 AM, Eitan Adler wrote: > >> On 23 April 2013 12:19, Adrian Chadd wrote: > >>> ... you know, even though it doesn't have an active maintainer, d

Re: svn commit: r249800 - head/sys/dev/bwn

2013-04-28 Thread hiren panchasara
On Tue, Apr 23, 2013 at 9:46 AM, hiren panchasara wrote: > On Tue, Apr 23, 2013 at 9:34 AM, Eitan Adler wrote: >> On 23 April 2013 12:19, Adrian Chadd wrote: >>> ... you know, even though it doesn't have an active maintainer, do you >>> have test hardware, and why didn't you just bounce a patch

Re: svn commit: r249800 - head/sys/dev/bwn

2013-04-23 Thread hiren panchasara
On Tue, Apr 23, 2013 at 9:34 AM, Eitan Adler wrote: > On 23 April 2013 12:19, Adrian Chadd wrote: >> ... you know, even though it doesn't have an active maintainer, do you >> have test hardware, and why didn't you just bounce a patch to >> -wireless for review? My bad. I proposed this change ini

Re: svn commit: r249800 - head/sys/dev/bwn

2013-04-23 Thread Eitan Adler
On 23 April 2013 12:19, Adrian Chadd wrote: > ... you know, even though it doesn't have an active maintainer, do you > have test hardware, and why didn't you just bounce a patch to > -wireless for review? > > We don't bite you know! that you need to emphasize this does not comfort me. ;) reverte

Re: svn commit: r249800 - head/sys/dev/bwn

2013-04-23 Thread Adrian Chadd
... you know, even though it doesn't have an active maintainer, do you have test hardware, and why didn't you just bounce a patch to -wireless for review? We don't bite you know! adrian (Who yes, does have lots of bwn hardware. if you have a cardbus or expresscard slot you can have one.) On 2

Re: svn commit: r249800 - head/sys/dev/bwn

2013-04-23 Thread John Baldwin
On Tuesday, April 23, 2013 9:02:58 am Eitan Adler wrote: > Author: eadler > Date: Tue Apr 23 13:02:57 2013 > New Revision: 249800 > URL: http://svnweb.freebsd.org/changeset/base/249800 > > Log: > Avoid warning about uninitalized variable > > PR: kern/176712 > Submitted by: H

svn commit: r249800 - head/sys/dev/bwn

2013-04-23 Thread Eitan Adler
Author: eadler Date: Tue Apr 23 13:02:57 2013 New Revision: 249800 URL: http://svnweb.freebsd.org/changeset/base/249800 Log: Avoid warning about uninitalized variable PR: kern/176712 Submitted by: Hiren Panchasara (earlier vesion) Approved by: cperciva (mentor) Modified: