Re: svn commit: r236935 - head/sys/kern

2012-06-13 Thread Pawel Jakub Dawidek
On Wed, Jun 13, 2012 at 01:18:53PM +0200, Mateusz Guzik wrote: > On Wed, Jun 13, 2012 at 01:13:09PM +0200, Pawel Jakub Dawidek wrote: > > On Wed, Jun 13, 2012 at 12:53:44PM +0200, Mateusz Guzik wrote: > > > http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free5.patch > > > > > > David rep

Re: svn commit: r236935 - head/sys/kern

2012-06-13 Thread Mateusz Guzik
On Wed, Jun 13, 2012 at 01:13:09PM +0200, Pawel Jakub Dawidek wrote: > On Wed, Jun 13, 2012 at 12:53:44PM +0200, Mateusz Guzik wrote: > > http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free5.patch > > > > David reported that previous version of the patch fixed panic he was > > experienc

Re: svn commit: r236935 - head/sys/kern

2012-06-13 Thread Pawel Jakub Dawidek
On Wed, Jun 13, 2012 at 12:53:44PM +0200, Mateusz Guzik wrote: > http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free5.patch > > David reported that previous version of the patch fixed panic he was > experiencing, so I consider the patch tested. Looks good, one (hopefully last) minor ni

Re: svn commit: r236935 - head/sys/kern

2012-06-13 Thread Mateusz Guzik
On Wed, Jun 13, 2012 at 12:29:01PM +0200, Pawel Jakub Dawidek wrote: > On Wed, Jun 13, 2012 at 11:38:07AM +0200, Mateusz Guzik wrote: > > On Tue, Jun 12, 2012 at 11:44:00PM +0200, Pawel Jakub Dawidek wrote: > > > On Tue, Jun 12, 2012 at 09:18:28PM +0200, Mateusz Guzik wrote: > > > > On Tue, Jun 12,

Re: svn commit: r236935 - head/sys/kern

2012-06-13 Thread Pawel Jakub Dawidek
On Wed, Jun 13, 2012 at 11:38:07AM +0200, Mateusz Guzik wrote: > On Tue, Jun 12, 2012 at 11:44:00PM +0200, Pawel Jakub Dawidek wrote: > > On Tue, Jun 12, 2012 at 09:18:28PM +0200, Mateusz Guzik wrote: > > > On Tue, Jun 12, 2012 at 06:01:29PM +0200, Pawel Jakub Dawidek wrote: > > > > Look good and y

Re: svn commit: r236935 - head/sys/kern

2012-06-13 Thread Mateusz Guzik
On Tue, Jun 12, 2012 at 11:44:00PM +0200, Pawel Jakub Dawidek wrote: > On Tue, Jun 12, 2012 at 09:18:28PM +0200, Mateusz Guzik wrote: > > On Tue, Jun 12, 2012 at 06:01:29PM +0200, Pawel Jakub Dawidek wrote: > > > Look good and you can just add 'In co-operation with: pjd'. > > > One minor thing is t

Re: svn commit: r236935 - head/sys/kern

2012-06-12 Thread David Xu
On 2012/6/13 3:18, Mateusz Guzik wrote: On Tue, Jun 12, 2012 at 06:01:29PM +0200, Pawel Jakub Dawidek wrote: On Tue, Jun 12, 2012 at 03:49:50PM +0200, Mateusz Guzik wrote: On Tue, Jun 12, 2012 at 01:43:35PM +0200, Pawel Jakub Dawidek wrote: On Tue, Jun 12, 2012 at 12:47:49PM +0200, Mateusz Guz

Re: svn commit: r236935 - head/sys/kern

2012-06-12 Thread Pawel Jakub Dawidek
On Tue, Jun 12, 2012 at 09:18:28PM +0200, Mateusz Guzik wrote: > On Tue, Jun 12, 2012 at 06:01:29PM +0200, Pawel Jakub Dawidek wrote: > > Look good and you can just add 'In co-operation with: pjd'. > > One minor thing is that fd_first_free() can return 'size' if there are > > no free slots availabl

Re: svn commit: r236935 - head/sys/kern

2012-06-12 Thread Mateusz Guzik
On Tue, Jun 12, 2012 at 06:01:29PM +0200, Pawel Jakub Dawidek wrote: > On Tue, Jun 12, 2012 at 03:49:50PM +0200, Mateusz Guzik wrote: > > On Tue, Jun 12, 2012 at 01:43:35PM +0200, Pawel Jakub Dawidek wrote: > > > On Tue, Jun 12, 2012 at 12:47:49PM +0200, Mateusz Guzik wrote: > > > > The problem is

Re: svn commit: r236935 - head/sys/kern

2012-06-12 Thread Pawel Jakub Dawidek
On Tue, Jun 12, 2012 at 03:49:50PM +0200, Mateusz Guzik wrote: > On Tue, Jun 12, 2012 at 01:43:35PM +0200, Pawel Jakub Dawidek wrote: > > On Tue, Jun 12, 2012 at 12:47:49PM +0200, Mateusz Guzik wrote: > > > The problem is that fdalloc grows to at most fdp->fd_nfiles * 2, which > > > still may not b

Re: svn commit: r236935 - head/sys/kern

2012-06-12 Thread Mateusz Guzik
On Tue, Jun 12, 2012 at 01:43:35PM +0200, Pawel Jakub Dawidek wrote: > On Tue, Jun 12, 2012 at 12:47:49PM +0200, Mateusz Guzik wrote: > > The problem is that fdalloc grows to at most fdp->fd_nfiles * 2, which > > still may not be enough to have place for new fd with high number. > > I was under im

Re: svn commit: r236935 - head/sys/kern

2012-06-12 Thread Pawel Jakub Dawidek
On Tue, Jun 12, 2012 at 12:47:49PM +0200, Mateusz Guzik wrote: > The problem is that fdalloc grows to at most fdp->fd_nfiles * 2, which > still may not be enough to have place for new fd with high number. I was under impression that fd_first_free() can return at most fdp->fd_nfiles, but indeed I m

Re: svn commit: r236935 - head/sys/kern

2012-06-12 Thread Mateusz Guzik
On Tue, Jun 12, 2012 at 04:26:33PM +0800, David Xu wrote: > On 2012/6/12 6:05, Pawel Jakub Dawidek wrote: > >Author: pjd > >Date: Mon Jun 11 22:05:26 2012 > >New Revision: 236935 > >URL: http://svn.freebsd.org/changeset/base/236935 > > > >Log: > > fdgrowtable() no longer drops the filedesc lock s

Re: svn commit: r236935 - head/sys/kern

2012-06-12 Thread David Xu
On 2012/6/12 6:05, Pawel Jakub Dawidek wrote: Author: pjd Date: Mon Jun 11 22:05:26 2012 New Revision: 236935 URL: http://svn.freebsd.org/changeset/base/236935 Log: fdgrowtable() no longer drops the filedesc lock so it is enough to retry finding free file descriptor only once after fdgrowt

svn commit: r236935 - head/sys/kern

2012-06-11 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Jun 11 22:05:26 2012 New Revision: 236935 URL: http://svn.freebsd.org/changeset/base/236935 Log: fdgrowtable() no longer drops the filedesc lock so it is enough to retry finding free file descriptor only once after fdgrowtable(). Spotted by: pluknet MFC after: