On Wed, Jun 13, 2012 at 01:13:09PM +0200, Pawel Jakub Dawidek wrote: > On Wed, Jun 13, 2012 at 12:53:44PM +0200, Mateusz Guzik wrote: > > http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free5.patch > > > > David reported that previous version of the patch fixed panic he was > > experiencing, so I consider the patch tested. > > Looks good, one (hopefully last) minor nit. I'd change this comment: > > * Search the bitmap for a free descriptor starting at minfd. If none > * is found, try to grow the file table. > > To something like this: > > * Search the bitmap for a free descriptor starting at minfd. > * If none is found, grow the file table. > > 'try' is a bit misleading for my taste, as it suggest that growing the > file table might fail, I think. >
Done in: http://people.freebsd.org/~mjg/patches/fdalloc%2bfd_first_free6.patch > That's all from me:) > Thanks for your comments and suggestions. -- Mateusz Guzik <mjguzik gmail.com> _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
