Re: svn commit: r233136 - in head/secure: usr.bin/ssh usr.sbin/sshd

2012-03-20 Thread John Baldwin
On Monday, March 19, 2012 7:12:25 pm Eitan Adler wrote: > 2012/3/19 Dag-Erling Smørgrav : > > John Baldwin writes: > > Looking at the original contents of the two files > > sshd: > -.if defined(X11BASE) || defined(LOCALBASE) > > ssh: > -.if defined(X11BASE) > > which I think was the cause of m

Re: svn commit: r233136 - in head/secure: usr.bin/ssh usr.sbin/sshd

2012-03-19 Thread Eitan Adler
2012/3/19 Dag-Erling Smørgrav : > John Baldwin writes: Looking at the original contents of the two files sshd: -.if defined(X11BASE) || defined(LOCALBASE) ssh: -.if defined(X11BASE) which I think was the cause of my original confusion. The change *was* a no-op for ssh but resulted in behavior

Re: svn commit: r233136 - in head/secure: usr.bin/ssh usr.sbin/sshd

2012-03-19 Thread Dag-Erling Smørgrav
John Baldwin writes: > .ifdef LOCALBASE > CFLAGS+= /* blah bblah */ > .endif Agreed. DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mai

Re: svn commit: r233136 - in head/secure: usr.bin/ssh usr.sbin/sshd

2012-03-19 Thread John Baldwin
On Monday, March 19, 2012 11:55:12 am Eitan Adler wrote: > >> This looks wrong. While X11BASE is certainly dead, LOCALBASE is not, so the > >> existing code should have been changed, but not removed. > > Does this look good? > Build tested only. Hmm, I will defer to Des. Previously the make gl

Re: svn commit: r233136 - in head/secure: usr.bin/ssh usr.sbin/sshd

2012-03-19 Thread Eitan Adler
>> This looks wrong.  While X11BASE is certainly dead, LOCALBASE is not, so the >> existing code should have been changed, but not removed. Does this look good? Build tested only. commit 271b766fdbd907be040767f2387b4d5fbb6425f7 Author: Eitan Adler Date: Mon Mar 19 11:52:31 2012 -0400 Rest

Re: svn commit: r233136 - in head/secure: usr.bin/ssh usr.sbin/sshd

2012-03-19 Thread Eitan Adler
On Mon, Mar 19, 2012 at 8:35 AM, John Baldwin wrote: > On Sunday, March 18, 2012 8:41:40 pm Eitan Adler wrote: >> Author: eadler >> Date: Mon Mar 19 00:41:40 2012 >> New Revision: 233136 >> URL: http://svn.freebsd.org/changeset/base/233136 >> >> Log: >>   X11BASE is not used any more and has been

Re: svn commit: r233136 - in head/secure: usr.bin/ssh usr.sbin/sshd

2012-03-19 Thread John Baldwin
On Sunday, March 18, 2012 8:41:40 pm Eitan Adler wrote: > Author: eadler > Date: Mon Mar 19 00:41:40 2012 > New Revision: 233136 > URL: http://svn.freebsd.org/changeset/base/233136 > > Log: > X11BASE is not used any more and has been killed by the x11 team. > > Reviewed by:??? > A

Re: svn commit: r233136 - in head/secure: usr.bin/ssh usr.sbin/sshd

2012-03-18 Thread Eitan Adler
On Sun, Mar 18, 2012 at 8:41 PM, Eitan Adler wrote: > Author: eadler > Date: Mon Mar 19 00:41:40 2012 > New Revision: 233136 > URL: http://svn.freebsd.org/changeset/base/233136 > > Log: >  X11BASE is not used any more and has been killed by the x11 team. > >  Reviewed by:  ??? >  Approved by:  ???

svn commit: r233136 - in head/secure: usr.bin/ssh usr.sbin/sshd

2012-03-18 Thread Eitan Adler
Author: eadler Date: Mon Mar 19 00:41:40 2012 New Revision: 233136 URL: http://svn.freebsd.org/changeset/base/233136 Log: X11BASE is not used any more and has been killed by the x11 team. Reviewed by: ??? Approved by: ??? MFC after:3 days Modified: head/secure/usr.bin/ssh/Makef