Re: svn commit: r320579 - head/usr.bin/patch

2018-03-04 Thread Eitan Adler
On 2 July 2017 at 14:00, Pedro F. Giffuni wrote: > + } else if (strnEQ(s, "diff --git a/", 13)) { > + /* Git-style diffs. */ > + piece_of_git = 1; This is incomplete and leaves to confusing behavior for some git diffs. In particular with '

Re: svn commit: r320579 - head/usr.bin/patch

2017-07-03 Thread Pedro Giffuni
On 7/3/2017 2:14 PM, Alexey Dokuchaev wrote: On Mon, Jul 03, 2017 at 01:35:25PM -0500, Pedro Giffuni wrote: On 7/3/2017 1:17 PM, Alexey Dokuchaev wrote: On Mon, Jul 03, 2017 at 10:42:15AM -0500, Pedro Giffuni wrote: On 07/02/17 21:53, Conrad Meyer wrote: Does this change the behavior of 'pa

Re: svn commit: r320579 - head/usr.bin/patch

2017-07-03 Thread Alexey Dokuchaev
On Mon, Jul 03, 2017 at 01:35:25PM -0500, Pedro Giffuni wrote: > On 7/3/2017 1:17 PM, Alexey Dokuchaev wrote: > > On Mon, Jul 03, 2017 at 10:42:15AM -0500, Pedro Giffuni wrote: > >> On 07/02/17 21:53, Conrad Meyer wrote: > >>> Does this change the behavior of 'patch -p1' (for example) with 'git > >

Re: svn commit: r320579 - head/usr.bin/patch

2017-07-03 Thread Pedro Giffuni
On 7/3/2017 1:17 PM, Alexey Dokuchaev wrote: On Mon, Jul 03, 2017 at 10:42:15AM -0500, Pedro Giffuni wrote: On 07/02/17 21:53, Conrad Meyer wrote: Does this change the behavior of 'patch -p1' (for example) with 'git diff' generated diffs? So patches that could be applied with -p1 before now

Re: svn commit: r320579 - head/usr.bin/patch

2017-07-03 Thread Alexey Dokuchaev
On Mon, Jul 03, 2017 at 10:42:15AM -0500, Pedro Giffuni wrote: > On 07/02/17 21:53, Conrad Meyer wrote: > > Does this change the behavior of 'patch -p1' (for example) with 'git > > diff' generated diffs? So patches that could be applied with -p1 > > before now need to be applied with -p0? Or is t

Re: svn commit: r320579 - head/usr.bin/patch

2017-07-03 Thread Pedro Giffuni
Hello; On 07/02/17 21:53, Conrad Meyer wrote: Hi Pedro, Does this change the behavior of 'patch -p1' (for example) with 'git diff' generated diffs? So patches that could be applied with -p1 before now need to be applied with -p0? Or is this a different mode of patch? Thanks for pointing thi

Re: svn commit: r320579 - head/usr.bin/patch

2017-07-02 Thread Conrad Meyer
Hi Pedro, Does this change the behavior of 'patch -p1' (for example) with 'git diff' generated diffs? So patches that could be applied with -p1 before now need to be applied with -p0? Or is this a different mode of patch? If so, that's a somewhat surprising change in behavior. Does GNU patch h