On 2 July 2017 at 14:00, Pedro F. Giffuni <p...@freebsd.org> wrote:
> +               } else if (strnEQ(s, "diff --git a/", 13)) {
> +                       /* Git-style diffs. */
> +                       piece_of_git = 1;

This is incomplete and leaves to confusing behavior for some git
diffs. In particular with 'diff.mnemonicprefix = true' the prefix is
awesome something other than 'a/'. It can be 'w' for working copy, 'i'
for index, 'c' for commit, or some other values.

While I don't oppose this feature, it'd be better if we did not tie it
to a single specific prefix.


-- 
Eitan Adler
_______________________________________________
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to