Andrey, would you mind leaving your comments in the phabricator so that the
Mikhail (original contributor of the patch) could work on an improved
version? You might be correct about the abs(), I've overlooked that, but
the fs_fsize math is just copied over the previous code as far as I can
tell. So
On 18.07.16 22:37, Maxim Sobolev wrote:
> Well, this looks to me exactly what I am talking about. With this change
> we are only allowing underlying provider to be *slighly* bigger than the
> UFS size. So as I said it's pretty harmless to do so, or at least I
So, this isn't true.
1. You use abs()
Well, this looks to me exactly what I am talking about. With this change we
are only allowing underlying provider to be *slighly* bigger than the UFS
size. So as I said it's pretty harmless to do so, or at least I think it
is. In general I think this case is underlying some missing design feature
o
On 18.07.16 17:24, Maxim Sobolev wrote:
> Andrey, are you talking about this:
>
> ---
> r156299 | pjd | 2006-03-04 11:41:54 -0800 (сб, 04 мар 2006) | 11 lines
>
> We need to check if file system size is equal to provider's size, because
> sysinstall(8) still bogusly puts first partition at offset
I think people might be worried about existing deployed systems that might
stop booting if geom label obscures the whole disk making one or more
slices unavailable via geom_label mechanism.
-Max
On Mon, Jul 18, 2016 at 10:09 AM, Devin Teske wrote:
>
> > On Jul 18, 2016, at 7:24 AM, Maxim Sobole
> On Jul 18, 2016, at 7:24 AM, Maxim Sobolev wrote:
>
> Andrey, are you talking about this:
>
> ---
> r156299 | pjd | 2006-03-04 11:41:54 -0800 (сб, 04 мар 2006) | 11 lines
>
> We need to check if file system size is equal to provider's size, because
> sysinstall(8)
?? sysinstall ?? in head
Andrey, are you talking about this:
---
r156299 | pjd | 2006-03-04 11:41:54 -0800 (сб, 04 мар 2006) | 11 lines
We need to check if file system size is equal to provider's size, because
sysinstall(8) still bogusly puts first partition at offset 0 instead of 16,
so glabel/ufs will find file system
On 18.07.16 08:00, Maxim Sobolev wrote:
> Author: sobomax
> Date: Mon Jul 18 05:00:01 2016
> New Revision: 302985
> URL: https://svnweb.freebsd.org/changeset/base/302985
>
> Log:
> Relax checking if the privider size matches size recorded in the
> superblock, allowing provider to be bit bigger
