Re: svn commit: r235267 - in head/usr.bin/sort: . nls

2012-05-12 Thread John Baldwin
On 5/11/12 1:17 PM, Bruce Evans wrote: > However, they may be some some boot programs that save space by not > bzeroing the bss. Not being a C program in this respect apparently > caused the following farcal churn in i386/boot2: > - the opts variable started with a bogus explicit initialization >

Re: svn commit: r235267 - in head/usr.bin/sort: . nls

2012-05-11 Thread Colin Percival
On 05/11/12 13:08, Warner Losh wrote: > On May 11, 2012, at 9:02 AM, Colin Percival wrote: >> On 05/11/12 05:48, Konstantin Belousov wrote: >>> On Fri, May 11, 2012 at 12:37:16PM +, Gabor Kovesdan wrote: +bool byte_sort = false; + +static wchar_t **wmonths = NULL; +static unsigned cha

Re: svn commit: r235267 - in head/usr.bin/sort: . nls

2012-05-11 Thread Warner Losh
On May 11, 2012, at 9:02 AM, Colin Percival wrote: > On 05/11/12 05:48, Konstantin Belousov wrote: >> On Fri, May 11, 2012 at 12:37:16PM +, Gabor Kovesdan wrote: >>> +bool byte_sort = false; + +static wchar_t **wmonths = NULL; +static >>> unsigned char **cmonths = NULL; >> >> Such initializa

Re: svn commit: r235267 - in head/usr.bin/sort: . nls

2012-05-11 Thread Bruce Evans
On Fri, 11 May 2012, Konstantin Belousov wrote: On Fri, May 11, 2012 at 08:57:29AM -0400, David Chisnall wrote: On 11 May 2012, at 08:48, Konstantin Belousov wrote: On Fri, May 11, 2012 at 12:37:16PM +, Gabor Kovesdan wrote: Author: gabor Date: Fri May 11 12:37:16 2012 New Revision: 2352

Re: svn commit: r235267 - in head/usr.bin/sort: . nls

2012-05-11 Thread Dimitry Andric
On 2012-05-11 15:02, Colin Percival wrote:> On 05/11/12 05:48, Konstantin Belousov wrote: >> On Fri, May 11, 2012 at 12:37:16PM +, Gabor Kovesdan wrote: >>> +bool byte_sort = false; + +static wchar_t **wmonths = NULL; +static >>> unsigned char **cmonths = NULL; >> >> Such initializations are u

Re: svn commit: r235267 - in head/usr.bin/sort: . nls

2012-05-11 Thread Konstantin Belousov
On Fri, May 11, 2012 at 08:57:29AM -0400, David Chisnall wrote: > On 11 May 2012, at 08:48, Konstantin Belousov wrote: > > > On Fri, May 11, 2012 at 12:37:16PM +, Gabor Kovesdan wrote: > >> Author: gabor > >> Date: Fri May 11 12:37:16 2012 > >> New Revision: 235267 > >> URL: http://svn.freebsd

Re: svn commit: r235267 - in head/usr.bin/sort: . nls

2012-05-11 Thread Gabor Kovesdan
On 2012.05.11. 15:02, Colin Percival wrote: On 05/11/12 05:48, Konstantin Belousov wrote: >On Fri, May 11, 2012 at 12:37:16PM +, Gabor Kovesdan wrote: >>+bool byte_sort = false; + +static wchar_t **wmonths = NULL; +static >>unsigned char **cmonths = NULL; > >Such initializations are useles

Re: svn commit: r235267 - in head/usr.bin/sort: . nls

2012-05-11 Thread Colin Percival
On 05/11/12 05:48, Konstantin Belousov wrote: > On Fri, May 11, 2012 at 12:37:16PM +, Gabor Kovesdan wrote: >> +bool byte_sort = false; + +static wchar_t **wmonths = NULL; +static >> unsigned char **cmonths = NULL; > > Such initializations are useless. You only increase the size of the binary

Re: svn commit: r235267 - in head/usr.bin/sort: . nls

2012-05-11 Thread David Chisnall
On 11 May 2012, at 08:48, Konstantin Belousov wrote: > On Fri, May 11, 2012 at 12:37:16PM +, Gabor Kovesdan wrote: >> Author: gabor >> Date: Fri May 11 12:37:16 2012 >> New Revision: 235267 >> URL: http://svn.freebsd.org/changeset/base/235267 > >> +bool byte_sort = false; >> + >> +static wcha

Re: svn commit: r235267 - in head/usr.bin/sort: . nls

2012-05-11 Thread Konstantin Belousov
On Fri, May 11, 2012 at 12:37:16PM +, Gabor Kovesdan wrote: > Author: gabor > Date: Fri May 11 12:37:16 2012 > New Revision: 235267 > URL: http://svn.freebsd.org/changeset/base/235267 > +bool byte_sort = false; > + > +static wchar_t **wmonths = NULL; > +static unsigned char **cmonths = NULL;