Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-23 Thread Kostik Belousov
On Mon, Jan 23, 2012 at 03:13:07PM +0100, Dimitry Andric wrote: > On 2012-01-23 13:31, Kostik Belousov wrote: > >On Mon, Jan 23, 2012 at 01:25:04PM +0100, Dimitry Andric wrote: > ... > >There is a typo in the second or condition, should it be gcc46 both times ? > > Ah, sorry, that was a copy/paste

Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-23 Thread Dimitry Andric
On 2012-01-23 13:31, Kostik Belousov wrote: On Mon, Jan 23, 2012 at 01:25:04PM +0100, Dimitry Andric wrote: ... There is a typo in the second or condition, should it be gcc46 both times ? Ah, sorry, that was a copy/paste error. Anyway, the reason to answer this message is two ask the for s

Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-23 Thread Kostik Belousov
On Mon, Jan 23, 2012 at 01:25:04PM +0100, Dimitry Andric wrote: > On 2012-01-23 05:28, Hiroki Sato wrote: > ... > > I don't think it is needed. The makefs utility is a special case > > because it will probably diverge from the upstream to support > > FreeBSD-specific feature in the future (this

Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-23 Thread Dimitry Andric
On 2012-01-23 05:28, Hiroki Sato wrote: ... I don't think it is needed. The makefs utility is a special case because it will probably diverge from the upstream to support FreeBSD-specific feature in the future (this is one of the reasons why it is not in contrib/). It didn't happen so f

Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-23 Thread Eitan Adler
On Sun, Jan 22, 2012 at 11:28 PM, Hiroki Sato wrote: > ea> bug fix which could be upstreamed that would be great. On the other > ea> hand I would like to continue with my goal of making the non-contrib > ea> world compilable with CC=gcc46. > ea> > ea> Should I revert this commit? > >  I don't thin

Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-22 Thread Hiroki Sato
Eitan Adler wrote in : ea> I was was unaware this code was contributed. I just looked at the ea> NetBSD version and I don't think it suffers from the same problem - ea> the loop appears to be used later. If that is because of some other Just checking, but the variables dot and semi are not us

Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-20 Thread Eitan Adler
On Sat, Jan 21, 2012 at 12:52 AM, Bruce Evans wrote: > On Fri, 20 Jan 2012, Eitan Adler wrote: > >> On Fri, Jan 20, 2012 at 7:13 PM, Bruce Evans wrote: >>> >>> I agree.  Never fix vendor code.  Especially style bugs in it.  Not all >>> vendor code is in contrib. >> I'm sure this is a silly questi

Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-20 Thread Bruce Evans
On Fri, 20 Jan 2012, Eitan Adler wrote: On Fri, Jan 20, 2012 at 7:13 PM, Bruce Evans wrote: I agree. ??Never fix vendor code. ??Especially style bugs in it. ??Not all vendor code is in contrib. I'm sure this is a silly question, but why isn't this utility in a contrib/ folder? Probably his

Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-20 Thread Eitan Adler
On Fri, Jan 20, 2012 at 7:13 PM, Bruce Evans wrote: > I agree.  Never fix vendor code.  Especially style bugs in it.  Not all > vendor code is in contrib. I'm sure this is a silly question, but why isn't this utility in a contrib/ folder? > In fact, it seems that there there was a very large amo

Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-20 Thread Bruce Evans
On Fri, 20 Jan 2012, Hiroki Sato wrote: Eitan Adler wrote in <201201200138.q0k1csou016...@svn.freebsd.org>: ea> Log: ea> Fix a variety of warnings when compiling with gcc46 ea> ea> Approved by: dim, cperciva (mentor, blanket for pre-mentorship already-approved commits) ea> MFC after:

Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-20 Thread Eitan Adler
On Thu, Jan 19, 2012 at 10:32 PM, Hiroki Sato wrote: > Eitan Adler wrote >  in <201201200138.q0k1csou016...@svn.freebsd.org>: > > ea> Author: eadler > ea> Date: Fri Jan 20 01:38:28 2012 > ea> New Revision: 230354 > ea> URL: http://svn.freebsd.org/changeset/base/230354 > ea> > ea> Log: > ea>   Fix

Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-19 Thread Hiroki Sato
Eitan Adler wrote in <201201200138.q0k1csou016...@svn.freebsd.org>: ea> Author: eadler ea> Date: Fri Jan 20 01:38:28 2012 ea> New Revision: 230354 ea> URL: http://svn.freebsd.org/changeset/base/230354 ea> ea> Log: ea> Fix a variety of warnings when compiling with gcc46 ea> ea> Approved by: