On Sat, Jan 21, 2012 at 12:52 AM, Bruce Evans <b...@optusnet.com.au> wrote: > On Fri, 20 Jan 2012, Eitan Adler wrote: > >> On Fri, Jan 20, 2012 at 7:13 PM, Bruce Evans <b...@optusnet.com.au> wrote: >>> >>> I agree. Never fix vendor code. Especially style bugs in it. Not all >>> vendor code is in contrib. >> I'm sure this is a silly question, but why isn't this utility in a >> contrib/ folder? > Probably historical, but src/contrib/ still has little more than `file' > and lukemftpd from NetBSD. I think those are there mainly because they > got portabilized and complicated by their use of autoconfig, so they > don't fit naturally in the BSD build framework any more.
I'll check http://wiki.freebsd.org/ContribSoftware for now on before making such fixes. >>> I don't understand this code well enough to fix it. Fixing it requires >>> understanding whether the unused variable was unused because of another >>> bug. Another bug seems likely here, since there is so much dead code. >>> Or maybe I'm just confused, and the dead code is actually undead. It >>> is complicated enough for this to be unclear. >> I did not just rely on the compiler - I went through the code manually >> to ensure it was correct. > > It can take too long to see correctness for an apparently-simple change. I won't revert this commit because it doesn't seem to have broken anything from the end user perspective, but I won't complain if a future import causes a regression. Thanks for your time! -- Eitan Adler Source & Ports committer X11, Bugbusting teams _______________________________________________ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
