svn commit: r368041 - in head: stand/efi/loader sys/amd64/amd64 sys/amd64/include sys/conf

2020-11-25 Thread Maxim Sobolev
Author: sobomax Date: Wed Nov 25 23:19:01 2020 New Revision: 368041 URL: https://svnweb.freebsd.org/changeset/base/368041 Log: Unobfuscate "KERNLOAD" parameter on amd64. This change lines-up amd64 with the i386 and the rest of supported architectures by defining KERNLOAD in the vmparam.h and

svn commit: r366126 - head/usr.sbin/daemon

2020-09-24 Thread Maxim Sobolev
Author: sobomax Date: Thu Sep 24 19:12:03 2020 New Revision: 366126 URL: https://svnweb.freebsd.org/changeset/base/366126 Log: Fix a typo in the 366098. Reported by: 0mp MFC after:2 weeks (along with 366098) Modified: head/usr.sbin/daemon/daemon.8 Modified: head/u

svn commit: r366098 - head/usr.sbin/daemon

2020-09-23 Thread Maxim Sobolev
Author: sobomax Date: Thu Sep 24 02:44:58 2020 New Revision: 366098 URL: https://svnweb.freebsd.org/changeset/base/366098 Log: dd a new option (-H) to daemon(8) to catch SIGHUP and re-open output_file file when received. The default system log rotation mechanism (newsyslog(8)) requires a

svn commit: r364711 - head/usr.sbin/gstat

2020-08-24 Thread Maxim Sobolev
Author: sobomax Date: Mon Aug 24 16:45:23 2020 New Revision: 364711 URL: https://svnweb.freebsd.org/changeset/base/364711 Log: In the endless batch mode (-B), terminate if and when stdout is closed. That mode is useful to call gstat from other app, however kinda useless since gstat won't exi

Re: svn commit: r359685 - in head: . etc lib/libc/gen share/mk share/termcap usr.bin/login usr.bin/vgrind usr.sbin/services_mkdb

2020-04-09 Thread Maxim Sobolev
Well, how many FreeBSD builds have you run in the last year, Rodney, personally to care about 0.1s slowdown that it might have caused? We've run at least a 1,000 here, probably 3x more. So yes, the cost is there, the cost is well understood and found negligible versus the benefit of having a slight

Re: svn commit: r359685 - in head: . etc lib/libc/gen share/mk share/termcap usr.bin/login usr.bin/vgrind usr.sbin/services_mkdb

2020-04-08 Thread Maxim Sobolev
On Tue, Apr 7, 2020 at 3:37 AM Rodney W. Grimes wrote: > > Author: sobomax > > Date: Tue Apr 7 02:46:22 2020 > > New Revision: 359685 > > URL: https://svnweb.freebsd.org/changeset/base/359685 > > > > Log: > > Normalize deployment tools usage and definitions by putting into one > place > > in

Re: svn commit: r359681 - in head: . share/mk

2020-04-06 Thread Maxim Sobolev
This broke Jenkins builds. :( https://ci.freebsd.org/job/FreeBSD-head-armv7-build/8689/ -Max On Mon, Apr 6, 2020 at 6:49 PM Bryan Drewery wrote: > On 4/6/2020 4:38 PM, Brooks Davis wrote: > > Author: brooks > > Date: Mon Apr 6 23:38:46 2020 > > New Revision: 359681 > > URL: https://svnweb.fr

svn commit: r359685 - in head: . etc lib/libc/gen share/mk share/termcap usr.bin/login usr.bin/vgrind usr.sbin/services_mkdb

2020-04-06 Thread Maxim Sobolev
Author: sobomax Date: Tue Apr 7 02:46:22 2020 New Revision: 359685 URL: https://svnweb.freebsd.org/changeset/base/359685 Log: Normalize deployment tools usage and definitions by putting into one place instead of sprinkling them out over many disjoint files. This is a follow-up to achieve th

svn commit: r350224 - in head: sbin/mount share/man/man5

2019-07-22 Thread Maxim Sobolev
Author: sobomax Date: Mon Jul 22 20:04:55 2019 New Revision: 350224 URL: https://svnweb.freebsd.org/changeset/base/350224 Log: Allow "update" option to be used in the fstab(5). Document possible use case. Approved by: mckusick MFC after:2 weeks Differential Revision:https:/

Re: svn commit: r348521 - in head: . etc sys/conf sys/modules usr.bin/login usr.sbin/services_mkdb

2019-06-04 Thread Maxim Sobolev
https://reviews.freebsd.org/D20520 has been created as a follow-up. Give it some feedback, thanks! -Max On Mon, Jun 3, 2019 at 11:42 AM Rodney W. Grimes wrote: > > On Mon, Jun 3, 2019 at 7:28 AM Enji Cooper > wrote: > > > > > Hi Maxim, > > > > > > > > > > Modified: head/Makefile.inc1 > > > > >

svn commit: r348589 - head/etc

2019-06-03 Thread Maxim Sobolev
Author: sobomax Date: Mon Jun 3 21:40:42 2019 New Revision: 348589 URL: https://svnweb.freebsd.org/changeset/base/348589 Log: Put back MTREE_CMD here for now. Doh, not my day, perhaps. Reported by: markj, mav Modified: head/etc/Makefile Modified: head/etc/Makefile

Re: svn commit: r348521 - in head: . etc sys/conf sys/modules usr.bin/login usr.sbin/services_mkdb

2019-06-03 Thread Maxim Sobolev
On Mon, Jun 3, 2019 at 7:28 AM Enji Cooper wrote: > Hi Maxim, > > > > Modified: head/Makefile.inc1 > > > == > > --- head/Makefile.inc1Sun Jun 2 22:27:26 2019(r348520) > > +++ head/Makefile.inc1Sun Jun 2 23:3

svn commit: r348540 - head

2019-06-03 Thread Maxim Sobolev
Author: sobomax Date: Mon Jun 3 15:34:00 2019 New Revision: 348540 URL: https://svnweb.freebsd.org/changeset/base/348540 Log: Rollback the rest of the botched r348521. Re-work would be posted to reviews. Sorry. Reported by: Enji Cooper Modified: head/Makefile.inc1 Modified: head/Mak

svn commit: r348532 - in head: . etc

2019-06-03 Thread Maxim Sobolev
Author: sobomax Date: Mon Jun 3 15:12:44 2019 New Revision: 348532 URL: https://svnweb.freebsd.org/changeset/base/348532 Log: Leave mtree hardcoded for now. Reverting partially 348521 and also the followup stopgap change, because I don't think it's a correct. I still need to figure out wher

Re: svn commit: r348521 - in head: . etc sys/conf sys/modules usr.bin/login usr.sbin/services_mkdb

2019-06-03 Thread Maxim Sobolev
gt; > In message <7bd6b7ad-5950-4015-b95d-9ffb609f5...@fubar.geek.nz>, >> Andrew Turner >> > writes: >> > > >> > > >> > > > On 3 Jun 2019, at 00:38, Maxim Sobolev wrote: >> > > > >> > > > Author: sobomax &

svn commit: r348521 - in head: . etc sys/conf sys/modules usr.bin/login usr.sbin/services_mkdb

2019-06-02 Thread Maxim Sobolev
Author: sobomax Date: Sun Jun 2 23:38:19 2019 New Revision: 348521 URL: https://svnweb.freebsd.org/changeset/base/348521 Log: Fix several places where tool name has been hardcoded: install -> ${INSTALL} mtree -> ${MTREE_CMD} services_mkdb -> ${SERVICES_MKDB_CMD} cap_m

svn commit: r348091 - head/sys/dev/aacraid

2019-05-21 Thread Maxim Sobolev
Author: sobomax Date: Wed May 22 04:51:08 2019 New Revision: 348091 URL: https://svnweb.freebsd.org/changeset/base/348091 Log: Make aacraid(4) working on ASR8805 & ASR8402 in particular. This patch has been in the PR system for 5 months and then on reviews for another 5. Nobody came with any

svn commit: r345514 - head/sys/fs/tmpfs

2019-03-25 Thread Maxim Sobolev
Author: sobomax Date: Tue Mar 26 01:28:10 2019 New Revision: 345514 URL: https://svnweb.freebsd.org/changeset/base/345514 Log: Refine r345425: get rid of superfluous helper macro that I have added. MFC after:2 weeks Modified: head/sys/fs/tmpfs/tmpfs_vfsops.c Modified: head/sys/fs/tm

svn commit: r345425 - head/sys/fs/tmpfs

2019-03-22 Thread Maxim Sobolev
Author: sobomax Date: Fri Mar 22 21:31:21 2019 New Revision: 345425 URL: https://svnweb.freebsd.org/changeset/base/345425 Log: Make it possible to update TMPFS mount point from read-only to read-write and vice versa. Reviewed by: delphij Approved by: delphij MFC after:2 weeks

svn commit: r344555 - head/usr.sbin/makefs

2019-02-25 Thread Maxim Sobolev
Author: sobomax Date: Mon Feb 25 23:45:36 2019 New Revision: 344555 URL: https://svnweb.freebsd.org/changeset/base/344555 Log: Improve error handling: bail out if one of the files scheduled to go to the FS image we are making cannot be read (e.g. EPERM). Current behaviour when we issue warin

svn commit: r344488 - head/sbin/dhclient

2019-02-23 Thread Maxim Sobolev
Author: sobomax Date: Sat Feb 23 23:31:13 2019 New Revision: 344488 URL: https://svnweb.freebsd.org/changeset/base/344488 Log: Further refine r336195: do not even attempt to verify/update interface's MTU if we've set it once and there were no changes on the DHCP server side since the last re

svn commit: r344479 - head/sys/mips/conf

2019-02-22 Thread Maxim Sobolev
Author: sobomax Date: Sat Feb 23 00:00:49 2019 New Revision: 344479 URL: https://svnweb.freebsd.org/changeset/base/344479 Log: o Get rid of silly comment which seems to have got life of its own via copy-and-paste process; o Return geom_uzip(4) usage back to how manual page prescribes it

Packaging base system (again) [Was: svn commit: r343118 - in head/usr.sbin: . trim]

2019-01-17 Thread Maxim Sobolev
On Thu, Jan 17, 2019 at 2:42 PM Enji Cooper wrote: > > Perhaps even by forking the whole ports idea into a smaller > closely-guarged subset. Something like a new baseports repository, which > might have structure like baseports/usr.bin/xxx, baseports/usr.sbin/yyy > etc. Then add some automagic gl

Re: svn commit: r343118 - in head/usr.sbin: . trim

2019-01-17 Thread Maxim Sobolev
What I think we really need is some way to easily porti-ze useful stuff that would otherwise go into /usr/[s]bin, so adding things would be just as easy as hooking up SUBDIR into usr.[s]bin/Makefile. Yes, I know, this is topic almost as old as the FreeBSD Project itself, but perhaps we just did not

svn commit: r342168 - in head: share/man/man4 sys/netgraph

2018-12-17 Thread Maxim Sobolev
Author: sobomax Date: Mon Dec 17 16:00:35 2018 New Revision: 342168 URL: https://svnweb.freebsd.org/changeset/base/342168 Log: Allow ng_nat to be attached to a ethernet interface directly via ng_ether(4) or the likes. Add new control message types: setdlt and getdlt to switch from default DL

svn commit: r342002 - head/sys/conf

2018-12-12 Thread Maxim Sobolev
Author: sobomax Date: Wed Dec 12 20:40:01 2018 New Revision: 342002 URL: https://svnweb.freebsd.org/changeset/base/342002 Log: Add NETGRAPH_CHECKSUM. MFC after:1 week Modified: head/sys/conf/options Modified: head/sys/conf/options

svn commit: r341996 - head/sys/conf

2018-12-12 Thread Maxim Sobolev
Author: sobomax Date: Wed Dec 12 19:02:37 2018 New Revision: 341996 URL: https://svnweb.freebsd.org/changeset/base/341996 Log: Add NETGRAPH_CHECKSUM. MFC after:1 week Modified: head/sys/conf/NOTES head/sys/conf/files Modified: head/sys/conf/NOTES ==

svn commit: r341749 - in head: share/man/man4 sys/modules/netgraph

2018-12-08 Thread Maxim Sobolev
Author: sobomax Date: Sun Dec 9 02:58:53 2018 New Revision: 341749 URL: https://svnweb.freebsd.org/changeset/base/341749 Log: Hook up ng_checksum(4) module and appropriate manpage to the build. The module was added back in 2016, but has never been connected. MFC after:1 week Modifie

svn commit: r341640 - head/share/misc

2018-12-06 Thread Maxim Sobolev
03/01/16\n2006/08/10"] marcel [label="Marcel Moolenaar\nmar...@freebsd.org\n1999/07/03\n2007/07/01"] +sobomax[label="Maxim Sobolev\nsobo...@freebsd.org\n2000/05/17\n2018/12/03"] steve [label="Steve Price\nst...@freebsd.org\n/xx/xx\n/xx/xx"] will [label=

svn commit: r341494 - head/sys/geom

2018-12-04 Thread Maxim Sobolev
Author: sobomax Date: Tue Dec 4 21:48:56 2018 New Revision: 341494 URL: https://svnweb.freebsd.org/changeset/base/341494 Log: Another attempt to fix issue with the DIOCGDELETE ioctl(2) not handling slightly out-of-bound requests properly (r340187). Perform range check here rather then rely

Re: svn: head/usr.bin: . trim

2018-11-30 Thread Maxim Sobolev
Well, I personally think "erase" better describes the option in question. "delete" is ambiguous, since nothing is really "deleted" here and "trim" refers to a name of a particular command in a particular protocol, which may or may not be around in 10 years from now. However, it looks like the indus

svn commit: r341276 - head/stand/common

2018-11-29 Thread Maxim Sobolev
Author: sobomax Date: Fri Nov 30 02:14:41 2018 New Revision: 341276 URL: https://svnweb.freebsd.org/changeset/base/341276 Log: When handling CMD_CRIT error set command_errmsg to NULL after we dump it out, so that it does not result in error message printed twice. OK load doodoo can't fi

Re: svn: head/usr.bin: . trim

2018-11-29 Thread Maxim Sobolev
For those interested, dd(1) patch is here: https://reviews.freebsd.org/D18382 Feedback is much appreciated. Thanks! -Max On Thu, Nov 29, 2018 at 5:01 PM Alexey Dokuchaev wrote: > On Thu, Nov 29, 2018 at 10:36:02AM -0800, Maxim Sobolev wrote: > > Interesting. I have a similar func

svn commit: r341257 - head/bin/dd

2018-11-29 Thread Maxim Sobolev
Author: sobomax Date: Thu Nov 29 19:28:01 2018 New Revision: 341257 URL: https://svnweb.freebsd.org/changeset/base/341257 Log: Replace hand-crafted naive byte-by-byte zero block detection routine with macro based around memcmp(). The latter is expected to be some 8 times faster on a modern 6

svn commit: r341253 - in head/stand: common i386/libi386 libsa uboot/lib

2018-11-29 Thread Maxim Sobolev
Author: sobomax Date: Thu Nov 29 18:37:48 2018 New Revision: 341253 URL: https://svnweb.freebsd.org/changeset/base/341253 Log: The libstand's panic() appends its own '\n' to the message, so that users of the API don't need to supply one. MFC after:2 weeks Modified: head/stand/comm

Re: svn: head/usr.bin: . trim

2018-11-29 Thread Maxim Sobolev
Interesting. I have a similar functionality implemented as an option for the dd utility in my pipeline (conv=erase). -Max On Thu, Nov 29, 2018 at 6:21 AM Eugene Grosbein wrote: > Author: eugen > Date: Thu Nov 29 14:21:26 2018 > New Revision: 341232 > URL: https://svnweb.freebsd.org/changeset/ba

svn commit: r340857 - head/stand/common

2018-11-23 Thread Maxim Sobolev
Author: sobomax Date: Fri Nov 23 22:36:56 2018 New Revision: 340857 URL: https://svnweb.freebsd.org/changeset/base/340857 Log: Nuke out buffer overflow safety marker code, it duplicates similar code in the malloc()/free() as well as having potential of softening the handling in case error is

svn commit: r340745 - head/contrib/elftoolchain/readelf

2018-11-21 Thread Maxim Sobolev
Author: sobomax Date: Wed Nov 21 21:46:06 2018 New Revision: 340745 URL: https://svnweb.freebsd.org/changeset/base/340745 Log: Fix CU: output of the --debug-dump=decodedline, the problem there is that both file name and current directory is recorded, however file name sometimes already conta

Re: svn commit: r340187 - head/sys/geom

2018-11-07 Thread Maxim Sobolev
Reverted, sorry. Turns out that i/o into last_sector+1 is handled differently. I'll probably have to use different strategy to properly fail out-of-bound ioctl(DIOCGDELETE) or otherwise indicate its result to the userland app. To my defense, this patch has been out for 3 weeks on freebsd-geom, and

svn commit: r340220 - head/sys/geom

2018-11-07 Thread Maxim Sobolev
Author: sobomax Date: Wed Nov 7 16:28:09 2018 New Revision: 340220 URL: https://svnweb.freebsd.org/changeset/base/340220 Log: Revert r340187, it breaks EOD (end-of-device) detection logic. Turns out, i/o into last_sector+N is handled differently for N==1 and N>1 cases to accomodate that, so

Re: svn commit: r340187 - head/sys/geom

2018-11-07 Thread Maxim Sobolev
Li-Wen, thanks for pointing out. I will investigate in the next few hours and follow-up then. Perhaps I need to treat out-of-the bounds BIO_DELETE differently, which was the original issue at hand. -Max On Tue, Nov 6, 2018 at 9:51 PM Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > >

Re: svn commit: r340187 - head/sys/geom

2018-11-06 Thread Maxim Sobolev
Rodney, this was actually my original intention, however then I noticed in the GEOM code there is at least one case when BIO_FLUSH request is being generated internally with bio_offset == mediasize and bio_lenth == 0, so I thought there might be some need to allow such requests through. But I'd hap

svn commit: r340187 - head/sys/geom

2018-11-06 Thread Maxim Sobolev
Author: sobomax Date: Tue Nov 6 15:55:41 2018 New Revision: 340187 URL: https://svnweb.freebsd.org/changeset/base/340187 Log: Don't allow BIO_READ, BIO_WRITE or BIO_DELETE requests that are fully beyond the end of providers media. The only exception is made for the zero length transfers whi

Re: Deorbiting i386

2018-05-27 Thread Maxim Sobolev
many independent commercial implementations already done by compact well focused teams (cyrix, transmeta etc). -Max On Sun, May 27, 2018, 3:15 PM Maxim Sobolev wrote: > Well, strip extra 32 bits, use slower memory and busses (extra decoding > logic etc). Voila, you suddenly have platform that

Re: Deorbiting i386

2018-05-27 Thread Maxim Sobolev
: > On 26 May 2018, at 00:41, Maxim Sobolev wrote: > > > > If you've seen any of the atom bay trail systems in action you may > understand what I mean. You get full blown x64 system with four cores and > it takes only 2W of power. > > Which is pretty much my poi

Re: Deorbiting i386

2018-05-25 Thread Maxim Sobolev
i386 will probably continue to be the platform of choice for many if Intel/Amd play that card right. -Max On Fri, May 25, 2018, 12:27 AM David Chisnall wrote: > On 25 May 2018, at 05:27, Maxim Sobolev wrote: > > > > The idea looks very inmature and short-sighted to me. i386 i

Re: Deorbiting i386

2018-05-25 Thread Maxim Sobolev
The idea looks very inmature and short-sighted to me. i386 is here to stay not as a server/desktop platform but as an embedded/low power/low cost platform for at least 5-10 years to come. There are plenty of applications in the world that don't need > 3gb of memory space and have no use for extra b

svn commit: r323322 - head/sys/compat/freebsd32

2017-09-08 Thread Maxim Sobolev
Author: sobomax Date: Fri Sep 8 18:32:13 2017 New Revision: 323322 URL: https://svnweb.freebsd.org/changeset/base/323322 Log: Correct bintime32 declaration: uint32_t sec -> time32_t sec. Submitted by: jhb MFC after:1 month Modified: head/sys/compat/freebsd32/freebsd32.h Modified:

svn commit: r323254 - head/sys/compat/freebsd32

2017-09-06 Thread Maxim Sobolev
Author: sobomax Date: Thu Sep 7 04:29:57 2017 New Revision: 323254 URL: https://svnweb.freebsd.org/changeset/base/323254 Log: In the recvmsg32() system call iterate over returned structure(s) and convert any messages of types SCM_BINTIME, SCM_TIMESTAMP, SCM_REALTIME and SCM_MONOTONIC from 6

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-09-06 Thread Maxim Sobolev
gt; On Wed, Sep 6, 2017 at 3:15 PM, Maxim Sobolev wrote: > > Alan, I doubt SO_BINTIME / SO_TIMESTAMP ever worked in that scenario. The > > reason for that is size/layout of the bintime (and other structs) is > > different on amd64 as compared to i386 and I don't

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-09-06 Thread Maxim Sobolev
stay tuned. -Max On Mon, Sep 4, 2017 at 7:09 PM, Maxim Sobolev wrote: > Sure, I'll check that out. Thanks for heads up. > > -Max > > On Sun, Sep 3, 2017 at 8:18 PM, Alan Somers wrote: > >> On Mon, Jan 16, 2017 at 10:46 AM, Maxim Sobolev >> wrote: >> &g

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-09-04 Thread Maxim Sobolev
Sure, I'll check that out. Thanks for heads up. -Max On Sun, Sep 3, 2017 at 8:18 PM, Alan Somers wrote: > On Mon, Jan 16, 2017 at 10:46 AM, Maxim Sobolev > wrote: > > Author: sobomax > > Date: Mon Jan 16 17:46:38 2017 > > New Revision: 312296 > > URL: https:

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-31 Thread Maxim Sobolev
Fair enough. If you want I have the patch against 11-stable, we have this feature merged in our private 11.x tree. -Max On Thu, Aug 31, 2017 at 7:26 AM, Ian Lepore wrote: > Unfortunately, I'm not in a position to test those changes. My setup > that uses mdconfig in a 32-bit jail runs on freebs

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-30 Thread Maxim Sobolev
e device data data. If nothing else it would provide a basis to create an unit test for those ioctls. -Max On Tue, Aug 29, 2017 at 7:19 AM, Ian Lepore wrote: > On Mon, 2017-08-28 at 16:40 -0700, Maxim Sobolev wrote: > > John, well, this depends on how you look at it. The padding element

svn commit: r323019 - head/sys/compat/freebsd32

2017-08-30 Thread Maxim Sobolev
Author: sobomax Date: Wed Aug 30 15:07:10 2017 New Revision: 323019 URL: https://svnweb.freebsd.org/changeset/base/323019 Log: Add proper support for the md_label into md(4) ioctl compat layer. While I am here, declare struct md_ioctl32 as packed which allows us to stop playing tricks with s

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-29 Thread Maxim Sobolev
i.e. ptr->md_ywz becomes ptr->md.xyz. On Tue, Aug 29, 2017 at 7:30 AM, John Baldwin wrote: > On Monday, August 28, 2017 04:40:49 PM Maxim Sobolev wrote: > > John, well, this depends on how you look at it. The padding element size > is > > "int", which when you accou

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-29 Thread Maxim Sobolev
s not broken at the moment but the label is not going to be visible to the 32-bit version of the mdconfig(8) running on 64-bit kernels. -Max On Tue, Aug 29, 2017 at 7:19 AM, Ian Lepore wrote: > On Mon, 2017-08-28 at 16:40 -0700, Maxim Sobolev wrote: > > John, well, this depends on how you

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-28 Thread Maxim Sobolev
nk there is any support for having 32-bit mdconfig run on 64-bit kernel. -Max On Mon, Aug 28, 2017 at 1:49 PM, John Baldwin wrote: > On Monday, August 28, 2017 12:46:48 PM Ryan Libby wrote: > > On Mon, Aug 28, 2017 at 11:24 AM, Maxim Sobolev > wrote: > > > Hi John, > > &g

Re: svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-28 Thread Maxim Sobolev
completely orthogonal to this one. Could be a nice feature on its own though, no doubt about it. -Max On Mon, Aug 28, 2017 at 9:19 AM, John Baldwin wrote: > On Monday, August 28, 2017 03:54:08 PM Maxim Sobolev wrote: > > Author: sobomax > > Date: Mon Aug 28 15:54:07 2017

svn commit: r322969 - in head: sbin/mdconfig sys/dev/md sys/sys

2017-08-28 Thread Maxim Sobolev
Author: sobomax Date: Mon Aug 28 15:54:07 2017 New Revision: 322969 URL: https://svnweb.freebsd.org/changeset/base/322969 Log: Add ability to label md(4) devices. This feature comes from the fact that we rely memory-backed md(4) in our build process heavily. However, if the build goes hay

svn commit: r322896 - in head/sys/boot: efi/loader efi/loader/arch/amd64 efi/loader/arch/i386 i386/libi386

2017-08-25 Thread Maxim Sobolev
Author: sobomax Date: Fri Aug 25 17:29:48 2017 New Revision: 322896 URL: https://svnweb.freebsd.org/changeset/base/322896 Log: Make spinconsole platform independent and hook it up into EFI loader on i386 and amd64. Not enabled on ARMs, those are lacking timer routines. MFC after:2 mot

Re: svn commit: r320277 - head/usr.bin/mkuzip

2017-06-23 Thread Maxim Sobolev
Yeah, silly me. Thanks^2. -Max On Fri, Jun 23, 2017 at 3:54 PM, Conrad Meyer wrote: > One more nit. > > On Fri, Jun 23, 2017 at 10:39 AM, Maxim Sobolev > wrote: > > Author: sobomax > > Date: Fri Jun 23 17:39:00 2017 > > New Revision: 320277 > > URL: https

svn commit: r320301 - head/usr.bin/mkuzip

2017-06-23 Thread Maxim Sobolev
Author: sobomax Date: Fri Jun 23 23:11:05 2017 New Revision: 320301 URL: https://svnweb.freebsd.org/changeset/base/320301 Log: Doh, fix some botched "fix" in r320277. Reported by: cem MFC after:6 weeks Modified: head/usr.bin/mkuzip/mkuz_insize.c Modified: head/usr.bin/mkuzip/mkuz

Re: svn commit: r320048 - head/usr.bin/mkuzip

2017-06-23 Thread Maxim Sobolev
Sorry overlooked that. Fixed, thanks! -Maxim On Thu, Jun 22, 2017 at 5:13 PM, Conrad Meyer wrote: > ffd is leaked in return paths. Coverity CID 1376420. > > On Fri, Jun 16, 2017 at 7:58 PM, Maxim Sobolev > wrote: > > Author: sobomax > > Date: Sat Jun 17 02:58:31 2017

svn commit: r320277 - head/usr.bin/mkuzip

2017-06-23 Thread Maxim Sobolev
Author: sobomax Date: Fri Jun 23 17:39:00 2017 New Revision: 320277 URL: https://svnweb.freebsd.org/changeset/base/320277 Log: Don't leak file descriptor in some cases. Reported by: cem MFC after:6 weeks Modified: head/usr.bin/mkuzip/mkuz_insize.c Modified: head/usr.bin/mkuzip/mk

svn commit: r320048 - head/usr.bin/mkuzip

2017-06-16 Thread Maxim Sobolev
ize.c == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/usr.bin/mkuzip/mkuz_insize.c Sat Jun 17 02:58:31 2017 (r320048) @@ -0,0 +1,80 @@ +/* + * Copyright (c) 2004-2016 Maxim Sobolev + * All rights reserved. + * + * Redistributio

svn commit: r320004 - head/lib/libc/sys

2017-06-16 Thread Maxim Sobolev
Author: sobomax Date: Fri Jun 16 15:09:43 2017 New Revision: 320004 URL: https://svnweb.freebsd.org/changeset/base/320004 Log: Document st_flags in the stat(2). Approved by: mckusick,vangyzen,jilles Differential Revision:https://reviews.freebsd.org/D10852 Modified: head/lib/li

Re: svn commit: r316874 - head/sys/kern

2017-04-15 Thread Maxim Sobolev
an schrieb: > > > On 4/15/17, 6:00 AM, "Maxim Sobolev" behalf of > > sobo...@freebsd.org> wrote: > > > > Peter, Ngie, none of this stuff is really directly related to the > > shutdown(2) change, so I'll probably let Hiroki to clean it u

svn commit: r316973 - head/usr.sbin/syslogd

2017-04-15 Thread Maxim Sobolev
Author: sobomax Date: Sat Apr 15 18:20:11 2017 New Revision: 316973 URL: https://svnweb.freebsd.org/changeset/base/316973 Log: Fix another logic bug that came out of recent syslogd refactoring and exposed by the r316874: don't call shutdown(2) on all sockets, but only net ones, which seems

Re: svn commit: r316874 - head/sys/kern

2017-04-15 Thread Maxim Sobolev
20:12, Peter Wemm wrote: > > > > > > On Friday, April 14, 2017 07:36:55 PM Peter Wemm wrote: > > >> On Friday, April 14, 2017 02:14:16 PM Ngie Cooper wrote: > > >>>> On Apr 14, 2017, at 14:10, Maxim Sobolev > wrote: > > >>>> > &g

svn commit: r316951 - head/usr.sbin/syslogd

2017-04-14 Thread Maxim Sobolev
Author: sobomax Date: Sat Apr 15 02:24:22 2017 New Revision: 316951 URL: https://svnweb.freebsd.org/changeset/base/316951 Log: Since shutdown(2) on datagram socket is no longer a NOP after rev 316874 don't bother to select/recv on that socket. This prevents syslogd(8) from spinning endlessly

Re: svn commit: r316874 - head/sys/kern

2017-04-14 Thread Maxim Sobolev
:52 PM Maxim Sobolev wrote: > > Thanks, Peter. I will try to look into this asap. > > I don't understand what is going on yet. Presumably there must be other > changes in play that affect udp/select sometime between the original 2015 > change and this. The syslogd -s code is Ol

Re: svn commit: r316874 - head/sys/kern

2017-04-14 Thread Maxim Sobolev
into uipc_sockets.c) and let me know if it helps. Thanks! On Fri, Apr 14, 2017 at 12:48 PM, Ngie Cooper (yaneurabeya) < yaneurab...@gmail.com> wrote: > > > On Apr 14, 2017, at 12:46, Peter Wemm wrote: > > > > On Friday, April 14, 2017 12:41:52 PM Maxim Sobolev wrote: > &g

Re: svn commit: r316874 - head/sys/kern

2017-04-14 Thread Maxim Sobolev
Thanks, Peter. I will try to look into this asap. -Max On Apr 14, 2017 12:32 PM, "Peter Wemm" wrote: > On Friday, April 14, 2017 11:49:26 AM Peter Wemm wrote: > > On Friday, April 14, 2017 05:23:28 PM Maxim Sobolev wrote: > > > Author: sobomax > > > Dat

svn commit: r316874 - head/sys/kern

2017-04-14 Thread Maxim Sobolev
Author: sobomax Date: Fri Apr 14 17:23:28 2017 New Revision: 316874 URL: https://svnweb.freebsd.org/changeset/base/316874 Log: Restore ability to shutdown DGRAM sockets, still forcing ENOTCONN to be returned by the shutdown(2) system call. This ability has been lost as part of the svn revis

svn commit: r316738 - head/sbin/mksnap_ffs

2017-04-12 Thread Maxim Sobolev
Author: sobomax Date: Wed Apr 12 19:23:41 2017 New Revision: 316738 URL: https://svnweb.freebsd.org/changeset/base/316738 Log: Fix an issue in the rev.316718 causing variable to be unsed uninitialized. Reported by:Coverity Nudged by: cem MFC after:2 weeks Modified: head/

Re: svn commit: r316718 - head/sbin/mksnap_ffs

2017-04-12 Thread Maxim Sobolev
D 1374247. > > On Tue, Apr 11, 2017 at 2:55 PM, Maxim Sobolev > wrote: > > Author: sobomax > > Date: Tue Apr 11 21:55:39 2017 > > New Revision: 316718 > > URL: https://svnweb.freebsd.org/changeset/base/316718 > > > > ... > > --- head/sbin/mksnap_

svn commit: r316718 - head/sbin/mksnap_ffs

2017-04-11 Thread Maxim Sobolev
Author: sobomax Date: Tue Apr 11 21:55:39 2017 New Revision: 316718 URL: https://svnweb.freebsd.org/changeset/base/316718 Log: Work around an issue with mksnap_ffs not working in chroot'ed environment. The problem is that the statfs(2) system call used to determine the relevant mount point r

Re: On shutting down UDP socket [Re: svn commit: r285910 - in head: lib/libc/sys sys/kern sys/sys]

2017-04-10 Thread Maxim Sobolev
JFYI. I've opened a follow-up differential for this potential regression: https://reviews.freebsd.org/D10351 Thanks! -Max On Mon, Apr 10, 2017 at 7:43 AM, Maxim Sobolev wrote: > Hi Guys, I am sorry to bring this old thread up, but I think Ed's > comparison with other OSes

On shutting down UDP socket [Re: svn commit: r285910 - in head: lib/libc/sys sys/kern sys/sys]

2017-04-10 Thread Maxim Sobolev
Hi Guys, I am sorry to bring this old thread up, but I think Ed's comparison with other OSes here and in the relevant differential was not entirely correct. What linux does (tested with 4.4.0) when UDP socket is shut down is actually shutting down receiving end, so any threads that are blocked in r

svn commit: r312554 - head/lib/libc/sys

2017-01-20 Thread Maxim Sobolev
Author: sobomax Date: Fri Jan 20 18:37:14 2017 New Revision: 312554 URL: https://svnweb.freebsd.org/changeset/base/312554 Log: Improve wording around SO_TS_CLOCK documentation. Submitted by: wblock Differential Revision:https://reviews.freebsd.org/D9171 Modified: head/lib/libc/

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Maxim Sobolev
ike an enum is just fine. And I agree > > with Gleb that it is preferable. > > > > Conrad > > > > On Tue, Jan 17, 2017 at 1:34 PM, Maxim Sobolev > > wrote: > > > > > > Well as other pointed out there are some concerns with using enums > > >

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Maxim Sobolev
Well as other pointed out there are some concerns with using enums from C++ and ABI prospective. So it looks to me that there is no general consensus on that direction. -Max On Tue, Jan 17, 2017 at 1:27 PM, Gleb Smirnoff wrote: > On Tue, Jan 17, 2017 at 08:40:50AM -0800, Maxim Sobolev wr

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Maxim Sobolev
That being said, is there any other socket option value in there implemented as enum? I don't see anything obvious, so that I am curious if it would stick out as an odd one in there. What do you think? -Max On Tue, Jan 17, 2017 at 6:22 AM, Maxim Sobolev wrote: > Of course it's pos

Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-17 Thread Maxim Sobolev
Of course it's possible. Do you guys want me to amend that patch? -Max On Mon, Jan 16, 2017 at 10:52 PM, Gleb Smirnoff wrote: > Hi! > > On Mon, Jan 16, 2017 at 05:46:38PM +, Maxim Sobolev wrote: > M> Author: sobomax > M> Date: Mon Jan 16 17:46:38 2017 > M&g

svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg

2017-01-16 Thread Maxim Sobolev
Author: sobomax Date: Mon Jan 16 17:46:38 2017 New Revision: 312296 URL: https://svnweb.freebsd.org/changeset/base/312296 Log: Add a new socket option SO_TS_CLOCK to pick from several different clock sources to return timestamps when SO_TIMESTAMP is enabled. Two additional clock sources are:

svn commit: r311974 - head/sys/netinet

2017-01-12 Thread Maxim Sobolev
Author: sobomax Date: Thu Jan 12 10:14:54 2017 New Revision: 311974 URL: https://svnweb.freebsd.org/changeset/base/311974 Log: Fix slight type mismatch between so_options defined in sys/socketvar.h and tw_so_options defined here which is supposed to be a copy of the former (short vs u_short

svn commit: r309773 - head/tools/regression/sockets/unix_cmsg

2016-12-09 Thread Maxim Sobolev
Author: sobomax Date: Fri Dec 9 22:13:00 2016 New Revision: 309773 URL: https://svnweb.freebsd.org/changeset/base/309773 Log: Check that SCM_XXX timestamp returned by the kernel is less 1 second away in the past from the current time. This should be plenty for the scheduler to do its job. I

svn commit: r309631 - head/tools/regression/sockets/unix_cmsg

2016-12-06 Thread Maxim Sobolev
Author: sobomax Date: Tue Dec 6 18:22:25 2016 New Revision: 309631 URL: https://svnweb.freebsd.org/changeset/base/309631 Log: Auto-generate 2 test cases that differ only in structure and SCM_XXX constant used. We can do it programmatically, but that would make code convoluted and more compl

svn commit: r309554 - head/tools/regression/sockets/unix_cmsg

2016-12-05 Thread Maxim Sobolev
Author: sobomax Date: Mon Dec 5 17:21:04 2016 New Revision: 309554 URL: https://svnweb.freebsd.org/changeset/base/309554 Log: Refactor the regression test code by splitting huge monolithic C file into smaller pieces that are hopefully easier to understand and extend. This is to pave the gro

Re: svn commit: r302985 - head/sys/geom/label

2016-07-18 Thread Maxim Sobolev
tell. So if it worked with the strict comparison, it should also work with relaxed bound one. https://reviews.freebsd.org/D6208 Thanks! -Max On Mon, Jul 18, 2016 at 1:18 PM, Andrey V. Elsukov wrote: > On 18.07.16 22:37, Maxim Sobolev wrote: > > Well, this looks to me exactly what I am

Re: svn commit: r302985 - head/sys/geom/label

2016-07-18 Thread Maxim Sobolev
lsukov wrote: > On 18.07.16 17:24, Maxim Sobolev wrote: > > Andrey, are you talking about this: > > > > --- > > r156299 | pjd | 2006-03-04 11:41:54 -0800 (сб, 04 мар 2006) | 11 lines > > > > We need to check if file system size is equal to provider's size, b

Re: svn commit: r302985 - head/sys/geom/label

2016-07-18 Thread Maxim Sobolev
I think people might be worried about existing deployed systems that might stop booting if geom label obscures the whole disk making one or more slices unavailable via geom_label mechanism. -Max On Mon, Jul 18, 2016 at 10:09 AM, Devin Teske wrote: > > > On Jul 18, 2016, at 7:24

Re: svn commit: r302985 - head/sys/geom/label

2016-07-18 Thread Maxim Sobolev
those cases I don't think it makes much difference if we are attaching to a slice or a partition. -Maxim On Sun, Jul 17, 2016 at 10:37 PM, Andrey V. Elsukov wrote: > On 18.07.16 08:00, Maxim Sobolev wrote: > > Author: sobomax > > Date: Mon Jul 18 05:00:01 2016 > > New R

svn commit: r302985 - head/sys/geom/label

2016-07-17 Thread Maxim Sobolev
Author: sobomax Date: Mon Jul 18 05:00:01 2016 New Revision: 302985 URL: https://svnweb.freebsd.org/changeset/base/302985 Log: Relax checking if the privider size matches size recorded in the superblock, allowing provider to be bit bigger, i.e. have some extra padding after the FS image. Tha

svn commit: r302978 - head/sys/x86/x86

2016-07-17 Thread Maxim Sobolev
Author: sobomax Date: Mon Jul 18 03:59:03 2016 New Revision: 302978 URL: https://svnweb.freebsd.org/changeset/base/302978 Log: Don't print same value twice, one in decimal once in hex. This makes output more cryptic than it needs to be and wastes cpu cycles and console bandwidth. Modified:

svn commit: r302284 - head/sys/geom/uzip

2016-06-29 Thread Maxim Sobolev
Author: sobomax Date: Wed Jun 29 18:19:05 2016 New Revision: 302284 URL: https://svnweb.freebsd.org/changeset/base/302284 Log: 1.Improve handling around last compressed block of the file, which is necessary because CLOOP format lacks explicit EOF or length, so that in the presence of pad

svn commit: r299195 - head/sys/geom/uzip

2016-05-06 Thread Maxim Sobolev
Author: sobomax Date: Fri May 6 20:32:39 2016 New Revision: 299195 URL: https://svnweb.freebsd.org/changeset/base/299195 Log: Add missing include "opt_geom.h" to make GEOM_UZIP_DEBUG option working, also rename enum member so it does not conflict with GEOM_UZIP option name. Submitted b

svn commit: r298619 - head/sys/geom/uzip

2016-04-25 Thread Maxim Sobolev
Author: sobomax Date: Tue Apr 26 06:50:38 2016 New Revision: 298619 URL: https://svnweb.freebsd.org/changeset/base/298619 Log: Relax TOC offsets checking somewhat, allowing offset pointing to the next byte past EOF to denote zero-block(s) at the very end of the file. Modified: head/sys/ge

Re: svn: head/usr.bin/mkuzip

2016-04-25 Thread Maxim Sobolev
Thanks and sorry about that. I did not realize we use different compilers for different architectures. By any chance, do you know is there a way to test buildworld on amd64 with gcc? On Mon, Apr 25, 2016 at 6:20 AM, Bjoern A. Zeeb wrote: > Author: bz > Date: Mon Apr 25 13:20:35 2016 > New Revisi

  1   2   3   >